qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Halil Pasic <pasic@linux.ibm.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Halil Pasic <pasic@linux.ibm.com>,
	Hanna Reitz <hreitz@redhat.com>,
	qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [PATCH] block: introduce max_hw_iov for use in scsi-generic
Date: Thu, 23 Sep 2021 18:47:40 +0200	[thread overview]
Message-ID: <20210923184740.6363ea31.pasic@linux.ibm.com> (raw)
In-Reply-To: <20210923162811.3ab68c5f.pasic@linux.ibm.com>

On Thu, 23 Sep 2021 16:28:11 +0200
Halil Pasic <pasic@linux.ibm.com> wrote:

> Can't we use some of the established constants instead of hard coding a
> qemu specific IOV_MAX?
> 
> POSIX.1 seems to guarantee the availability of IOV_MAX in <limits.h>
> according to: https://man7.org/linux/man-pages/man2/readv.2.html
> and <sys/uio.h> may have UIO_MAXIOV defined.

Never mind, the 
#define IOV_MAX 1024
in osdep.h is conditional and I guess we already use IOV_MAX from limit
when CONFIG_IOVEC is defined, i.e. when we don't emulate the interface.

Sorry for the noise.

Regards,
Halil


  reply	other threads:[~2021-09-23 16:48 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-23 13:04 [PATCH] block: introduce max_hw_iov for use in scsi-generic Paolo Bonzini
2021-09-23 14:28 ` Halil Pasic
2021-09-23 16:47   ` Halil Pasic [this message]
2021-09-23 14:48 ` Christian Borntraeger
2021-09-24  5:27   ` Paolo Bonzini
2021-09-24  6:50     ` Christian Borntraeger
2021-09-24 15:03       ` Michael Roth via
2021-09-24  9:55 ` Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210923184740.6363ea31.pasic@linux.ibm.com \
    --to=pasic@linux.ibm.com \
    --cc=hreitz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).