From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D47BC433F5 for ; Mon, 27 Sep 2021 06:03:42 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EE3BE610E8 for ; Mon, 27 Sep 2021 06:03:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org EE3BE610E8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:33446 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mUjjp-0006QE-3A for qemu-devel@archiver.kernel.org; Mon, 27 Sep 2021 02:03:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35846) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mUjI0-0001Rc-FO for qemu-devel@nongnu.org; Mon, 27 Sep 2021 01:34:56 -0400 Received: from mga07.intel.com ([134.134.136.100]:13820) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mUjHy-0005CR-06 for qemu-devel@nongnu.org; Mon, 27 Sep 2021 01:34:55 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10119"; a="288072090" X-IronPort-AV: E=Sophos;i="5.85,325,1624345200"; d="scan'208";a="288072090" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Sep 2021 22:34:48 -0700 X-IronPort-AV: E=Sophos;i="5.85,325,1624345200"; d="scan'208";a="552995654" Received: from yangzhon-virtual.bj.intel.com (HELO yangzhon-Virtual) ([10.238.144.101]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-SHA256; 26 Sep 2021 22:34:42 -0700 Date: Mon, 27 Sep 2021 13:20:34 +0800 From: Yang Zhong To: Eric Blake Subject: Re: [PATCH v5 04/26] qom: Add memory-backend-epc ObjectOptions support Message-ID: <20210927052034.GA15096@yangzhon-Virtual> References: <20210924112509.25061-1-pbonzini@redhat.com> <20210924112509.25061-5-pbonzini@redhat.com> <20210924135640.svjs3avfaguq5kxf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210924135640.svjs3avfaguq5kxf@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Received-SPF: pass client-ip=134.134.136.100; envelope-from=yang.zhong@intel.com; helo=mga07.intel.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: yang.zhong@intel.com, pbonzini@redhat.com, philmd@redhat.com, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, Sep 24, 2021 at 08:56:40AM -0500, Eric Blake wrote: > On Fri, Sep 24, 2021 at 01:24:47PM +0200, Paolo Bonzini wrote: > > From: Yang Zhong > > > > Add the new 'memory-backend-epc' user creatable QOM object in > > the ObjectOptions to support SGX since v6.1, or the sgx backend > > object cannot bootup. > > > > Signed-off-by: Yang Zhong > > Message-Id: <20210719112136.57018-4-yang.zhong@intel.com> > > Signed-off-by: Paolo Bonzini > > --- > > qapi/qom.json | 19 +++++++++++++++++++ > > 1 file changed, 19 insertions(+) > > > > diff --git a/qapi/qom.json b/qapi/qom.json > > index a25616bc7a..0222bb4506 100644 > > --- a/qapi/qom.json > > +++ b/qapi/qom.json > > @@ -647,6 +647,23 @@ > > '*hugetlbsize': 'size', > > '*seal': 'bool' } } > > > > +## > > +# @MemoryBackendEpcProperties: > > +# > > +# Properties for memory-backend-epc objects. > > +# > > +# The @share boolean option is true by default with epc > > +# > > +# The @merge boolean option is false by default with epc > > +# > > +# The @dump boolean option is false by default with epc > > +# > > +# Since: 6.2 > > +## > > +{ 'struct': 'MemoryBackendEpcProperties', > > + 'base': 'MemoryBackendProperties', > > + 'data': {} } > > Is the intent to add more members to data in later patches? Otherwise,... No new members will be added. thanks! MemoryBackendProperties will replace this. Yang > > > + > > ## > > # @PrManagerHelperProperties: > > # > > @@ -797,6 +814,7 @@ > > { 'name': 'memory-backend-memfd', > > 'if': 'CONFIG_LINUX' }, > > 'memory-backend-ram', > > + 'memory-backend-epc', > > 'pef-guest', > > 'pr-manager-helper', > > 'qtest', > > @@ -855,6 +873,7 @@ > > 'memory-backend-memfd': { 'type': 'MemoryBackendMemfdProperties', > > 'if': 'CONFIG_LINUX' }, > > 'memory-backend-ram': 'MemoryBackendProperties', > > + 'memory-backend-epc': 'MemoryBackendEpcProperties', > > ...this could have just been MemoryBackendProperties. Ditto, thanks! Yang > > > 'pr-manager-helper': 'PrManagerHelperProperties', > > 'qtest': 'QtestProperties', > > 'rng-builtin': 'RngProperties', > > -- > > 2.31.1 > > > > > > -- > Eric Blake, Principal Software Engineer > Red Hat, Inc. +1-919-301-3266 > Virtualization: qemu.org | libvirt.org