From: Gerd Hoffmann <kraxel@redhat.com>
To: Antonio Caggiano <antonio.caggiano@collabora.com>
Cc: qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH 1/1] virtio-gpu: CONTEXT_INIT feature
Date: Tue, 28 Sep 2021 07:13:58 +0200 [thread overview]
Message-ID: <20210928051358.qlyssfoyrslm7544@sirius.home.kraxel.org> (raw)
In-Reply-To: <20210927144840.3661593-2-antonio.caggiano@collabora.com>
> @@ -212,6 +212,8 @@ virtio_gpu_base_get_features(VirtIODevice *vdev, uint64_t features,
> features |= (1 << VIRTIO_GPU_F_RESOURCE_BLOB);
> }
>
> + features |= (1 << VIRTIO_GPU_F_CONTEXT_INIT);
This needs a config option, simliar to the other features. It is a
guest-visible change so we must be able to turn it off for live
migration compatibility reasons. We also need a compat property to
turn it off by default for 6.1 + older machine types.
> + if (cc.context_init) {
> + virgl_renderer_context_create_with_flags(cc.hdr.ctx_id,
> + cc.context_init,
> + cc.nlen,
> + cc.debug_name);
This requires a minimum virglrenderer version I guess?
> --- a/include/standard-headers/linux/virtio_gpu.h
> +++ b/include/standard-headers/linux/virtio_gpu.h
Separate patch please.
Also use scripts/update-linux-headers.sh for this.
take care,
Gerd
next prev parent reply other threads:[~2021-09-28 5:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-27 14:48 [PATCH 0/1] virtio-gpu: CONTEXT_INIT feature Antonio Caggiano
2021-09-27 14:48 ` [PATCH 1/1] " Antonio Caggiano
2021-09-28 5:13 ` Gerd Hoffmann [this message]
2021-09-28 10:16 ` Antonio Caggiano
2021-09-28 11:56 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210928051358.qlyssfoyrslm7544@sirius.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=antonio.caggiano@collabora.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).