From: Yanan Wang <wangyanan55@huawei.com>
To: <qemu-devel@nongnu.org>, <qemu-trivial@nongnu.org>
Cc: "Yanan Wang" <wangyanan55@huawei.com>,
wanghaibin.wang@huawei.com, "Andrew Jones" <drjones@redhat.com>,
"Daniel P . Berrangé" <berrange@redhat.com>,
"Laurent Vivier" <laurent@vivier.eu>
Subject: [PATCH 2/2] qemu-options: Add missing "sockets=2" to CLI "-smp 2"
Date: Tue, 28 Sep 2021 17:31:57 +0800 [thread overview]
Message-ID: <20210928093157.14620-3-wangyanan55@huawei.com> (raw)
In-Reply-To: <20210928093157.14620-1-wangyanan55@huawei.com>
There is one example of -smp CLI in qemu-options.hx currently
using "-smp 2" and assuming that there will be 2 sockets.
However now the actually calculation logic of missing sockets
and cores is not immutable, we should use more explicit CLIs
like "-smp 2,sockets=2" if we want multiple sockets.
Signed-off-by: Yanan Wang <wangyanan55@huawei.com>
---
qemu-options.hx | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qemu-options.hx b/qemu-options.hx
index dcd9595650..ff8917c5e1 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -395,7 +395,7 @@ SRST
-m 2G \
-object memory-backend-ram,size=1G,id=m0 \
-object memory-backend-ram,size=1G,id=m1 \
- -smp 2 \
+ -smp 2,sockets=2,maxcpus=2 \
-numa node,nodeid=0,memdev=m0 \
-numa node,nodeid=1,memdev=m1,initiator=0 \
-numa cpu,node-id=0,socket-id=0 \
--
2.19.1
next prev parent reply other threads:[~2021-09-28 9:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-28 9:31 [PATCH 0/2] qemu-options: Trivial doc fixes related to -smp Yanan Wang
2021-09-28 9:31 ` [PATCH 1/2] qemu-options: Tweak [, maxcpus=cpus] to [, maxcpus=maxcpus] Yanan Wang
2021-09-28 10:40 ` Damien Hedde
2021-09-28 9:31 ` Yanan Wang [this message]
2021-09-28 10:46 ` [PATCH 2/2] qemu-options: Add missing "sockets=2" to CLI "-smp 2" Philippe Mathieu-Daudé
2021-09-28 10:58 ` wangyanan (Y)
2021-09-28 11:01 ` Daniel P. Berrangé
2021-09-28 11:42 ` wangyanan (Y)
2021-09-28 11:49 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210928093157.14620-3-wangyanan55@huawei.com \
--to=wangyanan55@huawei.com \
--cc=berrange@redhat.com \
--cc=drjones@redhat.com \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=wanghaibin.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).