From: Laurent Vivier <laurent@vivier.eu>
To: qemu-devel@nongnu.org
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Laurent Vivier" <laurent@vivier.eu>
Subject: [PULL 09/26] linux-user/hppa: Document non-use of setup_sigtramp
Date: Mon, 4 Oct 2021 09:44:04 +0200 [thread overview]
Message-ID: <20211004074421.3141222-10-laurent@vivier.eu> (raw)
In-Reply-To: <20211004074421.3141222-1-laurent@vivier.eu>
From: Richard Henderson <richard.henderson@linaro.org>
We cannot use a raw sigtramp page for hppa,
but must wait for full vdso support.
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20210929130553.121567-10-richard.henderson@linaro.org>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
linux-user/hppa/target_signal.h | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/linux-user/hppa/target_signal.h b/linux-user/hppa/target_signal.h
index 7f525362e91a..d558119ee7bd 100644
--- a/linux-user/hppa/target_signal.h
+++ b/linux-user/hppa/target_signal.h
@@ -71,4 +71,18 @@ typedef struct target_sigaltstack {
/* mask for all SS_xxx flags */
#define TARGET_SS_FLAG_BITS TARGET_SS_AUTODISARM
+/*
+ * We cannot use a bare sigtramp page for hppa-linux.
+ *
+ * Unlike other guests where we use the instructions at PC to validate
+ * an offset from SP, the hppa libgcc signal frame fallback unwinding uses
+ * the PC address itself to find the frame. This is due to the fact that
+ * the hppa grows the stack upward, and the frame is of unknown size.
+ *
+ * TODO: We should be able to use a VDSO to address this, by providing
+ * proper unwind info for the sigtramp code, at which point the fallback
+ * unwinder will not be used.
+ */
+#define TARGET_ARCH_HAS_SIGTRAMP_PAGE 0
+
#endif /* HPPA_TARGET_SIGNAL_H */
--
2.31.1
next prev parent reply other threads:[~2021-10-04 8:11 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-04 7:43 [PULL 00/26] Linux user for 6.2 patches Laurent Vivier
2021-10-04 7:43 ` [PULL 01/26] linux-user: Add infrastructure for a signal trampoline page Laurent Vivier
2021-11-05 16:09 ` Peter Maydell
2021-10-04 7:43 ` [PULL 02/26] linux-user/aarch64: Implement setup_sigtramp Laurent Vivier
2021-10-04 7:43 ` [PULL 03/26] linux-user/arm: Drop v1 signal frames Laurent Vivier
2021-10-04 7:43 ` [PULL 04/26] linux-user/arm: Drop "_v2" from symbols in signal.c Laurent Vivier
2021-10-04 7:44 ` [PULL 05/26] linux-user/arm: Implement setup_sigtramp Laurent Vivier
2021-10-04 7:44 ` [PULL 06/26] linux-user/alpha: " Laurent Vivier
2021-10-04 7:44 ` [PULL 07/26] linux-user/cris: " Laurent Vivier
2021-10-04 7:44 ` [PULL 08/26] linux-user/hexagon: " Laurent Vivier
2021-10-04 7:44 ` Laurent Vivier [this message]
2021-10-04 7:44 ` [PULL 10/26] linux-user/i386: " Laurent Vivier
2021-10-04 7:44 ` [PULL 11/26] linux-user/x86_64: Raise SIGSEGV if SA_RESTORER not set Laurent Vivier
2021-10-04 7:44 ` [PULL 12/26] linux-user/m68k: Implement setup_sigtramp Laurent Vivier
2021-10-04 7:44 ` [PULL 13/26] linux-user/microblaze: " Laurent Vivier
2021-10-04 7:44 ` [PULL 14/26] linux-user/mips: Tidy install_sigtramp Laurent Vivier
2021-10-04 7:44 ` [PULL 15/26] linux-user/mips: Implement setup_sigtramp Laurent Vivier
2021-10-04 7:44 ` [PULL 16/26] linux-user/nios2: Document non-use of setup_sigtramp Laurent Vivier
2021-10-04 7:44 ` [PULL 17/26] linux-user/openrisc: Implement setup_sigtramp Laurent Vivier
2021-10-04 7:44 ` [PULL 18/26] linux-user/ppc: Simplify encode_trampoline Laurent Vivier
2021-10-04 7:44 ` [PULL 19/26] linux-user/ppc: Implement setup_sigtramp Laurent Vivier
2021-10-04 7:44 ` [PULL 20/26] linux-user/riscv: " Laurent Vivier
2021-10-04 7:44 ` [PULL 21/26] linux-user/s390x: " Laurent Vivier
2021-10-04 7:44 ` [PULL 22/26] linux-user/sh4: " Laurent Vivier
2021-10-04 7:44 ` [PULL 23/26] linux-user/sparc: " Laurent Vivier
2021-10-04 7:44 ` [PULL 24/26] linux-user/xtensa: " Laurent Vivier
2021-10-04 7:44 ` [PULL 25/26] linux-user: Remove default for TARGET_ARCH_HAS_SIGTRAMP_PAGE Laurent Vivier
2021-10-04 7:44 ` [PULL 26/26] tests/tcg/multiarch: Re-enable signals test for most guests Laurent Vivier
2021-10-04 23:27 ` [PULL 00/26] Linux user for 6.2 patches Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211004074421.3141222-10-laurent@vivier.eu \
--to=laurent@vivier.eu \
--cc=alex.bennee@linaro.org \
--cc=f4bug@amsat.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).