qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Vivier <laurent@vivier.eu>
To: qemu-devel@nongnu.org
Cc: "Max Filippov" <jcmvbkbc@gmail.com>,
	"Laurent Vivier" <laurent@vivier.eu>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	"Peter Maydell" <peter.maydell@linaro.org>
Subject: [PULL 01/26] linux-user: Add infrastructure for a signal trampoline page
Date: Mon,  4 Oct 2021 09:43:56 +0200	[thread overview]
Message-ID: <20211004074421.3141222-2-laurent@vivier.eu> (raw)
In-Reply-To: <20211004074421.3141222-1-laurent@vivier.eu>

From: Richard Henderson <richard.henderson@linaro.org>

Allocate a page to hold the signal trampoline(s).
Invoke a guest-specific hook to fill in the contents
of the page before marking it read-execute again.

Reviewed-by: Max Filippov <jcmvbkbc@gmail.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20210929130553.121567-2-richard.henderson@linaro.org>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
 linux-user/elfload.c       | 18 ++++++++++++++++++
 linux-user/signal-common.h |  6 ++++++
 linux-user/signal.c        |  3 +++
 3 files changed, 27 insertions(+)

diff --git a/linux-user/elfload.c b/linux-user/elfload.c
index 5f9e2141ad1e..459a26ef1d93 100644
--- a/linux-user/elfload.c
+++ b/linux-user/elfload.c
@@ -7,6 +7,7 @@
 
 #include "qemu.h"
 #include "user-internals.h"
+#include "signal-common.h"
 #include "loader.h"
 #include "user-mmap.h"
 #include "disas/disas.h"
@@ -17,6 +18,7 @@
 #include "qemu/units.h"
 #include "qemu/selfmap.h"
 #include "qapi/error.h"
+#include "target_signal.h"
 
 #ifdef _ARCH_PPC64
 #undef ARCH_DLINFO
@@ -28,6 +30,10 @@
 #undef ELF_ARCH
 #endif
 
+#ifndef TARGET_ARCH_HAS_SIGTRAMP_PAGE
+#define TARGET_ARCH_HAS_SIGTRAMP_PAGE 0
+#endif
+
 #define ELF_OSABI   ELFOSABI_SYSV
 
 /* from personality.h */
@@ -3249,6 +3255,18 @@ int load_elf_binary(struct linux_binprm *bprm, struct image_info *info)
 #endif
     }
 
+    /*
+     * TODO: load a vdso, which would also contain the signal trampolines.
+     * Otherwise, allocate a private page to hold them.
+     */
+    if (TARGET_ARCH_HAS_SIGTRAMP_PAGE) {
+        abi_ulong tramp_page = target_mmap(0, TARGET_PAGE_SIZE,
+                                           PROT_READ | PROT_WRITE,
+                                           MAP_PRIVATE | MAP_ANON, -1, 0);
+        setup_sigtramp(tramp_page);
+        target_mprotect(tramp_page, TARGET_PAGE_SIZE, PROT_READ | PROT_EXEC);
+    }
+
     bprm->p = create_elf_tables(bprm->p, bprm->argc, bprm->envc, &elf_ex,
                                 info, (elf_interpreter ? &interp_info : NULL));
     info->start_stack = bprm->p;
diff --git a/linux-user/signal-common.h b/linux-user/signal-common.h
index 79511becb4e7..7457f8025c47 100644
--- a/linux-user/signal-common.h
+++ b/linux-user/signal-common.h
@@ -20,6 +20,12 @@
 #ifndef SIGNAL_COMMON_H
 #define SIGNAL_COMMON_H
 
+/* Fallback addresses into sigtramp page. */
+extern abi_ulong default_sigreturn;
+extern abi_ulong default_rt_sigreturn;
+
+void setup_sigtramp(abi_ulong tramp_page);
+
 int on_sig_stack(unsigned long sp);
 int sas_ss_flags(unsigned long sp);
 abi_ulong target_sigsp(abi_ulong sp, struct target_sigaction *ka);
diff --git a/linux-user/signal.c b/linux-user/signal.c
index 203821645509..14d8fdfde152 100644
--- a/linux-user/signal.c
+++ b/linux-user/signal.c
@@ -35,6 +35,9 @@ static struct target_sigaction sigact_table[TARGET_NSIG];
 static void host_signal_handler(int host_signum, siginfo_t *info,
                                 void *puc);
 
+/* Fallback addresses into sigtramp page. */
+abi_ulong default_sigreturn;
+abi_ulong default_rt_sigreturn;
 
 /*
  * System includes define _NSIG as SIGRTMAX + 1,
-- 
2.31.1



  reply	other threads:[~2021-10-04  7:51 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-04  7:43 [PULL 00/26] Linux user for 6.2 patches Laurent Vivier
2021-10-04  7:43 ` Laurent Vivier [this message]
2021-11-05 16:09   ` [PULL 01/26] linux-user: Add infrastructure for a signal trampoline page Peter Maydell
2021-10-04  7:43 ` [PULL 02/26] linux-user/aarch64: Implement setup_sigtramp Laurent Vivier
2021-10-04  7:43 ` [PULL 03/26] linux-user/arm: Drop v1 signal frames Laurent Vivier
2021-10-04  7:43 ` [PULL 04/26] linux-user/arm: Drop "_v2" from symbols in signal.c Laurent Vivier
2021-10-04  7:44 ` [PULL 05/26] linux-user/arm: Implement setup_sigtramp Laurent Vivier
2021-10-04  7:44 ` [PULL 06/26] linux-user/alpha: " Laurent Vivier
2021-10-04  7:44 ` [PULL 07/26] linux-user/cris: " Laurent Vivier
2021-10-04  7:44 ` [PULL 08/26] linux-user/hexagon: " Laurent Vivier
2021-10-04  7:44 ` [PULL 09/26] linux-user/hppa: Document non-use of setup_sigtramp Laurent Vivier
2021-10-04  7:44 ` [PULL 10/26] linux-user/i386: Implement setup_sigtramp Laurent Vivier
2021-10-04  7:44 ` [PULL 11/26] linux-user/x86_64: Raise SIGSEGV if SA_RESTORER not set Laurent Vivier
2021-10-04  7:44 ` [PULL 12/26] linux-user/m68k: Implement setup_sigtramp Laurent Vivier
2021-10-04  7:44 ` [PULL 13/26] linux-user/microblaze: " Laurent Vivier
2021-10-04  7:44 ` [PULL 14/26] linux-user/mips: Tidy install_sigtramp Laurent Vivier
2021-10-04  7:44 ` [PULL 15/26] linux-user/mips: Implement setup_sigtramp Laurent Vivier
2021-10-04  7:44 ` [PULL 16/26] linux-user/nios2: Document non-use of setup_sigtramp Laurent Vivier
2021-10-04  7:44 ` [PULL 17/26] linux-user/openrisc: Implement setup_sigtramp Laurent Vivier
2021-10-04  7:44 ` [PULL 18/26] linux-user/ppc: Simplify encode_trampoline Laurent Vivier
2021-10-04  7:44 ` [PULL 19/26] linux-user/ppc: Implement setup_sigtramp Laurent Vivier
2021-10-04  7:44 ` [PULL 20/26] linux-user/riscv: " Laurent Vivier
2021-10-04  7:44 ` [PULL 21/26] linux-user/s390x: " Laurent Vivier
2021-10-04  7:44 ` [PULL 22/26] linux-user/sh4: " Laurent Vivier
2021-10-04  7:44 ` [PULL 23/26] linux-user/sparc: " Laurent Vivier
2021-10-04  7:44 ` [PULL 24/26] linux-user/xtensa: " Laurent Vivier
2021-10-04  7:44 ` [PULL 25/26] linux-user: Remove default for TARGET_ARCH_HAS_SIGTRAMP_PAGE Laurent Vivier
2021-10-04  7:44 ` [PULL 26/26] tests/tcg/multiarch: Re-enable signals test for most guests Laurent Vivier
2021-10-04 23:27 ` [PULL 00/26] Linux user for 6.2 patches Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211004074421.3141222-2-laurent@vivier.eu \
    --to=laurent@vivier.eu \
    --cc=f4bug@amsat.org \
    --cc=jcmvbkbc@gmail.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).