qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Vivier <laurent@vivier.eu>
To: qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org,
	Richard Henderson <richard.henderson@linaro.org>,
	Laurent Vivier <laurent@vivier.eu>,
	Peter Maydell <peter.maydell@linaro.org>
Subject: [PULL 19/26] linux-user/ppc: Implement setup_sigtramp
Date: Mon,  4 Oct 2021 09:44:14 +0200	[thread overview]
Message-ID: <20211004074421.3141222-20-laurent@vivier.eu> (raw)
In-Reply-To: <20211004074421.3141222-1-laurent@vivier.eu>

From: Richard Henderson <richard.henderson@linaro.org>

Create and record the two signal trampolines.

Cc: qemu-ppc@nongnu.org
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20210929130553.121567-20-richard.henderson@linaro.org>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
 linux-user/ppc/signal.c        | 34 ++++++++++++++++++----------------
 linux-user/ppc/target_signal.h |  2 ++
 2 files changed, 20 insertions(+), 16 deletions(-)

diff --git a/linux-user/ppc/signal.c b/linux-user/ppc/signal.c
index 77f37b9f0131..c37744c8fc55 100644
--- a/linux-user/ppc/signal.c
+++ b/linux-user/ppc/signal.c
@@ -203,9 +203,6 @@ struct target_func_ptr {
 
 #endif
 
-/* We use the mc_pad field for the signal return trampoline.  */
-#define tramp mc_pad
-
 /* See arch/powerpc/kernel/signal.c.  */
 static target_ulong get_sigframe(struct target_sigaction *ka,
                                  CPUPPCState *env,
@@ -436,12 +433,7 @@ void setup_frame(int sig, struct target_sigaction *ka,
     /* Save user regs.  */
     save_user_regs(env, &frame->mctx);
 
-    /* Construct the trampoline code on the stack. */
-    encode_trampoline(TARGET_NR_sigreturn, (uint32_t *)&frame->mctx.tramp);
-
-    /* The kernel checks for the presence of a VDSO here.  We don't
-       emulate a vdso, so use a sigreturn system call.  */
-    env->lr = (target_ulong) h2g(frame->mctx.tramp);
+    env->lr = default_sigreturn;
 
     /* Turn off all fp exceptions.  */
     env->fpscr = 0;
@@ -477,7 +469,6 @@ void setup_rt_frame(int sig, struct target_sigaction *ka,
                     target_sigset_t *set, CPUPPCState *env)
 {
     struct target_rt_sigframe *rt_sf;
-    uint32_t *trampptr = 0;
     struct target_mcontext *mctx = 0;
     target_ulong rt_sf_addr, newsp = 0;
     int i, err = 0;
@@ -507,22 +498,17 @@ void setup_rt_frame(int sig, struct target_sigaction *ka,
 
 #if defined(TARGET_PPC64)
     mctx = &rt_sf->uc.tuc_sigcontext.mcontext;
-    trampptr = &rt_sf->trampoline[0];
 
     sc = &rt_sf->uc.tuc_sigcontext;
     __put_user(h2g(mctx), &sc->regs);
     __put_user(sig, &sc->signal);
 #else
     mctx = &rt_sf->uc.tuc_mcontext;
-    trampptr = (uint32_t *)&rt_sf->uc.tuc_mcontext.tramp;
 #endif
 
     save_user_regs(env, mctx);
-    encode_trampoline(TARGET_NR_rt_sigreturn, trampptr);
 
-    /* The kernel checks for the presence of a VDSO here.  We don't
-       emulate a vdso, so use a sigreturn system call.  */
-    env->lr = (target_ulong) h2g(trampptr);
+    env->lr = default_rt_sigreturn;
 
     /* Turn off all fp exceptions.  */
     env->fpscr = 0;
@@ -720,3 +706,19 @@ abi_long do_swapcontext(CPUArchState *env, abi_ulong uold_ctx,
 
     return 0;
 }
+
+void setup_sigtramp(abi_ulong sigtramp_page)
+{
+    uint32_t *tramp = lock_user(VERIFY_WRITE, sigtramp_page, 2 * 8, 0);
+    assert(tramp != NULL);
+
+#ifdef TARGET_ARCH_HAS_SETUP_FRAME
+    default_sigreturn = sigtramp_page;
+    encode_trampoline(TARGET_NR_sigreturn, tramp + 0);
+#endif
+
+    default_rt_sigreturn = sigtramp_page + 8;
+    encode_trampoline(TARGET_NR_rt_sigreturn, tramp + 2);
+
+    unlock_user(tramp, sigtramp_page, 2 * 8);
+}
diff --git a/linux-user/ppc/target_signal.h b/linux-user/ppc/target_signal.h
index 72fcdd9bfa20..82184ab8f2ef 100644
--- a/linux-user/ppc/target_signal.h
+++ b/linux-user/ppc/target_signal.h
@@ -24,4 +24,6 @@ typedef struct target_sigaltstack {
 #if !defined(TARGET_PPC64)
 #define TARGET_ARCH_HAS_SETUP_FRAME
 #endif
+#define TARGET_ARCH_HAS_SIGTRAMP_PAGE 1
+
 #endif /* PPC_TARGET_SIGNAL_H */
-- 
2.31.1



  parent reply	other threads:[~2021-10-04  7:58 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-04  7:43 [PULL 00/26] Linux user for 6.2 patches Laurent Vivier
2021-10-04  7:43 ` [PULL 01/26] linux-user: Add infrastructure for a signal trampoline page Laurent Vivier
2021-11-05 16:09   ` Peter Maydell
2021-10-04  7:43 ` [PULL 02/26] linux-user/aarch64: Implement setup_sigtramp Laurent Vivier
2021-10-04  7:43 ` [PULL 03/26] linux-user/arm: Drop v1 signal frames Laurent Vivier
2021-10-04  7:43 ` [PULL 04/26] linux-user/arm: Drop "_v2" from symbols in signal.c Laurent Vivier
2021-10-04  7:44 ` [PULL 05/26] linux-user/arm: Implement setup_sigtramp Laurent Vivier
2021-10-04  7:44 ` [PULL 06/26] linux-user/alpha: " Laurent Vivier
2021-10-04  7:44 ` [PULL 07/26] linux-user/cris: " Laurent Vivier
2021-10-04  7:44 ` [PULL 08/26] linux-user/hexagon: " Laurent Vivier
2021-10-04  7:44 ` [PULL 09/26] linux-user/hppa: Document non-use of setup_sigtramp Laurent Vivier
2021-10-04  7:44 ` [PULL 10/26] linux-user/i386: Implement setup_sigtramp Laurent Vivier
2021-10-04  7:44 ` [PULL 11/26] linux-user/x86_64: Raise SIGSEGV if SA_RESTORER not set Laurent Vivier
2021-10-04  7:44 ` [PULL 12/26] linux-user/m68k: Implement setup_sigtramp Laurent Vivier
2021-10-04  7:44 ` [PULL 13/26] linux-user/microblaze: " Laurent Vivier
2021-10-04  7:44 ` [PULL 14/26] linux-user/mips: Tidy install_sigtramp Laurent Vivier
2021-10-04  7:44 ` [PULL 15/26] linux-user/mips: Implement setup_sigtramp Laurent Vivier
2021-10-04  7:44 ` [PULL 16/26] linux-user/nios2: Document non-use of setup_sigtramp Laurent Vivier
2021-10-04  7:44 ` [PULL 17/26] linux-user/openrisc: Implement setup_sigtramp Laurent Vivier
2021-10-04  7:44 ` [PULL 18/26] linux-user/ppc: Simplify encode_trampoline Laurent Vivier
2021-10-04  7:44 ` Laurent Vivier [this message]
2021-10-04  7:44 ` [PULL 20/26] linux-user/riscv: Implement setup_sigtramp Laurent Vivier
2021-10-04  7:44 ` [PULL 21/26] linux-user/s390x: " Laurent Vivier
2021-10-04  7:44 ` [PULL 22/26] linux-user/sh4: " Laurent Vivier
2021-10-04  7:44 ` [PULL 23/26] linux-user/sparc: " Laurent Vivier
2021-10-04  7:44 ` [PULL 24/26] linux-user/xtensa: " Laurent Vivier
2021-10-04  7:44 ` [PULL 25/26] linux-user: Remove default for TARGET_ARCH_HAS_SIGTRAMP_PAGE Laurent Vivier
2021-10-04  7:44 ` [PULL 26/26] tests/tcg/multiarch: Re-enable signals test for most guests Laurent Vivier
2021-10-04 23:27 ` [PULL 00/26] Linux user for 6.2 patches Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211004074421.3141222-20-laurent@vivier.eu \
    --to=laurent@vivier.eu \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).