From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
qemu-arm@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>,
f4bug@amsat.org, "Andrew Baumann" <Andrew.Baumann@microsoft.com>
Subject: [PATCH v1 1/7] hw/misc/bcm2835_property: Add FIXME comment for uninitialized memory
Date: Mon, 4 Oct 2021 14:47:35 +0100 [thread overview]
Message-ID: <20211004134742.2044280-2-alex.bennee@linaro.org> (raw)
In-Reply-To: <20211004134742.2044280-1-alex.bennee@linaro.org>
From: Philippe Mathieu-Daudé <f4bug@amsat.org>
We are returning unintialized memory, this is probably unsafe.
Reported-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
hw/misc/bcm2835_property.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/misc/bcm2835_property.c b/hw/misc/bcm2835_property.c
index 73941bdae9..791c7554ec 100644
--- a/hw/misc/bcm2835_property.c
+++ b/hw/misc/bcm2835_property.c
@@ -61,6 +61,7 @@ static void bcm2835_property_mbox_push(BCM2835PropertyState *s, uint32_t value)
qemu_log_mask(LOG_UNIMP,
"bcm2835_property: 0x%08x get board model NYI\n",
tag);
+ /* FIXME returning uninitialized memory */
resplen = 4;
break;
case 0x00010002: /* Get board revision */
@@ -75,6 +76,7 @@ static void bcm2835_property_mbox_push(BCM2835PropertyState *s, uint32_t value)
qemu_log_mask(LOG_UNIMP,
"bcm2835_property: 0x%08x get board serial NYI\n",
tag);
+ /* FIXME returning uninitialized memory */
resplen = 8;
break;
case 0x00010005: /* Get ARM memory */
--
2.30.2
next prev parent reply other threads:[~2021-10-04 13:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-04 13:47 [PATCH v1 0/7] enabling RasperryPi 4 emulation - WIP state Alex Bennée
2021-10-04 13:47 ` Alex Bennée [this message]
2021-10-04 13:47 ` [PATCH v1 2/7] hw/misc/bcm2835_property: Handle the 'domain state' property Alex Bennée
2021-10-04 13:47 ` [PATCH v1 3/7] hw/arm: fix the position of vcram for raspi Alex Bennée
2021-10-04 13:47 ` [PATCH v1 4/7] hw/arm/bcm2835_peripherals: Map various BCM2711 blocks Alex Bennée
2021-10-04 13:47 ` [PATCH v1 5/7] hw/arm/bcm2836: Add the BCM2711 which uses a GICv2 Alex Bennée
2021-10-04 15:43 ` Alex Bennée
2021-10-04 13:47 ` [PATCH v1 6/7] hw/arm/bcm2838: Map the PCIe memory space Alex Bennée
2021-10-04 13:47 ` [PATCH v1 7/7] hw/arm/raspi: Add the Raspberry Pi 4B board Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211004134742.2044280-2-alex.bennee@linaro.org \
--to=alex.bennee@linaro.org \
--cc=Andrew.Baumann@microsoft.com \
--cc=f4bug@amsat.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).