From: Denis Plotnikov <den-plotnikov@yandex-team.ru>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, mst@redhat.com, yc-core@yandex-team.ru,
qemu-block@nongnu.org, raphael.norwitz@nutanix.com
Subject: [PATCH v0 2/2] vhost-user-blk-pci: add new pci device type to support vhost-user-virtio-blk
Date: Mon, 4 Oct 2021 18:07:31 +0300 [thread overview]
Message-ID: <20211004150731.191270-3-den-plotnikov@yandex-team.ru> (raw)
In-Reply-To: <20211004150731.191270-1-den-plotnikov@yandex-team.ru>
To allow the recently added vhost-user-virtio-blk work via virtio-pci.
This patch refactors the vhost-user-blk-pci object model to reuse
the existing code.
Signed-off-by: Denis Plotnikov <den-plotnikov@yandex-team.ru>
---
hw/virtio/vhost-user-blk-pci.c | 43 +++++++++++++++++++++++++++++++---
1 file changed, 40 insertions(+), 3 deletions(-)
diff --git a/hw/virtio/vhost-user-blk-pci.c b/hw/virtio/vhost-user-blk-pci.c
index 33b404d8a225..2f68296af22f 100644
--- a/hw/virtio/vhost-user-blk-pci.c
+++ b/hw/virtio/vhost-user-blk-pci.c
@@ -34,10 +34,18 @@ typedef struct VHostUserBlkPCI VHostUserBlkPCI;
/*
* vhost-user-blk-pci: This extends VirtioPCIProxy.
*/
+#define TYPE_VHOST_USER_BLK_PCI_ABSTRACT "vhost-user-blk-pci-abstract-base"
+#define VHOST_USER_BLK_PCI_ABSTRACT(obj) \
+ OBJECT_CHECK(VHostUserBlkPCI, (obj), TYPE_VHOST_USER_BLK_PCI_ABSTRACT)
+
#define TYPE_VHOST_USER_BLK_PCI "vhost-user-blk-pci-base"
DECLARE_INSTANCE_CHECKER(VHostUserBlkPCI, VHOST_USER_BLK_PCI,
TYPE_VHOST_USER_BLK_PCI)
+#define TYPE_VHOST_USER_VIRTIO_BLK_PCI "vhost-user-virtio-blk-pci-base"
+#define VHOST_USER_VIRTIO_BLK_PCI(obj) \
+ OBJECT_CHECK(VHostUserBlkPCI, (obj), TYPE_VHOST_USER_VIRTIO_BLK_PCI)
+
struct VHostUserBlkPCI {
VirtIOPCIProxy parent_obj;
VHostUserBlk vdev;
@@ -52,7 +60,7 @@ static Property vhost_user_blk_pci_properties[] = {
static void vhost_user_blk_pci_realize(VirtIOPCIProxy *vpci_dev, Error **errp)
{
- VHostUserBlkPCI *dev = VHOST_USER_BLK_PCI(vpci_dev);
+ VHostUserBlkPCI *dev = VHOST_USER_BLK_PCI_ABSTRACT(vpci_dev);
DeviceState *vdev = DEVICE(&dev->vdev);
if (dev->vdev.num_queues == VHOST_USER_BLK_AUTO_NUM_QUEUES) {
@@ -66,7 +74,8 @@ static void vhost_user_blk_pci_realize(VirtIOPCIProxy *vpci_dev, Error **errp)
qdev_realize(vdev, BUS(&vpci_dev->bus), errp);
}
-static void vhost_user_blk_pci_class_init(ObjectClass *klass, void *data)
+static void vhost_user_blk_pci_abstract_class_init(ObjectClass *klass,
+ void *data)
{
DeviceClass *dc = DEVICE_CLASS(klass);
VirtioPCIClass *k = VIRTIO_PCI_CLASS(klass);
@@ -81,6 +90,12 @@ static void vhost_user_blk_pci_class_init(ObjectClass *klass, void *data)
pcidev_k->class_id = PCI_CLASS_STORAGE_SCSI;
}
+static const VirtioPCIDeviceTypeInfo vhost_user_blk_pci_abstract_info = {
+ .base_name = TYPE_VHOST_USER_BLK_PCI_ABSTRACT,
+ .instance_size = sizeof(VHostUserBlkPCI),
+ .class_init = vhost_user_blk_pci_abstract_class_init,
+};
+
static void vhost_user_blk_pci_instance_init(Object *obj)
{
VHostUserBlkPCI *dev = VHOST_USER_BLK_PCI(obj);
@@ -92,18 +107,40 @@ static void vhost_user_blk_pci_instance_init(Object *obj)
}
static const VirtioPCIDeviceTypeInfo vhost_user_blk_pci_info = {
+ .parent = TYPE_VHOST_USER_BLK_PCI_ABSTRACT,
.base_name = TYPE_VHOST_USER_BLK_PCI,
.generic_name = "vhost-user-blk-pci",
.transitional_name = "vhost-user-blk-pci-transitional",
.non_transitional_name = "vhost-user-blk-pci-non-transitional",
.instance_size = sizeof(VHostUserBlkPCI),
.instance_init = vhost_user_blk_pci_instance_init,
- .class_init = vhost_user_blk_pci_class_init,
+};
+
+static void vhost_user_virtio_blk_pci_instance_init(Object *obj)
+{
+ VHostUserBlkPCI *dev = VHOST_USER_VIRTIO_BLK_PCI(obj);
+
+ virtio_instance_init_common(obj, &dev->vdev, sizeof(dev->vdev),
+ TYPE_VHOST_USER_VIRTIO_BLK);
+ object_property_add_alias(obj, "bootindex", OBJECT(&dev->vdev),
+ "bootindex");
+}
+
+static const VirtioPCIDeviceTypeInfo vhost_user_virtio_blk_pci_info = {
+ .parent = TYPE_VHOST_USER_BLK_PCI_ABSTRACT,
+ .base_name = TYPE_VHOST_USER_VIRTIO_BLK_PCI,
+ .generic_name = "vhost-user-virtio-blk-pci",
+ .transitional_name = "vhost-user-virtio-blk-pci-transitional",
+ .non_transitional_name = "vhost-user-virtio-blk-pci-non-transitional",
+ .instance_size = sizeof(VHostUserBlkPCI),
+ .instance_init = vhost_user_virtio_blk_pci_instance_init,
};
static void vhost_user_blk_pci_register(void)
{
+ virtio_pci_types_register(&vhost_user_blk_pci_abstract_info);
virtio_pci_types_register(&vhost_user_blk_pci_info);
+ virtio_pci_types_register(&vhost_user_virtio_blk_pci_info);
}
type_init(vhost_user_blk_pci_register)
--
2.25.1
next prev parent reply other threads:[~2021-10-04 15:11 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-04 15:07 [PATCH v0 0/2] virtio-blk and vhost-user-blk cross-device migration Denis Plotnikov
2021-10-04 15:07 ` [PATCH v0 1/2] vhost-user-blk: add a new vhost-user-virtio-blk type Denis Plotnikov
2021-10-04 15:16 ` Michael S. Tsirkin
2021-10-04 15:07 ` Denis Plotnikov [this message]
2021-10-04 15:11 ` [PATCH v0 0/2] virtio-blk and vhost-user-blk cross-device migration Michael S. Tsirkin
2021-10-04 23:18 ` Roman Kagan
2021-10-05 6:51 ` Michael S. Tsirkin
2021-10-05 14:01 ` Dr. David Alan Gilbert
2021-10-05 16:10 ` Eduardo Habkost
2021-10-05 22:06 ` Michael S. Tsirkin
2021-10-06 8:09 ` Dr. David Alan Gilbert
2021-10-06 8:17 ` Michael S. Tsirkin
2021-10-06 8:28 ` Dr. David Alan Gilbert
2021-10-06 8:36 ` Michael S. Tsirkin
2021-10-06 8:43 ` Dr. David Alan Gilbert
2021-10-06 12:18 ` Michael S. Tsirkin
2021-10-06 13:29 ` Dr. David Alan Gilbert
2021-10-06 13:39 ` Michael S. Tsirkin
2021-10-06 14:27 ` Dr. David Alan Gilbert
2021-10-06 14:37 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211004150731.191270-3-den-plotnikov@yandex-team.ru \
--to=den-plotnikov@yandex-team.ru \
--cc=kwolf@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=raphael.norwitz@nutanix.com \
--cc=yc-core@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).