From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BBA0C433EF for ; Tue, 5 Oct 2021 08:57:36 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CAA0B61251 for ; Tue, 5 Oct 2021 08:57:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CAA0B61251 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:44634 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mXgGU-0004mn-UY for qemu-devel@archiver.kernel.org; Tue, 05 Oct 2021 04:57:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57756) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mXgEb-0002MC-FZ; Tue, 05 Oct 2021 04:55:37 -0400 Received: from mail-lf1-x131.google.com ([2a00:1450:4864:20::131]:42555) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mXgEX-0002Xl-Eo; Tue, 05 Oct 2021 04:55:37 -0400 Received: by mail-lf1-x131.google.com with SMTP id x27so82579335lfa.9; Tue, 05 Oct 2021 01:55:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=DXt2p+DKTZd4NFoi7cijIRHkQh+jDOXKlsa+HD0cOH4=; b=YvBX3gL4TPRLxDibgQfQRLDV1JD9x6DSu39nGMPFR0M58IqCa9/eEVRmTg16aeKMHL iqo1Ox8J8cAc0lqv/GYIe82yBtRL/AzAPCl4T8fHzbSsHXRgKGN4ROXMmdnEDW+CdMi7 F/wuFziZdriGDhx+k88ZB89kbmHT//erH3PnHgjYNJ1dHu1wypbwptBX0D6b0Q1cLHSy UckXjUkdMgaD1NJHVlfKGv9OCXUBVHBjGcJ0lNSkv/gVzq0e7GJ8kv7cuvXnzNYDZfgX UURBKzcORhWLZ2m1bA0vExMiU1nJgXSsSfJrVmLRp2RCWT+ChoGL+Q/uySdu6ACJEIWF mqpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=DXt2p+DKTZd4NFoi7cijIRHkQh+jDOXKlsa+HD0cOH4=; b=Gnavn4JhwWrh6Bza92mo4a7aONu1d9z5dUlRpYyX3IOzGgCwJHs2b3W8SJmAvLSGWD V4OQf4j7kaKIKC4vunttbS9uF84zajhZXANm1YMWcOH4DEoorDZMtmMbydARlF9mmS3m JGHuKRdw2soMIpTOwBQVCgXjV97Cv64Vpv0bjRM3fHRMTPn8QFQG6L0FoPT+fDD/nxVI RYx/LtvrW+R6Msa43398nJfbUTiWHHQJYZ2xAf6mXslnvqRy5e++3p+De036s9NcQI9S beg15FScMfia7ZLF00gX7/Uee3np2IQgLUZiML2xtsalyEJHnbDI+FAHr05cg14IuuWG ak4Q== X-Gm-Message-State: AOAM533FLQJnsTWvAeFC9cpzvnhh9iBw6VxTIMt209MMu6VeVRh9Id8z j/XV4PcYM/+BYc16NW7qS6s= X-Google-Smtp-Source: ABdhPJww9l9I9Z/TO52AUcQQ7lzDQNCYCcMb45k/UUjbf5ACrlP/OL550tUCrQy/ZgZGlVzTWr314g== X-Received: by 2002:a05:651c:50f:: with SMTP id o15mr20063941ljp.495.1633424130560; Tue, 05 Oct 2021 01:55:30 -0700 (PDT) Received: from fralle-msi (31-208-27-151.cust.bredband2.com. [31.208.27.151]) by smtp.gmail.com with ESMTPSA id 8sm1895741ljr.10.2021.10.05.01.55.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Oct 2021 01:55:30 -0700 (PDT) Date: Tue, 5 Oct 2021 10:55:28 +0200 From: Francisco Iglesias To: =?iso-8859-1?Q?C=E9dric?= Le Goater Subject: Re: [PATCH 2/4] aspeed/smc: Dump address offset in trace events Message-ID: <20211005085527.GA23846@fralle-msi> References: <20211004154635.394258-1-clg@kaod.org> <20211004154635.394258-3-clg@kaod.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20211004154635.394258-3-clg@kaod.org> User-Agent: Mutt/1.10.1 (2018-07-13) Received-SPF: pass client-ip=2a00:1450:4864:20::131; envelope-from=frasse.iglesias@gmail.com; helo=mail-lf1-x131.google.com X-Spam_score_int: -1020 X-Spam_score: -102.1 X-Spam_bar: --------------------------------------------------- X-Spam_report: (-102.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, USER_IN_WELCOMELIST=-0.01, USER_IN_WHITELIST=-100 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Jeffery , Peter Maydell , qemu-arm@nongnu.org, Joel Stanley , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On [2021 Oct 04] Mon 17:46:33, Cédric Le Goater wrote: > The register index is currently printed and this is confusing. > > Signed-off-by: Cédric Le Goater Reviewed-by: Francisco Iglesias > --- > hw/ssi/aspeed_smc.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/hw/ssi/aspeed_smc.c b/hw/ssi/aspeed_smc.c > index 7129341c129e..8a988c167604 100644 > --- a/hw/ssi/aspeed_smc.c > +++ b/hw/ssi/aspeed_smc.c > @@ -728,7 +728,7 @@ static uint64_t aspeed_smc_read(void *opaque, hwaddr addr, unsigned int size) > addr < R_SEG_ADDR0 + asc->max_peripherals) || > (addr >= s->r_ctrl0 && addr < s->r_ctrl0 + asc->max_peripherals)) { > > - trace_aspeed_smc_read(addr, size, s->regs[addr]); > + trace_aspeed_smc_read(addr << 2, size, s->regs[addr]); > > return s->regs[addr]; > } else { > @@ -1029,10 +1029,10 @@ static void aspeed_smc_write(void *opaque, hwaddr addr, uint64_t data, > AspeedSMCClass *asc = ASPEED_SMC_GET_CLASS(s); > uint32_t value = data; > > - addr >>= 2; > - > trace_aspeed_smc_write(addr, size, data); > > + addr >>= 2; > + > if (addr == s->r_conf || > (addr >= s->r_timings && > addr < s->r_timings + asc->nregs_timings) || > -- > 2.31.1 > >