qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Emanuele Giuseppe Esposito <eesposit@redhat.com>
To: qemu-block@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>, "Fam Zheng" <fam@euphon.net>,
	"Vladimir Sementsov-Ogievskiy" <vsementsov@virtuozzo.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	"Juan Quintela" <quintela@redhat.com>,
	qemu-devel@nongnu.org, "John Snow" <jsnow@redhat.com>,
	"Emanuele Giuseppe Esposito" <eesposit@redhat.com>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	"Hanna Reitz" <hreitz@redhat.com>,
	"Stefan Hajnoczi" <stefanha@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Eric Blake" <eblake@redhat.com>
Subject: [RFC PATCH v2 22/25] block_int-common.h: assertions in the callers of BdrvChildClass function pointers
Date: Tue,  5 Oct 2021 10:32:12 -0400	[thread overview]
Message-ID: <20211005143215.29500-23-eesposit@redhat.com> (raw)
In-Reply-To: <20211005143215.29500-1-eesposit@redhat.com>

Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
---
 block.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/block.c b/block.c
index a921066d4d..e4b3d40094 100644
--- a/block.c
+++ b/block.c
@@ -1457,6 +1457,7 @@ const BdrvChildClass child_of_bds = {
 
 AioContext *bdrv_child_get_parent_aio_context(BdrvChild *c)
 {
+    g_assert(qemu_in_main_thread());
     return c->klass->get_parent_aio_context(c);
 }
 
@@ -2062,6 +2063,7 @@ bool bdrv_is_writable(BlockDriverState *bs)
 
 static char *bdrv_child_user_desc(BdrvChild *c)
 {
+    g_assert(qemu_in_main_thread());
     return c->klass->get_parent_desc(c);
 }
 
@@ -2695,6 +2697,7 @@ static void bdrv_replace_child_noperm(BdrvChild *child,
     int drain_saldo;
 
     assert(!child->frozen);
+    g_assert(qemu_in_main_thread());
 
     if (old_bs && new_bs) {
         assert(bdrv_get_aio_context(old_bs) == bdrv_get_aio_context(new_bs));
@@ -2783,6 +2786,8 @@ static void bdrv_attach_child_common_abort(void *opaque)
     BdrvChild *child = *s->child;
     BlockDriverState *bs = child->bs;
 
+    g_assert(qemu_in_main_thread());
+
     bdrv_replace_child_noperm(child, NULL);
 
     if (bdrv_get_aio_context(bs) != s->old_child_ctx) {
@@ -3141,6 +3146,7 @@ void bdrv_unref_child(BlockDriverState *parent, BdrvChild *child)
 static void bdrv_parent_cb_change_media(BlockDriverState *bs, bool load)
 {
     BdrvChild *c;
+    g_assert(qemu_in_main_thread());
     QLIST_FOREACH(c, &bs->parents, next_parent) {
         if (c->klass->change_media) {
             c->klass->change_media(c, load);
@@ -3632,6 +3638,7 @@ static BlockDriverState *bdrv_open_inherit(const char *filename,
 
     assert(!child_class || !flags);
     assert(!child_class == !parent);
+    g_assert(qemu_in_main_thread());
 
     if (reference) {
         bool options_non_empty = options ? qdict_size(options) : false;
@@ -4018,6 +4025,7 @@ static BlockReopenQueue *bdrv_reopen_queue_child(BlockReopenQueue *bs_queue,
      * important to avoid graph changes between the recursive queuing here and
      * bdrv_reopen_multiple(). */
     assert(bs->quiesce_counter > 0);
+    g_assert(qemu_in_main_thread());
 
     if (bs_queue == NULL) {
         bs_queue = g_new0(BlockReopenQueue, 1);
@@ -7000,6 +7008,7 @@ void bdrv_set_aio_context_ignore(BlockDriverState *bs,
     BdrvChild *child, *parent;
 
     g_assert(qemu_get_current_aio_context() == qemu_get_aio_context());
+    g_assert(qemu_in_main_thread());
 
     if (old_context == new_context) {
         return;
@@ -7076,6 +7085,7 @@ static bool bdrv_parent_can_set_aio_context(BdrvChild *c, AioContext *ctx,
         return true;
     }
     *ignore = g_slist_prepend(*ignore, c);
+    g_assert(qemu_in_main_thread());
 
     /*
      * A BdrvChildClass that doesn't handle AioContext changes cannot
-- 
2.27.0



  parent reply	other threads:[~2021-10-05 14:57 UTC|newest]

Thread overview: 74+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-05 14:31 [RFC PATCH v2 00/25] block layer: split block APIs in global state and I/O Emanuele Giuseppe Esposito
2021-10-05 14:31 ` [RFC PATCH v2 01/25] main-loop.h: introduce qemu_in_main_thread() Emanuele Giuseppe Esposito
2021-10-07  9:05   ` Stefan Hajnoczi
2021-10-05 14:31 ` [RFC PATCH v2 02/25] include/sysemu/block-backend: split header into I/O and global state (GS) API Emanuele Giuseppe Esposito
2021-10-07  9:13   ` Stefan Hajnoczi
2021-10-05 14:31 ` [RFC PATCH v2 03/25] block/block-backend.c: assertions for block-backend Emanuele Giuseppe Esposito
2021-10-05 16:29   ` Eric Blake
2021-10-06  9:36     ` Emanuele Giuseppe Esposito
2021-10-07 10:48   ` Stefan Hajnoczi
2021-10-05 14:31 ` [RFC PATCH v2 04/25] include/block/block: split header into I/O and global state API Emanuele Giuseppe Esposito
2021-10-07  9:33   ` Stefan Hajnoczi
2021-10-07 10:54     ` Emanuele Giuseppe Esposito
2021-10-07 11:51       ` Paolo Bonzini
2021-10-07 13:18         ` Eric Blake
2021-10-07 11:43   ` Daniel P. Berrangé
2021-10-07 13:01     ` Stefan Hajnoczi
2021-10-08  7:26       ` Emanuele Giuseppe Esposito
2021-10-05 14:31 ` [RFC PATCH v2 05/25] assertions for block " Emanuele Giuseppe Esposito
2021-10-07 10:44   ` Stefan Hajnoczi
2021-10-05 14:31 ` [RFC PATCH v2 06/25] include/block/block_int: split header into I/O and " Emanuele Giuseppe Esposito
2021-10-07 10:52   ` Stefan Hajnoczi
2021-10-07 11:30     ` Emanuele Giuseppe Esposito
2021-10-07 13:38       ` Stefan Hajnoczi
2021-10-05 14:31 ` [RFC PATCH v2 07/25] assertions for block_int " Emanuele Giuseppe Esposito
2021-10-07 14:19   ` Stefan Hajnoczi
2021-10-05 14:31 ` [RFC PATCH v2 08/25] block: introduce assert_bdrv_graph_writable Emanuele Giuseppe Esposito
2021-10-07 12:01   ` Paolo Bonzini
2021-10-07 12:02   ` Paolo Bonzini
2021-10-07 13:47     ` Emanuele Giuseppe Esposito
2021-10-07 14:18       ` Stefan Hajnoczi
2021-10-05 14:31 ` [RFC PATCH v2 09/25] include/block/blockjob_int.h: split header into I/O and GS API Emanuele Giuseppe Esposito
2021-10-07 14:21   ` Stefan Hajnoczi
2021-10-05 14:32 ` [RFC PATCH v2 10/25] assertions for blockjob_int.h Emanuele Giuseppe Esposito
2021-10-07 14:21   ` Stefan Hajnoczi
2021-10-05 14:32 ` [RFC PATCH v2 11/25] include/block/blockjob.h: global state API Emanuele Giuseppe Esposito
2021-10-07 14:23   ` Stefan Hajnoczi
2021-10-08  7:20     ` Emanuele Giuseppe Esposito
2021-10-11 11:10       ` Stefan Hajnoczi
2021-10-05 14:32 ` [RFC PATCH v2 12/25] assertions for blockob.h " Emanuele Giuseppe Esposito
2021-10-07 14:25   ` Stefan Hajnoczi
2021-10-05 14:32 ` [RFC PATCH v2 13/25] include/systemu/blockdev.h: " Emanuele Giuseppe Esposito
2021-10-07 12:00   ` Paolo Bonzini
2021-10-07 14:28   ` Stefan Hajnoczi
2021-10-05 14:32 ` [RFC PATCH v2 14/25] assertions for blockdev.h " Emanuele Giuseppe Esposito
2021-10-07 12:04   ` Paolo Bonzini
2021-10-07 14:29   ` Stefan Hajnoczi
2021-10-05 14:32 ` [RFC PATCH v2 15/25] include/block/snapshot: global state API + assertions Emanuele Giuseppe Esposito
2021-10-07 12:06   ` Paolo Bonzini
2021-10-07 14:31   ` Stefan Hajnoczi
2021-10-05 14:32 ` [RFC PATCH v2 16/25] block/backup-top.h: " Emanuele Giuseppe Esposito
2021-10-07 12:08   ` Paolo Bonzini
2021-10-07 14:32   ` Stefan Hajnoczi
2021-10-05 14:32 ` [RFC PATCH v2 17/25] include/block/transactions: " Emanuele Giuseppe Esposito
2021-10-07 14:47   ` Stefan Hajnoczi
2021-10-08  7:18     ` Emanuele Giuseppe Esposito
2021-10-05 14:32 ` [RFC PATCH v2 18/25] block/coroutines: I/O API Emanuele Giuseppe Esposito
2021-10-07 11:52   ` Paolo Bonzini
2021-10-07 14:47   ` Stefan Hajnoczi
2021-10-05 14:32 ` [RFC PATCH v2 19/25] block_int-common.h: split function pointers in BlockDriver Emanuele Giuseppe Esposito
2021-10-07 14:49   ` Stefan Hajnoczi
2021-10-05 14:32 ` [RFC PATCH v2 20/25] block_int-common.h: assertion in the callers of BlockDriver function pointers Emanuele Giuseppe Esposito
2021-10-07 14:50   ` Stefan Hajnoczi
2021-10-05 14:32 ` [RFC PATCH v2 21/25] block_int-common.h: split function pointers in BdrvChildClass Emanuele Giuseppe Esposito
2021-10-07 14:51   ` Stefan Hajnoczi
2021-10-05 14:32 ` Emanuele Giuseppe Esposito [this message]
2021-10-07 14:51   ` [RFC PATCH v2 22/25] block_int-common.h: assertions in the callers of BdrvChildClass function pointers Stefan Hajnoczi
2021-10-05 14:32 ` [RFC PATCH v2 23/25] block-backend-common.h: split function pointers in BlockDevOps Emanuele Giuseppe Esposito
2021-10-07 14:52   ` Stefan Hajnoczi
2021-10-05 14:32 ` [RFC PATCH v2 24/25] job.h: split function pointers in JobDriver Emanuele Giuseppe Esposito
2021-10-07 14:54   ` Stefan Hajnoczi
2021-10-08 10:48     ` Emanuele Giuseppe Esposito
2021-10-11 11:12       ` Stefan Hajnoczi
2021-10-05 14:32 ` [RFC PATCH v2 25/25] job.h: assertions in the callers of JobDriver funcion pointers Emanuele Giuseppe Esposito
2021-10-07 14:54   ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211005143215.29500-23-eesposit@redhat.com \
    --to=eesposit@redhat.com \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=eblake@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=fam@euphon.net \
    --cc=hreitz@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=richard.henderson@linaro.org \
    --cc=stefanha@redhat.com \
    --cc=vsementsov@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).