From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Brijesh Singh" <brijesh.singh@amd.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>,
"Sergio Lopez" <slp@redhat.com>,
"James Bottomley" <jejb@linux.ibm.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
"Dov Murik" <dovmurik@linux.ibm.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: [PATCH v4 00/23] target/i386/sev: Housekeeping SEV + measured Linux SEV guest
Date: Thu, 7 Oct 2021 18:16:53 +0200 [thread overview]
Message-ID: <20211007161716.453984-1-philmd@redhat.com> (raw)
Missing review:
0005-target-i386-sev-Prefix-QMP-errors-with-SEV.patch
0012-target-i386-sev-Use-g_autofree-in-sev_launch_get_mea.patch
0014-target-i386-sev-Rename-sev_i386.h-sev.h.patch
0016-target-i386-sev-Remove-stubs-by-using-code-elision.patch
0023-MAINTAINERS-Cover-SEV-related-files-with-X86-KVM-sec.patch
Hi,
While testing James & Dov patch:
https://www.mail-archive.com/qemu-devel@nongnu.org/msg810571.html
I wasted some time trying to figure out how OVMF was supposed to
behave until realizing the binary I was using was built without SEV
support... Then wrote this series to help other developers to not
hit the same problem.
Since v3:
- Rebased ('Measured Linux SEV guest' from Dov [1] merged)
- Addressed Paolo & David review comments
Since v2:
- Rebased on top of SGX
- Addressed review comments from Markus / David
- Included/rebased 'Measured Linux SEV guest' from Dov [1]
- Added orphean MAINTAINERS section
[1] https://lore.kernel.org/qemu-devel/20210825073538.959525-1-dovmurik@linux.ibm.com/
Supersedes: <20210616204328.2611406-1-philmd@redhat.com>
Dr. David Alan Gilbert (1):
target/i386/sev: sev_get_attestation_report use g_autofree
Philippe Mathieu-Daudé (22):
qapi/misc-target: Wrap long 'SEV Attestation Report' long lines
qapi/misc-target: Group SEV QAPI definitions
target/i386/kvm: Introduce i386_softmmu_kvm Meson source set
target/i386/kvm: Restrict SEV stubs to x86 architecture
target/i386/sev: Prefix QMP errors with 'SEV'
target/i386/monitor: Return QMP error when SEV is not enabled for
guest
target/i386/cpu: Add missing 'qapi/error.h' header
target/i386/sev_i386.h: Remove unused headers
target/i386/sev: Remove sev_get_me_mask()
target/i386/sev: Mark unreachable code with g_assert_not_reached()
target/i386/sev: Use g_autofree in sev_launch_get_measure()
target/i386/sev: Restrict SEV to system emulation
target/i386/sev: Rename sev_i386.h -> sev.h
target/i386/sev: Declare system-specific functions in 'sev.h'
target/i386/sev: Remove stubs by using code elision
target/i386/sev: Move qmp_query_sev_attestation_report() to sev.c
target/i386/sev: Move qmp_sev_inject_launch_secret() to sev.c
target/i386/sev: Move qmp_query_sev_capabilities() to sev.c
target/i386/sev: Move qmp_query_sev_launch_measure() to sev.c
target/i386/sev: Move qmp_query_sev() & hmp_info_sev() to sev.c
monitor: Reduce hmp_info_sev() declaration
MAINTAINERS: Cover SEV-related files with X86/KVM section
qapi/misc-target.json | 77 ++++++------
include/monitor/hmp-target.h | 1 +
include/monitor/hmp.h | 1 -
include/sysemu/sev.h | 28 -----
target/i386/{sev_i386.h => sev.h} | 35 ++++--
hw/i386/pc_sysfw.c | 2 +-
hw/i386/x86.c | 2 +-
target/i386/cpu.c | 16 +--
target/i386/kvm/kvm.c | 3 +-
{accel => target/i386}/kvm/sev-stub.c | 2 +-
target/i386/monitor.c | 92 +--------------
target/i386/sev-stub.c | 88 --------------
target/i386/sev-sysemu-stub.c | 70 +++++++++++
target/i386/sev.c | 164 +++++++++++++++++++-------
MAINTAINERS | 2 +
accel/kvm/meson.build | 1 -
target/i386/kvm/meson.build | 8 +-
target/i386/meson.build | 4 +-
18 files changed, 279 insertions(+), 317 deletions(-)
delete mode 100644 include/sysemu/sev.h
rename target/i386/{sev_i386.h => sev.h} (62%)
rename {accel => target/i386}/kvm/sev-stub.c (94%)
delete mode 100644 target/i386/sev-stub.c
create mode 100644 target/i386/sev-sysemu-stub.c
--
2.31.1
next reply other threads:[~2021-10-07 16:19 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-07 16:16 Philippe Mathieu-Daudé [this message]
2021-10-07 16:16 ` [PATCH v4 01/23] qapi/misc-target: Wrap long 'SEV Attestation Report' long lines Philippe Mathieu-Daudé
2021-10-07 16:16 ` [PATCH v4 02/23] qapi/misc-target: Group SEV QAPI definitions Philippe Mathieu-Daudé
2021-10-07 16:16 ` [PATCH v4 03/23] target/i386/kvm: Introduce i386_softmmu_kvm Meson source set Philippe Mathieu-Daudé
2021-10-07 16:16 ` [PATCH v4 04/23] target/i386/kvm: Restrict SEV stubs to x86 architecture Philippe Mathieu-Daudé
2021-10-07 16:16 ` [PATCH v4 05/23] target/i386/sev: Prefix QMP errors with 'SEV' Philippe Mathieu-Daudé
2021-10-07 16:23 ` Dr. David Alan Gilbert
2021-10-07 16:16 ` [PATCH v4 06/23] target/i386/monitor: Return QMP error when SEV is not enabled for guest Philippe Mathieu-Daudé
2021-10-07 16:17 ` [PATCH v4 07/23] target/i386/cpu: Add missing 'qapi/error.h' header Philippe Mathieu-Daudé
2021-10-07 16:17 ` [PATCH v4 08/23] target/i386/sev_i386.h: Remove unused headers Philippe Mathieu-Daudé
2021-10-07 16:17 ` [PATCH v4 09/23] target/i386/sev: Remove sev_get_me_mask() Philippe Mathieu-Daudé
2021-10-07 16:17 ` [PATCH v4 10/23] target/i386/sev: Mark unreachable code with g_assert_not_reached() Philippe Mathieu-Daudé
2021-10-07 16:17 ` [PATCH v4 11/23] target/i386/sev: sev_get_attestation_report use g_autofree Philippe Mathieu-Daudé
2021-10-07 16:17 ` [PATCH v4 12/23] target/i386/sev: Use g_autofree in sev_launch_get_measure() Philippe Mathieu-Daudé
2021-10-07 16:28 ` Dov Murik
2021-10-12 6:15 ` Dov Murik
2021-10-07 16:17 ` [PATCH v4 13/23] target/i386/sev: Restrict SEV to system emulation Philippe Mathieu-Daudé
2021-10-07 16:17 ` [PATCH v4 14/23] target/i386/sev: Rename sev_i386.h -> sev.h Philippe Mathieu-Daudé
2021-10-07 16:32 ` Dr. David Alan Gilbert
2021-10-07 16:17 ` [PATCH v4 15/23] target/i386/sev: Declare system-specific functions in 'sev.h' Philippe Mathieu-Daudé
2021-10-07 16:17 ` [PATCH v4 16/23] target/i386/sev: Remove stubs by using code elision Philippe Mathieu-Daudé
2021-10-07 17:07 ` Dr. David Alan Gilbert
2021-10-07 17:18 ` Philippe Mathieu-Daudé
2021-10-07 17:22 ` Dr. David Alan Gilbert
2021-10-08 11:46 ` Paolo Bonzini
2021-10-07 17:27 ` Daniel P. Berrangé
2021-10-07 19:51 ` Eric Blake
2021-10-07 16:17 ` [PATCH v4 17/23] target/i386/sev: Move qmp_query_sev_attestation_report() to sev.c Philippe Mathieu-Daudé
2021-10-07 16:17 ` [PATCH v4 18/23] target/i386/sev: Move qmp_sev_inject_launch_secret() " Philippe Mathieu-Daudé
2021-10-07 16:17 ` [PATCH v4 19/23] target/i386/sev: Move qmp_query_sev_capabilities() " Philippe Mathieu-Daudé
2021-10-07 16:17 ` [PATCH v4 20/23] target/i386/sev: Move qmp_query_sev_launch_measure() " Philippe Mathieu-Daudé
2021-10-07 16:17 ` [PATCH v4 21/23] target/i386/sev: Move qmp_query_sev() & hmp_info_sev() " Philippe Mathieu-Daudé
2021-10-07 16:17 ` [PATCH v4 22/23] monitor: Reduce hmp_info_sev() declaration Philippe Mathieu-Daudé
2021-10-07 16:17 ` [PATCH v4 23/23] MAINTAINERS: Cover SEV-related files with X86/KVM section Philippe Mathieu-Daudé
2021-10-07 16:22 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211007161716.453984-1-philmd@redhat.com \
--to=philmd@redhat.com \
--cc=brijesh.singh@amd.com \
--cc=dgilbert@redhat.com \
--cc=dovmurik@linux.ibm.com \
--cc=ehabkost@redhat.com \
--cc=jejb@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=slp@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).