qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Warner Losh <imp@bsdimp.com>
To: qemu-devel@nongnu.org
Cc: kevans@freebsd.org, "Mikaël Urankar" <mikael.urankar@gmail.com>,
	richard.henderson@linaro.org, f4bug@amsat.org,
	"Warner Losh" <imp@bsdimp.com>
Subject: [PATCH v3 2/9] bsd-user/mmap.c: check pread's return value to fix warnings with _FORTIFY_SOURCE
Date: Fri,  8 Oct 2021 15:23:37 -0600	[thread overview]
Message-ID: <20211008212344.95537-3-imp@bsdimp.com> (raw)
In-Reply-To: <20211008212344.95537-1-imp@bsdimp.com>

From: Mikaël Urankar <mikael.urankar@gmail.com>

Simmilar to the equivalent linux-user: commit fb7e378cf9c, which added
checking to pread's return value. Update to current qemu standards with
{} around the if statement.

Signed-off-by: Mikaël Urankar <mikael.urankar@gmail.com>
Signed-off-by: Warner Losh <imp@bsdimp.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 bsd-user/mmap.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/bsd-user/mmap.c b/bsd-user/mmap.c
index fc3c1480f5..4f4fa3ab46 100644
--- a/bsd-user/mmap.c
+++ b/bsd-user/mmap.c
@@ -174,7 +174,9 @@ static int mmap_frag(abi_ulong real_start,
             mprotect(host_start, qemu_host_page_size, prot1 | PROT_WRITE);
 
         /* read the corresponding file data */
-        pread(fd, g2h_untagged(start), end - start, offset);
+        if (pread(fd, g2h_untagged(start), end - start, offset) == -1) {
+            return -1;
+        }
 
         /* put final protection */
         if (prot_new != (prot1 | PROT_WRITE))
@@ -593,7 +595,9 @@ abi_long target_mmap(abi_ulong start, abi_ulong len, int prot,
                                   -1, 0);
             if (retaddr == -1)
                 goto fail;
-            pread(fd, g2h_untagged(start), len, offset);
+            if (pread(fd, g2h_untagged(start), len, offset) == -1) {
+                goto fail;
+            }
             if (!(prot & PROT_WRITE)) {
                 ret = target_mprotect(start, len, prot);
                 if (ret != 0) {
-- 
2.32.0



  parent reply	other threads:[~2021-10-08 21:27 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-08 21:23 [PATCH v3 0/9] bsd-user mmap fixes Warner Losh
2021-10-08 21:23 ` [PATCH v3 1/9] bsd-user/mmap.c: Always zero MAP_ANONYMOUS memory in mmap_frag() Warner Losh
2021-10-14 15:05   ` Kyle Evans
2021-10-08 21:23 ` Warner Losh [this message]
2021-10-14 15:06   ` [PATCH v3 2/9] bsd-user/mmap.c: check pread's return value to fix warnings with _FORTIFY_SOURCE Kyle Evans
2021-10-08 21:23 ` [PATCH v3 3/9] bsd-user/mmap.c: MAP_ symbols are defined, so no need for ifdefs Warner Losh
2021-10-14 15:06   ` Kyle Evans
2021-10-08 21:23 ` [PATCH v3 4/9] bsd-user/mmap.c: mmap return ENOMEM on overflow Warner Losh
2021-10-14 15:13   ` Kyle Evans
2021-10-08 21:23 ` [PATCH v3 5/9] bsd-user/mmap.c: mmap prefer MAP_ANON for BSD Warner Losh
2021-10-14 15:06   ` Kyle Evans
2021-10-08 21:23 ` [PATCH v3 6/9] bsd-user/mmap.c: Convert to qemu_log logging for mmap debugging Warner Losh
2021-10-09 16:01   ` Richard Henderson
2021-10-11 18:52   ` Philippe Mathieu-Daudé
2021-10-18  3:44   ` Kyle Evans
2021-10-08 21:23 ` [PATCH v3 7/9] bsd-user/mmap.c: Don't mmap fd == -1 independently from MAP_ANON flag Warner Losh
2021-10-09 16:03   ` Richard Henderson
2021-10-18  3:43   ` Kyle Evans
2021-10-08 21:23 ` [PATCH v3 8/9] bsd-user/mmap.c: Implement MAP_EXCL, required by jemalloc in head Warner Losh
2021-10-09 16:04   ` Richard Henderson
2021-10-08 21:23 ` [PATCH v3 9/9] bsd-user/mmap.c: assert that target_mprotect cannot fail Warner Losh
2021-10-14 15:13   ` Kyle Evans

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211008212344.95537-3-imp@bsdimp.com \
    --to=imp@bsdimp.com \
    --cc=f4bug@amsat.org \
    --cc=kevans@freebsd.org \
    --cc=mikael.urankar@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).