qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jason Wang <jasowang@redhat.com>
To: mst@redhat.com, jasowang@redhat.com, qemu-devel@nongnu.org
Cc: eperezma@redhat.com, elic@nvidia.com, gdawar@xilinx.com,
	lingshan.zhu@intel.com, lulu@redhat.com
Subject: [PATCH V4 04/10] vhost-vdpa: let net_vhost_vdpa_init() returns NetClientState *
Date: Mon, 11 Oct 2021 12:28:23 +0800	[thread overview]
Message-ID: <20211011042829.4159-5-jasowang@redhat.com> (raw)
In-Reply-To: <20211011042829.4159-1-jasowang@redhat.com>

This patch switches to let net_vhost_vdpa_init() to return
NetClientState *. This is used for the callers to allocate multiqueue
NetClientState for multiqueue support.

Signed-off-by: Jason Wang <jasowang@redhat.com>
Message-Id: <20210907090322.1756-5-jasowang@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 net/vhost-vdpa.c | 19 ++++++++++++-------
 1 file changed, 12 insertions(+), 7 deletions(-)

diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c
index 73d29a74ef..834dab28dd 100644
--- a/net/vhost-vdpa.c
+++ b/net/vhost-vdpa.c
@@ -155,8 +155,10 @@ static NetClientInfo net_vhost_vdpa_info = {
         .has_ufo = vhost_vdpa_has_ufo,
 };
 
-static int net_vhost_vdpa_init(NetClientState *peer, const char *device,
-                               const char *name, int vdpa_device_fd)
+static NetClientState *net_vhost_vdpa_init(NetClientState *peer,
+                                           const char *device,
+                                           const char *name,
+                                           int vdpa_device_fd)
 {
     NetClientState *nc = NULL;
     VhostVDPAState *s;
@@ -170,8 +172,9 @@ static int net_vhost_vdpa_init(NetClientState *peer, const char *device,
     ret = vhost_vdpa_add(nc, (void *)&s->vhost_vdpa);
     if (ret) {
         qemu_del_net_client(nc);
+        return NULL;
     }
-    return ret;
+    return nc;
 }
 
 static int net_vhost_check_net(void *opaque, QemuOpts *opts, Error **errp)
@@ -196,7 +199,8 @@ int net_init_vhost_vdpa(const Netdev *netdev, const char *name,
                         NetClientState *peer, Error **errp)
 {
     const NetdevVhostVDPAOptions *opts;
-    int vdpa_device_fd, ret;
+    int vdpa_device_fd;
+    NetClientState *nc;
 
     assert(netdev->type == NET_CLIENT_DRIVER_VHOST_VDPA);
     opts = &netdev->u.vhost_vdpa;
@@ -211,10 +215,11 @@ int net_init_vhost_vdpa(const Netdev *netdev, const char *name,
         return -errno;
     }
 
-    ret = net_vhost_vdpa_init(peer, TYPE_VHOST_VDPA, name, vdpa_device_fd);
-    if (ret) {
+    nc = net_vhost_vdpa_init(peer, TYPE_VHOST_VDPA, name, vdpa_device_fd);
+    if (!nc) {
         qemu_close(vdpa_device_fd);
+        return -1;
     }
 
-    return ret;
+    return 0;
 }
-- 
2.25.1



  parent reply	other threads:[~2021-10-11  4:31 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-11  4:28 [PATCH V4 00/10] vhost-vDPA multiqueue Jason Wang
2021-10-11  4:28 ` [PATCH V4 01/10] vhost-vdpa: open device fd in net_init_vhost_vdpa() Jason Wang
2021-10-11  4:28 ` [PATCH V4 02/10] vhost-vdpa: classify one time request Jason Wang
2021-10-11  4:28 ` [PATCH V4 03/10] vhost-vdpa: prepare for the multiqueue support Jason Wang
2021-10-18 15:44   ` Stefano Garzarella
2021-10-20  2:50     ` Jason Wang
2021-10-11  4:28 ` Jason Wang [this message]
2021-10-11  4:28 ` [PATCH V4 05/10] net: introduce control client Jason Wang
2021-10-11  4:28 ` [PATCH V4 06/10] vhost-net: control virtqueue support Jason Wang
2021-10-11  4:28 ` [PATCH V4 07/10] virtio-net: use "queue_pairs" instead of "queues" when possible Jason Wang
2021-10-11  4:28 ` [PATCH V4 08/10] vhost: record the last virtqueue index for the virtio device Jason Wang
2021-10-11  4:28 ` [PATCH V4 09/10] virtio-net: vhost control virtqueue support Jason Wang
2021-10-11  4:28 ` [PATCH V4 10/10] vhost-vdpa: multiqueue support Jason Wang
2021-10-19  7:21 ` [PATCH V4 00/10] vhost-vDPA multiqueue Michael S. Tsirkin
2021-10-19  7:24   ` Jason Wang
2021-10-19 10:44     ` Michael S. Tsirkin
2021-10-19 11:17       ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211011042829.4159-5-jasowang@redhat.com \
    --to=jasowang@redhat.com \
    --cc=elic@nvidia.com \
    --cc=eperezma@redhat.com \
    --cc=gdawar@xilinx.com \
    --cc=lingshan.zhu@intel.com \
    --cc=lulu@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).