From: Andrew Jones <drjones@redhat.com>
To: Gavin Shan <gshan@redhat.com>
Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org,
qemu-arm@nongnu.org, shan.gavin@gmail.com, ehabkost@redhat.com
Subject: Re: [PATCH v2 1/2] numa: Set default distance map if needed
Date: Tue, 12 Oct 2021 08:39:51 +0200 [thread overview]
Message-ID: <20211012063951.iopcrftqtw67exln@gator.home> (raw)
In-Reply-To: <20211012063603.166255-2-gshan@redhat.com>
On Tue, Oct 12, 2021 at 02:36:02PM +0800, Gavin Shan wrote:
> The following option is used to specify the distance map. It's
> possible the option isn't provided by user. In this case, the
> distance map isn't populated and exposed to platform. On the
> other hand, the empty NUMA node, where no memory resides, is
> allowed on ARM64 virt platform. For these empty NUMA nodes,
> their corresponding device-tree nodes aren't populated, but
> their NUMA IDs should be included in the "/distance-map"
> device-tree node, so that kernel can probe them properly if
> device-tree is used.
>
> -numa,dist,src=<numa_id>,dst=<numa_id>,val=<distance>
>
> So when user doesn't specify distance map, we need to generate
> the default distance map, where the local and remote distances
> are 10 and 20 separately. However, this is going to change the
> hardware description of the guest in this particular scenario.
> It's fine as the guest should be tolerant to ignore the distance
> map completely or parse it properly by following the device-tree
> specification.
>
> This introduces an extra parameter to the exiting function
> complete_init_numa_distance() to generate the default distance
> map when no node pair distances are provided by user.
>
> Signed-off-by: Gavin Shan <gshan@redhat.com>
> ---
> hw/core/numa.c | 13 +++++++++++--
> 1 file changed, 11 insertions(+), 2 deletions(-)
>
Reviewed-by: Andrew Jones <drjones@redhat.com>
next prev parent reply other threads:[~2021-10-12 6:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-12 6:36 [PATCH v2 0/2] hw/arm/virt: Fix qemu booting failure on device-tree Gavin Shan
2021-10-12 6:36 ` [PATCH v2 1/2] numa: Set default distance map if needed Gavin Shan
2021-10-12 6:39 ` Andrew Jones [this message]
2021-10-12 6:36 ` [PATCH v2 2/2] hw/arm/virt: Don't create device-tree node for empty NUMA node Gavin Shan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211012063951.iopcrftqtw67exln@gator.home \
--to=drjones@redhat.com \
--cc=ehabkost@redhat.com \
--cc=gshan@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=shan.gavin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).