qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: marcandre.lureau@redhat.com, thuth@redhat.com,
	Stefan Hajnoczi <stefanha@redhat.com>
Subject: [PATCH v2 08/24] trace: simple: pass trace_file unmodified to config-host.h
Date: Tue, 12 Oct 2021 13:12:46 +0200	[thread overview]
Message-ID: <20211012111302.246627-9-pbonzini@redhat.com> (raw)
In-Reply-To: <20211012111302.246627-1-pbonzini@redhat.com>

Add the suffix directly in trace/simple.c, so that quoting is done
properly by Meson.

Cc: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20211007130829.632254-3-pbonzini@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 configure      | 2 --
 meson.build    | 2 +-
 trace/simple.c | 2 +-
 3 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/configure b/configure
index f5dfcf1a08..98723db0cd 100755
--- a/configure
+++ b/configure
@@ -4578,8 +4578,6 @@ if have_backend "nop"; then
 fi
 if have_backend "simple"; then
   echo "CONFIG_TRACE_SIMPLE=y" >> $config_host_mak
-  # Set the appropriate trace file.
-  trace_file="\"$trace_file-\" FMT_pid"
 fi
 if have_backend "log"; then
   echo "CONFIG_TRACE_LOG=y" >> $config_host_mak
diff --git a/meson.build b/meson.build
index f59acc7677..9c1efa4731 100644
--- a/meson.build
+++ b/meson.build
@@ -1571,7 +1571,7 @@ config_host_data.set('HAVE_BROKEN_SIZE_MAX', not cc.compiles('''
 
 ignored = ['CONFIG_QEMU_INTERP_PREFIX'] # actually per-target
 arrays = ['CONFIG_BDRV_RW_WHITELIST', 'CONFIG_BDRV_RO_WHITELIST']
-strings = ['HOST_DSOSUF', 'CONFIG_IASL']
+strings = ['HOST_DSOSUF', 'CONFIG_IASL', 'CONFIG_TRACE_FILE']
 foreach k, v: config_host
   if ignored.contains(k)
     # do nothing
diff --git a/trace/simple.c b/trace/simple.c
index ac499edee0..18af590cf7 100644
--- a/trace/simple.c
+++ b/trace/simple.c
@@ -364,7 +364,7 @@ void st_set_trace_file(const char *file)
 
     if (!file) {
         /* Type cast needed for Windows where getpid() returns an int. */
-        trace_file_name = g_strdup_printf(CONFIG_TRACE_FILE, (pid_t)getpid());
+        trace_file_name = g_strdup_printf(CONFIG_TRACE_FILE "-" FMT_pid, (pid_t)getpid());
     } else {
         trace_file_name = g_strdup_printf("%s", file);
     }
-- 
2.31.1




  parent reply	other threads:[~2021-10-12 11:47 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-12 11:12 [PATCH v2 00/24] configure->meson queue for 6.2 Paolo Bonzini
2021-10-12 11:12 ` [PATCH v2 01/24] configure: remove --oss-lib Paolo Bonzini
2021-10-12 11:12 ` [PATCH v2 02/24] audio: remove CONFIG_AUDIO_WIN_INT Paolo Bonzini
2021-10-12 12:02   ` Thomas Huth
2021-10-12 11:12 ` [PATCH v2 03/24] configure, meson: move audio driver detection to Meson Paolo Bonzini
2021-10-12 11:12 ` [PATCH v2 04/24] meson: define symbols for all available audio drivers Paolo Bonzini
2021-10-12 11:12 ` [PATCH v2 05/24] configure: add command line options for " Paolo Bonzini
2021-10-12 11:12 ` [PATCH v2 06/24] kconfig: split CONFIG_SPARSE_MEM from fuzzing Paolo Bonzini
2021-10-12 11:12 ` [PATCH v2 07/24] configure, meson: move fuzzing configuration to Meson Paolo Bonzini
2021-10-12 11:12 ` Paolo Bonzini [this message]
2021-10-12 11:12 ` [PATCH v2 09/24] trace: move configuration from configure " Paolo Bonzini
2021-10-12 11:12 ` [PATCH v2 10/24] configure, meson: move CONFIG_HOST_DSOSUF " Paolo Bonzini
2021-10-12 11:12 ` [PATCH v2 11/24] configure, meson: get HOST_WORDS_BIGENDIAN via the machine object Paolo Bonzini
2021-10-12 12:12   ` Thomas Huth
2021-10-12 11:12 ` [PATCH v2 12/24] configure, meson: remove CONFIG_GCOV from config-host.mak Paolo Bonzini
2021-10-12 17:40   ` Thomas Huth
2021-10-12 11:12 ` [PATCH v2 13/24] configure, meson: move remaining HAVE_* compiler tests to Meson Paolo Bonzini
2021-10-12 13:17   ` Thomas Huth
2021-10-13  7:46     ` Paolo Bonzini
2021-10-12 11:12 ` [PATCH v2 14/24] configure, meson: move pthread_setname_np checks " Paolo Bonzini
2021-10-12 13:35   ` Thomas Huth
2021-10-13  8:14     ` Paolo Bonzini
2021-10-12 11:12 ` [PATCH v2 15/24] configure, meson: move libaio check to meson.build Paolo Bonzini
2021-10-12 14:21   ` Thomas Huth
2021-10-12 11:12 ` [PATCH v2 16/24] configure, meson: move vde detection to meson Paolo Bonzini
2021-10-12 14:37   ` Thomas Huth
2021-10-12 11:12 ` [PATCH v2 17/24] configure, meson: move netmap " Paolo Bonzini
2021-10-12 14:55   ` Thomas Huth
2021-10-12 11:12 ` [PATCH v2 18/24] configure, meson: move Spice configure handling " Paolo Bonzini
2021-10-12 11:12 ` [PATCH v2 19/24] configure: remove obsolete Solaris ar check Paolo Bonzini
2021-10-12 11:12 ` [PATCH v2 20/24] configure, meson: move more compiler checks to Meson Paolo Bonzini
2021-10-12 11:12 ` [PATCH v2 21/24] configure: remove deprecated --{enable, disable}-git-update Paolo Bonzini
2021-10-12 15:05   ` Thomas Huth
2021-10-12 11:13 ` [PATCH v2 22/24] configure: accept "internal" for --enable-capstone/slirp/fdt Paolo Bonzini
2021-10-12 11:13 ` [PATCH v2 23/24] configure: prepare for auto-generated option parsing Paolo Bonzini
2021-10-12 11:13 ` [PATCH v2 24/24] configure: automatically parse command line for meson -D options Paolo Bonzini
2021-10-12 18:15   ` Thomas Huth
2021-10-13  7:43     ` Paolo Bonzini
2021-10-13 11:11       ` Paolo Bonzini
2021-10-13 11:27         ` Thomas Huth
2021-10-13 17:00           ` Paolo Bonzini
2021-10-14  6:13             ` Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211012111302.246627-9-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).