From: Greg Kurz <groug@kaod.org>
To: Will Cohen <wwcohen@gmail.com>
Cc: Christian Schoenebeck <qemu_oss@crudebyte.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH 00/11] 9p: Add support for Darwin
Date: Thu, 14 Oct 2021 09:03:59 +0200 [thread overview]
Message-ID: <20211014090359.0c0f7b4f@bahia.huguette> (raw)
In-Reply-To: <20211013230405.32170-1-wwcohen@gmail.com>
Hi Will,
It is strongly recommended that you Cc maintainers to increase the odds
they notice your patches in the flood of qemu-devel. FYI I only noticed
them because git-send-email Cc'd me thanks to the Reviewed-by: tags and
my address didn't change in the meantime. I'm thus Cc'ing Christian
who is the primary maintainer now (i.e. the person that can merge
your patches and send a PR for upstream inclusion).
FWIW git-publish [1] can Cc the relevant people for free.
[1] https://github.com/stefanha/git-publish
On Wed, 13 Oct 2021 19:03:54 -0400
Will Cohen <wwcohen@gmail.com> wrote:
> This is a continuation of a patch series adding 9p server support for Darwin,
> originally submitted by Keno Fischer in mid-2018
> (https://lists.nongnu.org/archive/html/qemu-devel/2018-06/msg04643.html). In
> some sense, this could be considered [PATCH v4] of that process, but I assume
> that the multi-year gap merits a fresh start..
>
This makes sense. For consistency with that assumption, it would also
make sense to clear all preexisting Reviewed-by: tags.
> It has since been updated and rebased for NixOS by Michael Roitzsch
> (https://github.com/NixOS/nixpkgs/pull/122420) with a goal of resubmitting
> upstream. I am submitting his patch set as suggested, as developed by Michael,
> with his Signed-off-by headers included in full.
>
QEMU cares about tracking of who did what and follows a policy inspired
from the linux kernel [2] [3].
Michael's Signed-off-by: should then appear on all patches, with a
mention of the extra changes that he made, e.g.
Signed-off-by: Keno Fischer <keno@juliacomputing.com>
[Michael Roitzsch: - rebased for NixOS
- some other change]
Signed-off-by: Michael Roitzsch <reactorcontrol@icloud.com>
If no changes were made, you still need to add a Signed-off-by: tag.
[2] https://wiki.qemu.org/Contribute/SubmitAPatch
[3] http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/SubmittingPatches?id=f6f94e2ab1b33f0082ac22d71f66385a60d8157f#n297
> Additionally, I have run the patches through checkpatch.pl and adjusted coding
> style accordingly (with the exception of ignoring warnings about avoid
Good ! If you have an account on gitlab, you can also push a branch there.
It will be submitted to gitlab CI and maybe give you the opportunity to
polish the patches some more before submission.
> architecture specific defines in hw/9pfs/9p-util-darwin.c, where they seem
> unavoidable), and have signed off on those modified commits.
>
As explained above, your Signed-off-by: is also needed in all patches,
even if you didn't change them.
Cheers,
--
Greg
>
>
next prev parent reply other threads:[~2021-10-14 7:06 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-13 23:03 [PATCH 00/11] 9p: Add support for Darwin Will Cohen
2021-10-13 23:03 ` [PATCH 01/11] 9p: linux: Fix a couple Linux assumptions Will Cohen
2021-10-13 23:03 ` [PATCH 02/11] 9p: Rename 9p-util -> 9p-util-linux Will Cohen
2021-10-13 23:03 ` [PATCH 03/11] 9p: darwin: Handle struct stat(fs) differences Will Cohen
2021-10-13 23:03 ` [PATCH 04/11] 9p: darwin: Handle struct dirent differences Will Cohen
2021-10-13 23:03 ` [PATCH 05/11] 9p: darwin: Ignore O_{NOATIME, DIRECT} Will Cohen
2021-10-13 23:04 ` [PATCH 06/11] 9p: darwin: Compatibility defn for XATTR_SIZE_MAX Will Cohen
2021-10-13 23:04 ` [PATCH 07/11] 9p: darwin: *xattr_nofollow implementations Will Cohen
2021-10-13 23:04 ` [PATCH 08/11] 9p: darwin: Compatibility for f/l*xattr Will Cohen
2021-10-13 23:04 ` [PATCH 09/11] 9p: darwin: Provide a fallback implementation for utimensat Will Cohen
2021-10-13 23:04 ` [PATCH 10/11] 9p: darwin: Implement compatibility for mknodat Will Cohen
2021-10-13 23:04 ` [PATCH 11/11] 9p: darwin: meson: Allow VirtFS on Darwin Will Cohen
2021-10-15 12:10 ` Paolo Bonzini
2021-10-14 7:03 ` Greg Kurz [this message]
2021-10-14 10:48 ` [PATCH 00/11] 9p: Add support for Darwin Will Cohen
2021-10-14 11:57 ` Christian Schoenebeck
2021-10-14 12:22 ` Will Cohen
2021-10-14 12:55 ` Christian Schoenebeck
2021-10-14 13:23 ` Will Cohen
2021-10-20 12:38 ` Christian Schoenebeck
-- strict thread matches above, loose matches on Subject: below --
2021-10-13 21:31 Will Cohen
2021-10-13 21:27 Will Cohen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211014090359.0c0f7b4f@bahia.huguette \
--to=groug@kaod.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu_oss@crudebyte.com \
--cc=wwcohen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).