From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: alex.bennee@linaro.org, laurent@vivier.eu, imp@bsdimp.com
Subject: [PATCH v5 66/67] target/hppa: Implement prctl_unalign_sigbus
Date: Thu, 14 Oct 2021 21:10:52 -0700 [thread overview]
Message-ID: <20211015041053.2769193-67-richard.henderson@linaro.org> (raw)
In-Reply-To: <20211015041053.2769193-1-richard.henderson@linaro.org>
Leave TARGET_ALIGNED_ONLY set, but use the new CPUState
flag to set MO_UNALN for the instructions that the kernel
handles in the unaligned trap.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
linux-user/hppa/target_prctl.h | 2 +-
target/hppa/cpu.h | 5 ++++-
target/hppa/translate.c | 19 +++++++++++++++----
3 files changed, 20 insertions(+), 6 deletions(-)
diff --git a/linux-user/hppa/target_prctl.h b/linux-user/hppa/target_prctl.h
index eb53b31ad5..5629ddbf39 100644
--- a/linux-user/hppa/target_prctl.h
+++ b/linux-user/hppa/target_prctl.h
@@ -1 +1 @@
-/* No special prctl support required. */
+#include "../generic/target_prctl_unalign.h"
diff --git a/target/hppa/cpu.h b/target/hppa/cpu.h
index 294fd7297f..45fd338b02 100644
--- a/target/hppa/cpu.h
+++ b/target/hppa/cpu.h
@@ -259,12 +259,14 @@ static inline target_ulong hppa_form_gva(CPUHPPAState *env, uint64_t spc,
return hppa_form_gva_psw(env->psw, spc, off);
}
-/* Since PSW_{I,CB} will never need to be in tb->flags, reuse them.
+/*
+ * Since PSW_{I,CB} will never need to be in tb->flags, reuse them.
* TB_FLAG_SR_SAME indicates that SR4 through SR7 all contain the
* same value.
*/
#define TB_FLAG_SR_SAME PSW_I
#define TB_FLAG_PRIV_SHIFT 8
+#define TB_FLAG_UNALIGN 0x400
static inline void cpu_get_tb_cpu_state(CPUHPPAState *env, target_ulong *pc,
target_ulong *cs_base,
@@ -279,6 +281,7 @@ static inline void cpu_get_tb_cpu_state(CPUHPPAState *env, target_ulong *pc,
#ifdef CONFIG_USER_ONLY
*pc = env->iaoq_f & -4;
*cs_base = env->iaoq_b & -4;
+ flags |= TB_FLAG_UNALIGN * !env_cpu(env)->prctl_unalign_sigbus;
#else
/* ??? E, T, H, L, B, P bits need to be here, when implemented. */
flags |= env->psw & (PSW_W | PSW_C | PSW_D);
diff --git a/target/hppa/translate.c b/target/hppa/translate.c
index c3698cf067..fdaa2b12b8 100644
--- a/target/hppa/translate.c
+++ b/target/hppa/translate.c
@@ -272,8 +272,18 @@ typedef struct DisasContext {
int mmu_idx;
int privilege;
bool psw_n_nonzero;
+
+#ifdef CONFIG_USER_ONLY
+ MemOp unalign;
+#endif
} DisasContext;
+#ifdef CONFIG_USER_ONLY
+#define UNALIGN(C) (C)->unalign
+#else
+#define UNALIGN(C) 0
+#endif
+
/* Note that ssm/rsm instructions number PSW_W and PSW_E differently. */
static int expand_sm_imm(DisasContext *ctx, int val)
{
@@ -1477,7 +1487,7 @@ static void do_load_32(DisasContext *ctx, TCGv_i32 dest, unsigned rb,
form_gva(ctx, &addr, &ofs, rb, rx, scale, disp, sp, modify,
ctx->mmu_idx == MMU_PHYS_IDX);
- tcg_gen_qemu_ld_reg(dest, addr, ctx->mmu_idx, mop);
+ tcg_gen_qemu_ld_reg(dest, addr, ctx->mmu_idx, mop | UNALIGN(ctx));
if (modify) {
save_gpr(ctx, rb, ofs);
}
@@ -1495,7 +1505,7 @@ static void do_load_64(DisasContext *ctx, TCGv_i64 dest, unsigned rb,
form_gva(ctx, &addr, &ofs, rb, rx, scale, disp, sp, modify,
ctx->mmu_idx == MMU_PHYS_IDX);
- tcg_gen_qemu_ld_i64(dest, addr, ctx->mmu_idx, mop);
+ tcg_gen_qemu_ld_i64(dest, addr, ctx->mmu_idx, mop | UNALIGN(ctx));
if (modify) {
save_gpr(ctx, rb, ofs);
}
@@ -1513,7 +1523,7 @@ static void do_store_32(DisasContext *ctx, TCGv_i32 src, unsigned rb,
form_gva(ctx, &addr, &ofs, rb, rx, scale, disp, sp, modify,
ctx->mmu_idx == MMU_PHYS_IDX);
- tcg_gen_qemu_st_i32(src, addr, ctx->mmu_idx, mop);
+ tcg_gen_qemu_st_i32(src, addr, ctx->mmu_idx, mop | UNALIGN(ctx));
if (modify) {
save_gpr(ctx, rb, ofs);
}
@@ -1531,7 +1541,7 @@ static void do_store_64(DisasContext *ctx, TCGv_i64 src, unsigned rb,
form_gva(ctx, &addr, &ofs, rb, rx, scale, disp, sp, modify,
ctx->mmu_idx == MMU_PHYS_IDX);
- tcg_gen_qemu_st_i64(src, addr, ctx->mmu_idx, mop);
+ tcg_gen_qemu_st_i64(src, addr, ctx->mmu_idx, mop | UNALIGN(ctx));
if (modify) {
save_gpr(ctx, rb, ofs);
}
@@ -4110,6 +4120,7 @@ static void hppa_tr_init_disas_context(DisasContextBase *dcbase, CPUState *cs)
ctx->mmu_idx = MMU_USER_IDX;
ctx->iaoq_f = ctx->base.pc_first | MMU_USER_IDX;
ctx->iaoq_b = ctx->base.tb->cs_base | MMU_USER_IDX;
+ ctx->unalign = (ctx->tb_flags & TB_FLAG_UNALIGN ? MO_UNALN : MO_ALIGN);
#else
ctx->privilege = (ctx->tb_flags >> TB_FLAG_PRIV_SHIFT) & 3;
ctx->mmu_idx = (ctx->tb_flags & PSW_D ? ctx->privilege : MMU_PHYS_IDX);
--
2.25.1
next prev parent reply other threads:[~2021-10-15 4:53 UTC|newest]
Thread overview: 101+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-15 4:09 [PATCH v5 00/67] user-only: Cleanup SIGSEGV and SIGBUS handling Richard Henderson
2021-10-15 4:09 ` [PATCH v5 01/67] accel/tcg: Split out adjust_signal_pc Richard Henderson
2021-10-15 18:18 ` Warner Losh
2021-10-15 4:09 ` [PATCH v5 02/67] accel/tcg: Move clear_helper_retaddr to cpu loop Richard Henderson
2021-10-15 4:09 ` [PATCH v5 03/67] accel/tcg: Split out handle_sigsegv_accerr_write Richard Henderson
2021-10-15 18:19 ` Warner Losh
2021-10-15 4:09 ` [PATCH v5 04/67] accel/tcg: Fold cpu_exit_tb_from_sighandler into caller Richard Henderson
2021-10-15 18:20 ` Warner Losh
2021-10-15 4:09 ` [PATCH v5 05/67] configure: Merge riscv32 and riscv64 host architectures Richard Henderson
2021-10-15 18:21 ` Warner Losh
2021-10-15 4:09 ` [PATCH v5 06/67] linux-user: Reorg handling for SIGSEGV Richard Henderson
2021-10-15 4:09 ` [PATCH v5 07/67] linux-user/host/x86: Populate host_signal.h Richard Henderson
2021-10-15 18:26 ` Warner Losh
2021-10-15 4:09 ` [PATCH v5 08/67] linux-user/host/ppc: " Richard Henderson
2021-10-15 4:09 ` [PATCH v5 09/67] linux-user/host/alpha: " Richard Henderson
2021-10-15 4:09 ` [PATCH v5 10/67] linux-user/host/sparc: " Richard Henderson
2021-10-15 18:30 ` Warner Losh
2021-10-15 4:09 ` [PATCH v5 11/67] linux-user/host/arm: " Richard Henderson
2021-10-15 18:30 ` Warner Losh
2021-10-15 4:09 ` [PATCH v5 12/67] linux-user/host/aarch64: " Richard Henderson
2021-10-15 18:30 ` Warner Losh
2021-10-15 19:49 ` Richard Henderson
2021-10-15 4:09 ` [PATCH v5 13/67] linux-user/host/s390: " Richard Henderson
2021-10-15 4:10 ` [PATCH v5 14/67] linux-user/host/mips: " Richard Henderson
2021-10-15 18:31 ` Warner Losh
2021-10-15 4:10 ` [PATCH v5 15/67] linux-user/host/riscv: " Richard Henderson
2021-10-15 18:32 ` Warner Losh
2021-10-15 4:10 ` [PATCH v5 16/67] target/arm: Fixup comment re handle_cpu_signal Richard Henderson
2021-10-15 18:32 ` Warner Losh
2021-10-29 23:27 ` Philippe Mathieu-Daudé
2021-10-15 4:10 ` [PATCH v5 17/67] linux-user/host/riscv: Improve host_signal_write Richard Henderson
2021-10-15 4:10 ` [PATCH v5 18/67] linux-user/signal: Drop HOST_SIGNAL_PLACEHOLDER Richard Henderson
2021-10-15 4:10 ` [PATCH v5 19/67] hw/core: Add TCGCPUOps.record_sigsegv Richard Henderson
2021-10-15 4:10 ` [PATCH v5 20/67] linux-user: Add cpu_loop_exit_sigsegv Richard Henderson
2021-10-15 4:10 ` [PATCH v5 21/67] target/alpha: Implement alpha_cpu_record_sigsegv Richard Henderson
2021-10-15 4:10 ` [PATCH v5 22/67] target/arm: Use cpu_loop_exit_sigsegv for mte tag lookup Richard Henderson
2021-10-15 18:34 ` Warner Losh
2021-10-15 4:10 ` [PATCH v5 23/67] target/arm: Implement arm_cpu_record_sigsegv Richard Henderson
2021-10-15 18:35 ` Warner Losh
2021-10-15 4:10 ` [PATCH v5 24/67] target/cris: Make cris_cpu_tlb_fill sysemu only Richard Henderson
2021-10-15 4:10 ` [PATCH v5 25/67] target/hexagon: Remove hexagon_cpu_tlb_fill Richard Henderson
2021-10-15 4:10 ` [PATCH v5 26/67] target/hppa: Make hppa_cpu_tlb_fill sysemu only Richard Henderson
2021-10-15 4:10 ` [PATCH v5 27/67] target/i386: Implement x86_cpu_record_sigsegv Richard Henderson
2021-10-15 4:10 ` [PATCH v5 28/67] target/m68k: Make m68k_cpu_tlb_fill sysemu only Richard Henderson
2021-10-15 4:10 ` [PATCH v5 29/67] target/microblaze: Make mb_cpu_tlb_fill " Richard Henderson
2021-10-15 4:10 ` [PATCH v5 30/67] target/mips: Make mips_cpu_tlb_fill " Richard Henderson
2021-10-15 18:40 ` Warner Losh
2021-10-15 4:10 ` [PATCH v5 31/67] target/nios2: Implement nios2_cpu_record_sigsegv Richard Henderson
2021-10-15 4:10 ` [PATCH v5 32/67] linux-user/openrisc: Adjust signal for EXCP_RANGE, EXCP_FPE Richard Henderson
2021-10-15 4:10 ` [PATCH v5 33/67] target/openrisc: Make openrisc_cpu_tlb_fill sysemu only Richard Henderson
2021-10-15 4:10 ` [PATCH v5 34/67] target/ppc: Implement ppc_cpu_record_sigsegv Richard Henderson
2021-10-15 18:45 ` Warner Losh
2021-10-15 4:10 ` [PATCH v5 35/67] target/riscv: Make riscv_cpu_tlb_fill sysemu only Richard Henderson
2021-10-15 18:45 ` Warner Losh
2021-10-15 4:10 ` [PATCH v5 36/67] target/s390x: Use probe_access_flags in s390_probe_access Richard Henderson
2021-10-15 4:10 ` [PATCH v5 37/67] target/s390x: Implement s390_cpu_record_sigsegv Richard Henderson
2021-10-15 4:10 ` [PATCH v5 38/67] target/sh4: Make sh4_cpu_tlb_fill sysemu only Richard Henderson
2021-10-15 4:10 ` [PATCH v5 39/67] target/sparc: Make sparc_cpu_tlb_fill " Richard Henderson
2021-10-15 4:10 ` [PATCH v5 40/67] target/xtensa: Make xtensa_cpu_tlb_fill " Richard Henderson
2021-10-15 4:10 ` [PATCH v5 41/67] accel/tcg: Restrict TCGCPUOps::tlb_fill() to sysemu Richard Henderson
2021-10-15 4:10 ` [PATCH v5 42/67] Revert "cpu: Move cpu_common_props to hw/core/cpu.c" Richard Henderson
2021-10-15 4:10 ` [PATCH v5 43/67] hw/core: Add TCGCPUOps.record_sigbus Richard Henderson
2021-10-15 18:47 ` Warner Losh
2021-10-15 4:10 ` [PATCH v5 44/67] linux-user: Add cpu_loop_exit_sigbus Richard Henderson
2021-10-15 18:49 ` Warner Losh
2021-10-29 23:35 ` Philippe Mathieu-Daudé
2021-10-15 4:10 ` [PATCH v5 45/67] target/alpha: Implement alpha_cpu_record_sigbus Richard Henderson
2021-10-15 4:10 ` [PATCH v5 46/67] target/arm: Implement arm_cpu_record_sigbus Richard Henderson
2021-10-15 19:05 ` Warner Losh
2021-10-15 4:10 ` [PATCH v5 47/67] linux-user/hppa: Remove EXCP_UNALIGN handling Richard Henderson
2021-10-15 4:10 ` [PATCH v5 48/67] target/microblaze: Do not set MO_ALIGN for user-only Richard Henderson
2021-10-15 4:10 ` [PATCH v5 49/67] target/ppc: Move SPR_DSISR setting to powerpc_excp Richard Henderson
2021-10-15 4:10 ` [PATCH v5 50/67] target/ppc: Set fault address in ppc_cpu_do_unaligned_access Richard Henderson
2021-10-15 4:10 ` [PATCH v5 51/67] target/ppc: Restrict ppc_cpu_do_unaligned_access to sysemu Richard Henderson
2021-10-15 19:06 ` Warner Losh
2021-10-29 23:36 ` Philippe Mathieu-Daudé
2021-10-15 4:10 ` [PATCH v5 52/67] target/s390x: Implement s390x_cpu_record_sigbus Richard Henderson
2021-10-29 23:38 ` Philippe Mathieu-Daudé
2021-10-15 4:10 ` [PATCH v5 53/67] linux-user/hppa: Remove POWERPC_EXCP_ALIGN handling Richard Henderson
2021-10-29 23:39 ` Philippe Mathieu-Daudé
2021-10-15 4:10 ` [PATCH v5 54/67] target/sh4: Set fault address in superh_cpu_do_unaligned_access Richard Henderson
2021-10-15 4:10 ` [PATCH v5 55/67] target/sparc: Remove DEBUG_UNALIGNED Richard Henderson
2021-10-15 4:10 ` [PATCH v5 56/67] target/sparc: Split out build_sfsr Richard Henderson
2021-10-15 4:10 ` [PATCH v5 57/67] target/sparc: Set fault address in sparc_cpu_do_unaligned_access Richard Henderson
2021-10-15 4:10 ` [PATCH v5 58/67] accel/tcg: Report unaligned atomics for user-only Richard Henderson
2021-10-15 19:08 ` Warner Losh
2021-10-29 23:43 ` Philippe Mathieu-Daudé
2021-10-15 4:10 ` [PATCH v5 59/67] accel/tcg: Report unaligned load/store " Richard Henderson
2021-10-15 19:08 ` Warner Losh
2021-10-15 4:10 ` [PATCH v5 60/67] tcg: Add helper_unaligned_{ld, st} for user-only sigbus Richard Henderson
2021-10-15 19:09 ` Warner Losh
2021-10-29 23:44 ` Philippe Mathieu-Daudé
2021-10-15 4:10 ` [PATCH v5 61/67] linux-user: Handle BUS_ADRALN in host_signal_handler Richard Henderson
2021-10-29 23:46 ` Philippe Mathieu-Daudé
2021-10-15 4:10 ` [PATCH v5 62/67] linux-user: Split out do_prctl and subroutines Richard Henderson
2021-10-15 4:10 ` [PATCH v5 63/67] linux-user: Disable more prctl subcodes Richard Henderson
2021-10-15 4:10 ` [PATCH v5 64/67] linux-user: Add code for PR_GET/SET_UNALIGN Richard Henderson
2021-10-15 19:11 ` Warner Losh
2021-10-15 4:10 ` [PATCH v5 65/67] target/alpha: Implement prctl_unalign_sigbus Richard Henderson
2021-10-15 4:10 ` Richard Henderson [this message]
2021-10-15 4:10 ` [PATCH v5 67/67] target/sh4: " Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211015041053.2769193-67-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=imp@bsdimp.com \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).