qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: BALATON Zoltan <balaton@eik.bme.hu>
To: qemu-devel@nongnu.org
Cc: Huacai Chen <chenhuacai@kernel.org>,
	Gerd Hoffmann <kraxel@redhat.com>, Philippe M-D <f4bug@amsat.org>
Subject: [PATCH] via-ide: Set user_creatable to false
Date: Fri, 15 Oct 2021 11:16:54 +0200	[thread overview]
Message-ID: <20211015092159.3E863748F57@zero.eik.bme.hu> (raw)
In-Reply-To: <cover.1634259980.git.balaton@eik.bme.hu>

This model only works as a function of the via superio chip not as a
standalone PCI device.

Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
---
This should be before the last patch changing via-ide or squshed into
it. And similar to usb part but there I need to add it to the info
struct. I can resend with these if you think this series worth the
hassle. The previous one fixing the usb irq works without this clean up.

 hw/ide/via.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/hw/ide/via.c b/hw/ide/via.c
index 252d18f4ac..82def819c4 100644
--- a/hw/ide/via.c
+++ b/hw/ide/via.c
@@ -217,6 +217,9 @@ static void via_ide_class_init(ObjectClass *klass, void *data)
 
     dc->reset = via_ide_reset;
     dc->vmsd = &vmstate_ide_pci;
+    /* Reason: only works as function of VIA southbridge */
+    dc->user_creatable = false;
+
     k->realize = via_ide_realize;
     k->exit = via_ide_exitfn;
     k->vendor_id = PCI_VENDOR_ID_VIA;
-- 
2.21.4



  parent reply	other threads:[~2021-10-15  9:29 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-15  1:06 [PATCH 0/4] Avoid using isa_get_irq in vt82c686 model BALATON Zoltan
2021-10-15  1:06 ` [PATCH 1/4] vt82c686: Move common code to via_isa_realize BALATON Zoltan
2021-10-15 21:48   ` Jiaxun Yang
2021-10-17 16:22   ` Philippe Mathieu-Daudé
2021-10-15  1:06 ` [PATCH 4/4] via-ide: Avoid using isa_get_irq() BALATON Zoltan
2021-10-17 16:31   ` Philippe Mathieu-Daudé
2021-10-17 18:44     ` BALATON Zoltan
2021-10-17 20:28       ` Philippe Mathieu-Daudé
2021-10-17 20:34         ` BALATON Zoltan
2021-10-18  6:19         ` Gerd Hoffmann
2021-10-18  9:46           ` BALATON Zoltan
2021-10-17 19:39     ` BALATON Zoltan
2021-10-17 20:25       ` Philippe Mathieu-Daudé
2021-10-17 20:31         ` BALATON Zoltan
2021-10-15  1:06 ` [PATCH 3/4] hw/usb/vt82c686-uhci-pci: " BALATON Zoltan
2021-10-17 16:24   ` Philippe Mathieu-Daudé
2021-10-15  1:06 ` [PATCH 2/4] vt82c686: Add a method to VIA_ISA to raise ISA interrupts BALATON Zoltan
2021-10-15 21:49   ` Jiaxun Yang
2021-10-17 16:23   ` Philippe Mathieu-Daudé
2021-10-15  9:16 ` BALATON Zoltan [this message]
2021-10-17 16:19   ` [PATCH] via-ide: Set user_creatable to false Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211015092159.3E863748F57@zero.eik.bme.hu \
    --to=balaton@eik.bme.hu \
    --cc=chenhuacai@kernel.org \
    --cc=f4bug@amsat.org \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).