* [PATCH] target/s390x/cpu.h: Remove unused SIGP_MODE defines
@ 2021-10-15 12:42 Thomas Huth
2021-10-15 12:59 ` David Hildenbrand
2021-10-15 14:21 ` Philippe Mathieu-Daudé
0 siblings, 2 replies; 3+ messages in thread
From: Thomas Huth @ 2021-10-15 12:42 UTC (permalink / raw)
To: qemu-s390x, David Hildenbrand; +Cc: Richard Henderson, qemu-devel
These are unused since commit 075e52b816648f21 ("s390x/cpumodel:
we are always in zarchitecture mode") and it's unlikely that we
will ever need them again. So let's simply remove them now.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
target/s390x/cpu.h | 5 -----
1 file changed, 5 deletions(-)
diff --git a/target/s390x/cpu.h b/target/s390x/cpu.h
index 3153d053e9..ca3845d023 100644
--- a/target/s390x/cpu.h
+++ b/target/s390x/cpu.h
@@ -674,11 +674,6 @@ QEMU_BUILD_BUG_ON(sizeof(SysIB) != 4096);
#define SIGP_STAT_INVALID_ORDER 0x00000002UL
#define SIGP_STAT_RECEIVER_CHECK 0x00000001UL
-/* SIGP SET ARCHITECTURE modes */
-#define SIGP_MODE_ESA_S390 0
-#define SIGP_MODE_Z_ARCH_TRANS_ALL_PSW 1
-#define SIGP_MODE_Z_ARCH_TRANS_CUR_PSW 2
-
/* SIGP order code mask corresponding to bit positions 56-63 */
#define SIGP_ORDER_MASK 0x000000ff
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] target/s390x/cpu.h: Remove unused SIGP_MODE defines
2021-10-15 12:42 [PATCH] target/s390x/cpu.h: Remove unused SIGP_MODE defines Thomas Huth
@ 2021-10-15 12:59 ` David Hildenbrand
2021-10-15 14:21 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: David Hildenbrand @ 2021-10-15 12:59 UTC (permalink / raw)
To: Thomas Huth, qemu-s390x; +Cc: Richard Henderson, qemu-devel
On 15.10.21 14:42, Thomas Huth wrote:
> These are unused since commit 075e52b816648f21 ("s390x/cpumodel:
> we are always in zarchitecture mode") and it's unlikely that we
> will ever need them again. So let's simply remove them now.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> target/s390x/cpu.h | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/target/s390x/cpu.h b/target/s390x/cpu.h
> index 3153d053e9..ca3845d023 100644
> --- a/target/s390x/cpu.h
> +++ b/target/s390x/cpu.h
> @@ -674,11 +674,6 @@ QEMU_BUILD_BUG_ON(sizeof(SysIB) != 4096);
> #define SIGP_STAT_INVALID_ORDER 0x00000002UL
> #define SIGP_STAT_RECEIVER_CHECK 0x00000001UL
>
> -/* SIGP SET ARCHITECTURE modes */
> -#define SIGP_MODE_ESA_S390 0
> -#define SIGP_MODE_Z_ARCH_TRANS_ALL_PSW 1
> -#define SIGP_MODE_Z_ARCH_TRANS_CUR_PSW 2
> -
> /* SIGP order code mask corresponding to bit positions 56-63 */
> #define SIGP_ORDER_MASK 0x000000ff
>
>
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] target/s390x/cpu.h: Remove unused SIGP_MODE defines
2021-10-15 12:42 [PATCH] target/s390x/cpu.h: Remove unused SIGP_MODE defines Thomas Huth
2021-10-15 12:59 ` David Hildenbrand
@ 2021-10-15 14:21 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-10-15 14:21 UTC (permalink / raw)
To: Thomas Huth, qemu-s390x, David Hildenbrand; +Cc: Richard Henderson, qemu-devel
On 10/15/21 14:42, Thomas Huth wrote:
> These are unused since commit 075e52b816648f21 ("s390x/cpumodel:
> we are always in zarchitecture mode") and it's unlikely that we
> will ever need them again. So let's simply remove them now.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> target/s390x/cpu.h | 5 -----
> 1 file changed, 5 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-15 14:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-15 12:42 [PATCH] target/s390x/cpu.h: Remove unused SIGP_MODE defines Thomas Huth
2021-10-15 12:59 ` David Hildenbrand
2021-10-15 14:21 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).