From: Zhang Chen <chen.zhang@intel.com>
To: Xie Changlong <xiechanglong.d@gmail.com>,
Wen Congyang <wencongyang2@huawei.com>,
qemu-trivial@nongnu.org
Cc: Zhang Chen <chen.zhang@intel.com>,
Lukas Straub <lukasstraub2@web.de>,
qemu-dev <qemu-devel@nongnu.org>,
Laurent Vivier <laurent@vivier.eu>
Subject: [PATCH] docs/block-replication.txt: Fix replication top-id command demo
Date: Mon, 18 Oct 2021 16:50:44 +0800 [thread overview]
Message-ID: <20211018085044.2788276-1-chen.zhang@intel.com> (raw)
This demo not correct, the original childs1 can't pass the
the bdrv_is_root_node check in replcation_start().
Keep consistent with docs/COLO-FT.txt
Signed-off-by: Zhang Chen <chen.zhang@intel.com>
---
docs/block-replication.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/block-replication.txt b/docs/block-replication.txt
index 108e9166a8..66ad540676 100644
--- a/docs/block-replication.txt
+++ b/docs/block-replication.txt
@@ -179,7 +179,7 @@ Primary:
Secondary:
-drive if=none,driver=raw,file.filename=1.raw,id=colo1 \
- -drive if=none,id=childs1,driver=replication,mode=secondary,top-id=childs1
+ -drive if=none,id=childs1,driver=replication,mode=secondary,top-id=top-disk1
file.file.filename=active_disk.qcow2,\
file.driver=qcow2,\
file.backing.file.filename=hidden_disk.qcow2,\
--
2.25.1
next reply other threads:[~2021-10-18 9:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-18 8:50 Zhang Chen [this message]
2021-11-18 6:01 ` [PATCH] docs/block-replication.txt: Fix replication top-id command demo Zhang, Chen
2021-12-17 10:25 ` Laurent Vivier
2021-12-17 10:35 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211018085044.2788276-1-chen.zhang@intel.com \
--to=chen.zhang@intel.com \
--cc=laurent@vivier.eu \
--cc=lukasstraub2@web.de \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=wencongyang2@huawei.com \
--cc=xiechanglong.d@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).