From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CC8DC433F5 for ; Tue, 19 Oct 2021 07:14:14 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 32C7260F8F for ; Tue, 19 Oct 2021 07:14:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 32C7260F8F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:51186 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mcjK9-0000gY-64 for qemu-devel@archiver.kernel.org; Tue, 19 Oct 2021 03:14:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51610) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mcjIk-00082x-JW for qemu-devel@nongnu.org; Tue, 19 Oct 2021 03:12:49 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:41177) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mcjIi-0002Hx-Vs for qemu-devel@nongnu.org; Tue, 19 Oct 2021 03:12:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1634627564; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Jls7fUIUE3b4VwemQ8ZxXhWsUTPAqX11INIiPo6qyyI=; b=erblvzzQ1IvXpwud+Re4eFJbmiZq6AU7xr41XLUybWQTjLQafTtHiEOPLerbc4RM9QmHuG KWMyFVgsm9uPs1KynEVtxssWW+ylJMrY5P4XcclLfW1P0N6Hxh7c/auZ9pa2V8mTrH4BlN cji+CgakfJk6cM+pQAbO3OWojbe0Ra4= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-555-pX2EmWEVMv-MADemsNINJA-1; Tue, 19 Oct 2021 03:12:43 -0400 X-MC-Unique: pX2EmWEVMv-MADemsNINJA-1 Received: by mail-wr1-f70.google.com with SMTP id j19-20020adfb313000000b00160a9de13b3so9769936wrd.8 for ; Tue, 19 Oct 2021 00:12:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Jls7fUIUE3b4VwemQ8ZxXhWsUTPAqX11INIiPo6qyyI=; b=O3L45kAwg3/CkbaTxYpL5pvuL2pcktBQcTuM/bYAmHZqrnLigCfk8zr8cCMEwOjs21 Qipdft/GMfWUWG4LQCRkWJLFb0L/qxL3QPEiRvWzfWJQXEMShGAZM75FQ7mJRmICvU+C LrGODOvO93HQK36oDT0AKQVpaIv4u4b4gjWsCSKtuXswOkTMz9G1i0zLs11eFvggxwbS qwaZ7oax5zNCTbGBpVmDGK6gTLmMEBtUzUXRqBUhXZecHiZFrwfVp3kdKwiQfvivdU97 LqFUBE0cTgzhik5snWwsy5MWspnL2cNs7vkJk1I1SOSKQ9ryPAPZLEv1xu6rV4lTkffW Cmeg== X-Gm-Message-State: AOAM533f9NRx89ZSdo/WqWPMEgBc16mtCsGkOIYlDezh0GoBmSLkIXKM +FskDHB4SY0BgrqxpX+EvpqQcHiT40Vvu0KfaWcyuwcassdFMZVtMwgUMzK1yPihHfxa3sxUXA7 bZ+r1JVq+QHWH0FY= X-Received: by 2002:a1c:1b90:: with SMTP id b138mr4132974wmb.160.1634627561978; Tue, 19 Oct 2021 00:12:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyCs83txbyX8xd0vm3LyQi5vQVTJ5kymzXvcDnXDzF4P8h2080bKNyiXSsb0+/+JH+eEPvJig== X-Received: by 2002:a1c:1b90:: with SMTP id b138mr4132951wmb.160.1634627561719; Tue, 19 Oct 2021 00:12:41 -0700 (PDT) Received: from localhost (nat-pool-brq-t.redhat.com. [213.175.37.10]) by smtp.gmail.com with ESMTPSA id g8sm1132599wrx.26.2021.10.19.00.12.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Oct 2021 00:12:41 -0700 (PDT) Date: Tue, 19 Oct 2021 09:12:40 +0200 From: Igor Mammedov To: Bin Meng Subject: Re: [PATCH 3/6] hw/riscv: shakti_c: Use MachineState::ram and MachineClass::default_ram_id Message-ID: <20211019091240.4cb89b87@redhat.com> In-Reply-To: <20211018153829.24382-3-bmeng.cn@gmail.com> References: <20211018153829.24382-1-bmeng.cn@gmail.com> <20211018153829.24382-3-bmeng.cn@gmail.com> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=imammedo@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=imammedo@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.049, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-riscv@nongnu.org, Alistair Francis , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, 18 Oct 2021 23:38:26 +0800 Bin Meng wrote: > Using memory_region_init_ram(), which can't possibly handle vhost-user, > and can't work as expected with '-numa node,memdev' options. > > Use MachineState::ram instead of manually initializing RAM memory > region, as well as by providing MachineClass::default_ram_id to > opt in to memdev scheme. > > Signed-off-by: Bin Meng Reviewed-by: Igor Mammedov > --- > > hw/riscv/shakti_c.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/hw/riscv/shakti_c.c b/hw/riscv/shakti_c.c > index d7d1f91fa5..90e2cf609f 100644 > --- a/hw/riscv/shakti_c.c > +++ b/hw/riscv/shakti_c.c > @@ -45,7 +45,6 @@ static void shakti_c_machine_state_init(MachineState *mstate) > { > ShaktiCMachineState *sms = RISCV_SHAKTI_MACHINE(mstate); > MemoryRegion *system_memory = get_system_memory(); > - MemoryRegion *main_mem = g_new(MemoryRegion, 1); > > /* Allow only Shakti C CPU for this platform */ > if (strcmp(mstate->cpu_type, TYPE_RISCV_CPU_SHAKTI_C) != 0) { > @@ -59,11 +58,9 @@ static void shakti_c_machine_state_init(MachineState *mstate) > qdev_realize(DEVICE(&sms->soc), NULL, &error_abort); > > /* register RAM */ > - memory_region_init_ram(main_mem, NULL, "riscv.shakti.c.ram", > - mstate->ram_size, &error_fatal); > memory_region_add_subregion(system_memory, > shakti_c_memmap[SHAKTI_C_RAM].base, > - main_mem); > + mstate->ram); > > /* ROM reset vector */ > riscv_setup_rom_reset_vec(mstate, &sms->soc.cpus, > @@ -88,6 +85,7 @@ static void shakti_c_machine_class_init(ObjectClass *klass, void *data) > mc->desc = "RISC-V Board compatible with Shakti SDK"; > mc->init = shakti_c_machine_state_init; > mc->default_cpu_type = TYPE_RISCV_CPU_SHAKTI_C; > + mc->default_ram_id = "riscv.shakti.c.ram"; > } > > static const TypeInfo shakti_c_machine_type_info = {