From: Stefan Reiter <s.reiter@proxmox.com>
To: "Marc-André Lureau" <marcandre.lureau@gmail.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Eric Blake" <eblake@redhat.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Wolfgang Bumiller" <w.bumiller@proxmox.com>,
"Thomas Lamprecht" <t.lamprecht@proxmox.com>
Cc: qemu-devel@nongnu.org
Subject: [PATCH v5 0/4] VNC-related HMP/QMP fixes
Date: Tue, 19 Oct 2021 17:54:39 +0200 [thread overview]
Message-ID: <20211019155443.1447372-1-s.reiter@proxmox.com> (raw)
Since the removal of the generic 'qmp_change' command, one can no longer replace
the 'default' VNC display listen address at runtime (AFAIK). For our users who
need to set up a secondary VNC access port, this means configuring a second VNC
display (in addition to our standard one for web-access), but it turns out one
cannot set a password on this second display at the moment, as the
'set_password' call only operates on the 'default' display.
Additionally, using secret objects, the password is only read once at startup.
This could be considered a bug too, but is not touched in this series and left
for a later date.
v4 -> v5:
* add comment to patch 1 in "monitor-internal.h" - I left Eric's R-b since the
code is the same, hope that's ok
* use qapi_free_SetPasswordOptions and friends, don't leak strdups
* split QAPI change into 3 seperate patches
v3 -> v4:
* drop previously patch 1, this was fixed here instead:
https://lists.gnu.org/archive/html/qemu-devel/2021-09/msg02529.html
* patch 1: add Eric's R-b
* patch 2: remove if-assignment, use 'deprecated' feature in schema
v2 -> v3:
* refactor QMP schema for set/expire_password as suggested by Eric Blake and
Markus Armbruster
v1 -> v2:
* add Marc-André's R-b on patch 1
* use '-d' flag as suggested by Eric Blake and Gerd Hoffmann
* I didn't see a way to do this yet, so I added a "flags with values" arg type
qemu: Stefan Reiter (4):
monitor/hmp: add support for flag argument with value
qapi/monitor: refactor set/expire_password with enums
qapi/monitor: allow VNC display id in set/expire_password
qapi/monitor: only allow 'keep' SetPasswordAction for VNC and deprecate
hmp-commands.hx | 24 +++---
monitor/hmp-cmds.c | 56 ++++++++++++-
monitor/hmp.c | 17 +++-
monitor/monitor-internal.h | 3 +-
monitor/qmp-cmds.c | 62 ++++++---------
qapi/ui.json | 156 ++++++++++++++++++++++++++++++++-----
6 files changed, 244 insertions(+), 74 deletions(-)
--
2.30.2
next reply other threads:[~2021-10-19 16:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-19 15:54 Stefan Reiter [this message]
2021-10-19 15:54 ` [PATCH v5 1/4] monitor/hmp: add support for flag argument with value Stefan Reiter
2021-10-19 15:54 ` [PATCH v5 2/4] qapi/monitor: refactor set/expire_password with enums Stefan Reiter
2021-10-20 5:47 ` Markus Armbruster
2021-10-19 15:54 ` [PATCH v5 3/4] qapi/monitor: allow VNC display id in set/expire_password Stefan Reiter
2021-10-20 7:31 ` Markus Armbruster
2021-10-19 15:54 ` [PATCH v5 4/4] qapi/monitor: only allow 'keep' SetPasswordAction for VNC and deprecate Stefan Reiter
2021-10-20 7:32 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211019155443.1447372-1-s.reiter@proxmox.com \
--to=s.reiter@proxmox.com \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=t.lamprecht@proxmox.com \
--cc=w.bumiller@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).