From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA302C433FE for ; Wed, 20 Oct 2021 07:42:37 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5BFA060E9B for ; Wed, 20 Oct 2021 07:42:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5BFA060E9B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:41986 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1md6FA-00013S-Bm for qemu-devel@archiver.kernel.org; Wed, 20 Oct 2021 03:42:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60434) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1md6EN-0000BM-VN for qemu-devel@nongnu.org; Wed, 20 Oct 2021 03:41:47 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:40349) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1md6EL-00083j-IB for qemu-devel@nongnu.org; Wed, 20 Oct 2021 03:41:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1634715704; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eXqxAElbgB44tmvKIHS6yRWe3wz0br9qQOCYtjXEwfc=; b=azn92UQBCv/Z+sxqEztwidMADPsjymR3dme+dWCWIIyMG0cAHRUg+YrRYd9q4SI2+n+Igm ubjQ/jsBLFkY3JkXFD05kQtzQqB7iBVu8o3WHy0kNZJLL+yaUYcOwlkMbvNgAggvqT0XRe Wfwo+l0FIeW/e7823ppjNQOFP6LvEj0= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-36-Tvuh7IvHOvyurHUDABxeRA-1; Wed, 20 Oct 2021 03:41:43 -0400 X-MC-Unique: Tvuh7IvHOvyurHUDABxeRA-1 Received: by mail-wm1-f70.google.com with SMTP id p3-20020a05600c204300b0030daa138dfeso3717135wmg.9 for ; Wed, 20 Oct 2021 00:41:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=eXqxAElbgB44tmvKIHS6yRWe3wz0br9qQOCYtjXEwfc=; b=bOinUVbqkCtoc7G7hfM+liHYzNSVubhlPMpo0ik5xgP74hpmpukXMoqftjapohVYLj 3Migfxrup5Rgqz3CIMpdVXQAwBMr4soDcbMdEXyNAVipToVsCPWoUMYdWbAgZ2s7XbJJ sFDw/9NcRIraMApXcqM3oJLW/i/R7UwQg7QDFs5y/xmqxamq+olxk8r1gG315EZ9ByHP fbAIxjSgoDCrO7ue/cy1WmkqfgmIrHjkAejDJwtNAjoAS4OdV3Fr6MJQI3hn8P0GzEWa A/5Q2oNTtV5lugjpCULdTgOwr0tYWEDVgxZh6B7PE9JIhjxjpn53FxyZKP+Q3q6BCa4P v19A== X-Gm-Message-State: AOAM533bL1p8ji7sF1JUEB5sf+3Gpk2g3CRncCyKBtEsKaUV0RMKhCDV SMvTIE1hiR7XOcpRKFrAnUD44nIZlNSgeu02yRI8ptgIKigRe8NVsh11fNzPgOak+l6esT1lcvL 56Yo/WLvE7QjY7+k= X-Received: by 2002:a05:6000:10c7:: with SMTP id b7mr49812595wrx.36.1634715702314; Wed, 20 Oct 2021 00:41:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwNIkRzxThdcglp1c2qevJcbjEdUkg3xwViOkGGR/exJP0xRPUZPybRQxRT+39ZYHd06qvlvw== X-Received: by 2002:a05:6000:10c7:: with SMTP id b7mr49812577wrx.36.1634715702097; Wed, 20 Oct 2021 00:41:42 -0700 (PDT) Received: from redhat.com ([2.55.24.172]) by smtp.gmail.com with ESMTPSA id y5sm1187391wrq.85.2021.10.20.00.41.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Oct 2021 00:41:41 -0700 (PDT) Date: Wed, 20 Oct 2021 03:41:38 -0400 From: "Michael S. Tsirkin" To: Eduardo Habkost Subject: Re: [PATCH] hw/qdev-core: Add compatibility for (non)-transitional devs Message-ID: <20211020034005-mutt-send-email-mst@kernel.org> References: <20211012082428.16222-1-jean-louis@dupond.be> <20211019065850-mutt-send-email-mst@kernel.org> <20211019152913.wjipmv6trjx6k7xa@habkost.net> <20211019120619-mutt-send-email-mst@kernel.org> <20211019165611.scfagcp4ikhigx5k@habkost.net> MIME-Version: 1.0 In-Reply-To: <20211019165611.scfagcp4ikhigx5k@habkost.net> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mst@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=170.10.133.124; envelope-from=mst@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: berrange@redhat.com, Stefan Hajnoczi , jasowang@redhat.com, qemu-devel@nongnu.org, Jean-Louis Dupond , pbonzini@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, Oct 19, 2021 at 12:56:11PM -0400, Eduardo Habkost wrote: > On Tue, Oct 19, 2021 at 12:13:17PM -0400, Michael S. Tsirkin wrote: > > On Tue, Oct 19, 2021 at 11:29:13AM -0400, Eduardo Habkost wrote: > > > On Tue, Oct 19, 2021 at 06:59:09AM -0400, Michael S. Tsirkin wrote: > > > > On Tue, Oct 19, 2021 at 11:46:17AM +0100, Stefan Hajnoczi wrote: > > > > > On Tue, Oct 12, 2021 at 10:36:01AM +0200, Jean-Louis Dupond wrote: > > > > > > Forgot to CC maintainers. > > > > > > > > > > Also CCing Jason Wang and Michael Tsirkin for VIRTIO. > > > > > > > > > > Stefan > > > > > > > > OMG > > > > where all compat properties broken all the time? > > > > > > Compat properties that existed when commit f6e501a28ef9 ("virtio: > > > Provide version-specific variants of virtio PCI devices") was > > > merged are not broken, because virtio-*-transitional and > > > virtio-*-non-transitional were brand new QOM types (so there's no > > > compatibility to be kept with old QEMU versions). > > > > > > Compat properties referencing "virtio-*-pci" instead of > > > "virtio-*-pci-base" added after commit f6e501a28ef9 are probably > > > broken, yes. > > > > > > -- > > > Eduardo > > > > Oh. So just this one: > > { "virtio-net-pci", "vectors", "3"}, > > > > right? > > I think so. That's the only post-4.0 virtio-*-pci compat property I see in > hw/core/machine.c. > > pc.c doesn't have any post-4.0 virtio-*-pci compat props. I didn't see any > virtio compat props on spapr.c and s390-virtio-ccw.c. > > > > > about the patch: how do people feel about virtio specific > > stuff in qdev core? Ok by everyone? > > Not OK, if we have a mechanism to avoid that, already (the > "virtio-net-pci-base" type name). I wonder what we can do to > make this kind of mistake less likely, though. > > Jean-Louis, Jason, does the following fix work? > > Signed-off-by: Eduardo Habkost > --- > diff --git a/hw/core/machine.c b/hw/core/machine.c > index b8d95eec32d..bd9c6156c1a 100644 > --- a/hw/core/machine.c > +++ b/hw/core/machine.c > @@ -56,7 +56,7 @@ GlobalProperty hw_compat_5_2[] = { > { "ICH9-LPC", "smm-compat", "on"}, > { "PIIX4_PM", "smm-compat", "on"}, > { "virtio-blk-device", "report-discard-granularity", "off" }, > - { "virtio-net-pci", "vectors", "3"}, > + { "virtio-net-pci-base", "vectors", "3"}, > }; > const size_t hw_compat_5_2_len = G_N_ELEMENTS(hw_compat_5_2); Hmm I'm a bit confused at this point, as to why does specifying properties for virtio-net-pci on command line with -global work, but in compat list doesn't. Do others understand? > -- > Eduardo