From: Yang Zhong <yang.zhong@intel.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: yang.zhong@intel.com, pbonzini@redhat.com, philmd@redhat.com,
qemu-devel@nongnu.org, eblake@redhat.com
Subject: Re: [PATCH 3/6] numa: Add SGXEPCSection list for multiple sections
Date: Wed, 20 Oct 2021 16:08:44 +0800 [thread overview]
Message-ID: <20211020080844.GD31332@yangzhon-Virtual> (raw)
In-Reply-To: <5cedb309-c12a-5d90-01fa-c129a457aa10@redhat.com>
On Tue, Oct 12, 2021 at 01:01:34PM +0200, Paolo Bonzini wrote:
> On 11/10/21 13:15, Yang Zhong wrote:
> >The SGXEPCSection list added into SGXInfo to show the multiple
> >SGX EPC sections detailed info, not the total size like before.
> >
> >Signed-off-by: Yang Zhong <yang.zhong@intel.com>
> >---
> > qapi/misc-target.json | 19 +++++++++++++++++--
> > 1 file changed, 17 insertions(+), 2 deletions(-)
> >
> >diff --git a/qapi/misc-target.json b/qapi/misc-target.json
> >index 594fbd1577..89a5a4250a 100644
> >--- a/qapi/misc-target.json
> >+++ b/qapi/misc-target.json
> >@@ -334,6 +334,21 @@
> > 'returns': 'SevAttestationReport',
> > 'if': 'TARGET_I386' }
> >+##
> >+# @SGXEPCSection:
> >+#
> >+# Information about intel SGX EPC section info
> >+#
> >+# @index: the SGX epc section index
> >+#
> >+# @size: the size of epc section
> >+#
> >+# Since: 6.2
> >+##
> >+{ 'struct': 'SGXEPCSection',
> >+ 'data': { 'index': 'uint64',
> >+ 'size': 'uint64'}}
> >+
> > ##
> > # @SGXInfo:
> > #
> >@@ -347,7 +362,7 @@
> > #
> > # @flc: true if FLC is supported
> > #
> >-# @section-size: The EPC section size for guest
> >+# @sections: The EPC sections info for guest
> > #
> > # Since: 6.2
> > ##
> >@@ -356,7 +371,7 @@
> > 'sgx1': 'bool',
> > 'sgx2': 'bool',
> > 'flc': 'bool',
> >- 'section-size': 'uint64'},
> >+ 'sections': ['SGXEPCSection']},
> > 'if': 'TARGET_I386' }
> > ##
> >
>
> I am not sure the index is particularly useful, but perhaps you
> should add the node there?
>
Good point! The node is much better than index here. thanks!
Yang
> Paolo
next prev parent reply other threads:[~2021-10-20 8:24 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-11 11:15 [PATCH 0/6] SGX NUMA support Yang Zhong
2021-10-11 11:15 ` [PATCH 1/6] numa: Enable numa for SGX EPC sections Yang Zhong
2021-10-11 16:32 ` Eric Blake
2021-10-20 7:02 ` Yang Zhong
2021-10-11 11:15 ` [PATCH 2/6] monitor: Support 'info numa' command Yang Zhong
2021-10-11 11:15 ` [PATCH 3/6] numa: Add SGXEPCSection list for multiple sections Yang Zhong
2021-10-11 17:03 ` Eric Blake
2021-10-12 11:01 ` Paolo Bonzini
2021-10-20 8:06 ` Yang Zhong
2021-10-12 11:01 ` Paolo Bonzini
2021-10-20 8:08 ` Yang Zhong [this message]
2021-10-11 11:15 ` [PATCH 4/6] monitor: numa support for 'info sgx' command Yang Zhong
2021-10-12 10:59 ` Paolo Bonzini
2021-10-20 7:08 ` Yang Zhong
2021-10-11 11:15 ` [PATCH 5/6] numa: Enable numa for libvirt interface Yang Zhong
2021-10-12 10:59 ` Paolo Bonzini
2021-10-11 11:15 ` [PATCH 6/6] doc: Add the SGX numa description Yang Zhong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211020080844.GD31332@yangzhon-Virtual \
--to=yang.zhong@intel.com \
--cc=eblake@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).