From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A5A4C433F5 for ; Tue, 26 Oct 2021 09:49:34 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C8D9161073 for ; Tue, 26 Oct 2021 09:49:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C8D9161073 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:58690 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mfJ5I-00063f-QX for qemu-devel@archiver.kernel.org; Tue, 26 Oct 2021 05:49:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44170) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mfJ3m-0004aG-8X for qemu-devel@nongnu.org; Tue, 26 Oct 2021 05:47:58 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:44380) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mfJ3k-0007YZ-Kk for qemu-devel@nongnu.org; Tue, 26 Oct 2021 05:47:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635241675; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gyMDuOEc7FDOanj+B/3W81R+WGSSdcmOgXxWyAqVHl4=; b=QwJgBeciRqA2kTY5GNADF4Mt6HgQ+pwLxTM38uuBRL3/DI0TIC0hd+DFSgsOTarRcVRkfO 9Eds5JDK6YpNSneBmez7+gYHTnvsF1Z51B6xi/Z2fQcJA7D2Ho0FXwvfh92u5plQeRqgy4 xmfw++73S2YISkibNaD0TOeo3JkJRJQ= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-188-C5yZDn_sMKKKwL3dbigWRQ-1; Tue, 26 Oct 2021 05:47:54 -0400 X-MC-Unique: C5yZDn_sMKKKwL3dbigWRQ-1 Received: by mail-ed1-f70.google.com with SMTP id y3-20020a056402358300b003dd490c775cso3280444edc.22 for ; Tue, 26 Oct 2021 02:47:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gyMDuOEc7FDOanj+B/3W81R+WGSSdcmOgXxWyAqVHl4=; b=x4OCG4NYT9ojTC+LVAa4T5/iKSdF9e0umAgbwWcXSh3m9oXZjQoQC2w16SNUbdbkKw Dhb34YlI2wdFeSQhc2LadDPljlPTgWISYMF79nQZUGNPhU9hecvzYVCesXJHY8bSt782 oGt2BJo11gsH9TDBjpUoAh0mmvIJtRDd7buGD6iVvbCxW5JyBW02toGkLEtjdrMXo/An y9+AGB8uEUZz5JWs+JFi5DPQgt8QCA9WkJJAGLMuGz/EwmhcZH9PevuNsv28ZxPGY96J V5VdRZ+3p7f5YJjGIwYTLLfaM4VxC8FHS7Uf7oIPR8vxh/FpdrVAXXOukCiQMyOUO6Jq D+rw== X-Gm-Message-State: AOAM533rrBWM9CJpJUUjQjAhHAOjKUkZkHiZFbUpmBCu8d4Z1QqUfRaI t/unkVXN2HRtVrszu5ONYSwD0DG8ltR9nG1mzzL4zEzZIiU1hqDFvE6RDoeZWDdyqxoa7d9JaPq 85CNxiKiSLN9x83Q= X-Received: by 2002:a17:907:3f17:: with SMTP id hq23mr28907213ejc.312.1635241673282; Tue, 26 Oct 2021 02:47:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwVajD9/N89co/DuPejLcznZE4UFqJugGtLd/+45QY/5CKni7m/6y4LNri5DNHvjrcECMS11Q== X-Received: by 2002:a17:907:3f17:: with SMTP id hq23mr28907193ejc.312.1635241673045; Tue, 26 Oct 2021 02:47:53 -0700 (PDT) Received: from localhost (nat-pool-brq-t.redhat.com. [213.175.37.10]) by smtp.gmail.com with ESMTPSA id yd8sm4120930ejb.33.2021.10.26.02.47.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Oct 2021 02:47:52 -0700 (PDT) Date: Tue, 26 Oct 2021 11:47:51 +0200 From: Igor Mammedov To: Gavin Shan Subject: Re: [PATCH] hw/arm/virt: Expose empty NUMA nodes through ACPI Message-ID: <20211026114751.427205bc@redhat.com> In-Reply-To: <20211025234101.224705-1-gshan@redhat.com> References: <20211025234101.224705-1-gshan@redhat.com> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=imammedo@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=imammedo@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, drjones@redhat.com, ehabkost@redhat.com, richard.henderson@linaro.org, qemu-devel@nongnu.org, qemu-arm@nongnu.org, shan.gavin@gmail.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, 26 Oct 2021 07:41:01 +0800 Gavin Shan wrote: > The empty NUMA nodes, where no memory resides, aren't exposed > through ACPI SRAT table. It's not user preferred behaviour because > the corresponding memory node devices are missed from the guest > kernel as the following example shows, and memory can't be hot > added to these empty NUMA nodes at later point. a error message one gets would be useful here. btw: memory hotplug seems to work for x86 without adding empty nodes. So it beg a question, if absence of empty nodes is the issue here. > > /home/gavin/sandbox/qemu.main/build/qemu-system-aarch64 \ > -accel kvm -machine virt,gic-version=host \ > -cpu host -smp 4,sockets=2,cores=2,threads=1 \ > -m 1024M,slots=16,maxmem=64G \ > -object memory-backend-ram,id=mem0,size=512M \ > -object memory-backend-ram,id=mem1,size=512M \ > -numa node,nodeid=0,cpus=0-1,memdev=mem0 \ > -numa node,nodeid=1,cpus=2-3,memdev=mem1 \ > -numa node,nodeid=2 \ > -numa node,nodeid=3 \ > : > guest# ls /sys/devices/system/node | grep node > node0 > node1 > node2 > > This exposes these empty NUMA nodes through ACPI SRAT table. With > this applied, the corresponding memory node devices can be found > from the guest. Note that the hotpluggable capability is explicitly > given to these empty NUMA nodes for sake of completeness. > > guest# ls /sys/devices/system/node | grep node > node0 > node1 > node2 > node3 > > Signed-off-by: Gavin Shan > --- > hw/arm/virt-acpi-build.c | 14 +++++++++----- > 1 file changed, 9 insertions(+), 5 deletions(-) > > diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c > index 674f902652..a4c95b2f64 100644 > --- a/hw/arm/virt-acpi-build.c > +++ b/hw/arm/virt-acpi-build.c > @@ -526,6 +526,7 @@ build_srat(GArray *table_data, BIOSLinker *linker, VirtMachineState *vms) > const CPUArchIdList *cpu_list = mc->possible_cpu_arch_ids(ms); > AcpiTable table = { .sig = "SRAT", .rev = 3, .oem_id = vms->oem_id, > .oem_table_id = vms->oem_table_id }; > + MemoryAffinityFlags flags; > > acpi_table_begin(&table, table_data); > build_append_int_noprefix(table_data, 1, 4); /* Reserved */ > @@ -547,12 +548,15 @@ build_srat(GArray *table_data, BIOSLinker *linker, VirtMachineState *vms) > > mem_base = vms->memmap[VIRT_MEM].base; > for (i = 0; i < ms->numa_state->num_nodes; ++i) { > - if (ms->numa_state->nodes[i].node_mem > 0) { > - build_srat_memory(table_data, mem_base, > - ms->numa_state->nodes[i].node_mem, i, > - MEM_AFFINITY_ENABLED); > - mem_base += ms->numa_state->nodes[i].node_mem; > + if (ms->numa_state->nodes[i].node_mem) { > + flags = MEM_AFFINITY_ENABLED; > + } else { > + flags = MEM_AFFINITY_ENABLED | MEM_AFFINITY_HOTPLUGGABLE; > } > + > + build_srat_memory(table_data, mem_base, > + ms->numa_state->nodes[i].node_mem, i, flags); > + mem_base += ms->numa_state->nodes[i].node_mem; > } > > if (ms->nvdimms_state->is_enabled) {