From: "Michael S. Tsirkin" <mst@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: Eduardo Habkost <ehabkost@redhat.com>,
kvm@vger.kernel.org, David Hildenbrand <david@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
qemu-devel@nongnu.org, Peter Xu <peterx@redhat.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
Sebastien Boeuf <sebastien.boeuf@intel.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>, Ani Sinha <ani@anisinha.ca>,
Igor Mammedov <imammedo@redhat.com>, Hui Zhu <teawater@gmail.com>
Subject: Re: [PATCH v1 02/12] vhost: Return number of free memslots
Date: Wed, 27 Oct 2021 11:33:02 -0400 [thread overview]
Message-ID: <20211027113245-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <8fc703aa-a256-fdef-36a5-6faad3da47d6@redhat.com>
On Wed, Oct 27, 2021 at 04:11:38PM +0200, Philippe Mathieu-Daudé wrote:
> On 10/27/21 16:04, David Hildenbrand wrote:
> > On 27.10.21 15:36, Philippe Mathieu-Daudé wrote:
> >> On 10/27/21 14:45, David Hildenbrand wrote:
> >>> Let's return the number of free slots instead of only checking if there
> >>> is a free slot. Required to support memory devices that consume multiple
> >>> memslots.
> >>>
> >>> Signed-off-by: David Hildenbrand <david@redhat.com>
> >>> ---
> >>> hw/mem/memory-device.c | 2 +-
> >>> hw/virtio/vhost-stub.c | 2 +-
> >>> hw/virtio/vhost.c | 4 ++--
> >>> include/hw/virtio/vhost.h | 2 +-
> >>> 4 files changed, 5 insertions(+), 5 deletions(-)
>
> >>> -bool vhost_has_free_slot(void)
> >>> +unsigned int vhost_get_free_memslots(void)
> >>> {
> >>> return true;
> >>
> >> return 0;
> >
> > Oh wait, no. This actually has to be
> >
> > "return ~0U;" (see real vhost_get_free_memslots())
> >
> > ... because there is no vhost and consequently no limit applies.
>
> Indeed.
>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
confused. are you acking the theoretical patch with ~0 here?
next prev parent reply other threads:[~2021-10-27 16:12 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-27 12:45 [PATCH v1 00/12] virtio-mem: Expose device memory via multiple memslots David Hildenbrand
2021-10-27 12:45 ` [PATCH v1 01/12] kvm: Return number of free memslots David Hildenbrand
2021-10-27 12:45 ` [PATCH v1 02/12] vhost: " David Hildenbrand
2021-10-27 13:36 ` Philippe Mathieu-Daudé
2021-10-27 13:37 ` David Hildenbrand
2021-10-27 14:04 ` David Hildenbrand
2021-10-27 14:11 ` Philippe Mathieu-Daudé
2021-10-27 15:33 ` Michael S. Tsirkin [this message]
2021-10-27 15:45 ` David Hildenbrand
2021-10-27 16:11 ` Philippe Mathieu-Daudé
2021-10-27 16:51 ` David Hildenbrand
2021-10-27 12:45 ` [PATCH v1 03/12] memory: Allow for marking memory region aliases unmergeable David Hildenbrand
2021-10-27 12:45 ` [PATCH v1 04/12] vhost: Don't merge unmergeable memory sections David Hildenbrand
2021-10-27 12:45 ` [PATCH v1 05/12] memory-device: Move memory_device_check_addable() directly into memory_device_pre_plug() David Hildenbrand
2021-10-27 12:45 ` [PATCH v1 06/12] memory-device: Generalize memory_device_used_region_size() David Hildenbrand
2021-10-27 12:45 ` [PATCH v1 07/12] memory-device: Support memory devices that dynamically consume multiple memslots David Hildenbrand
2021-10-27 12:45 ` [PATCH v1 08/12] vhost: Respect reserved memslots for memory devices when realizing a vhost device David Hildenbrand
2021-10-27 12:45 ` [PATCH v1 09/12] memory: Drop mapping check from memory_region_get_ram_discard_manager() David Hildenbrand
2021-10-27 12:45 ` [PATCH v1 10/12] virtio-mem: Fix typo in virito_mem_intersect_memory_section() function name David Hildenbrand
2022-12-28 14:05 ` Philippe Mathieu-Daudé
2022-12-28 14:06 ` David Hildenbrand
2022-12-28 14:07 ` Philippe Mathieu-Daudé
2021-10-27 12:45 ` [PATCH v1 11/12] virtio-mem: Set the RamDiscardManager for the RAM memory region earlier David Hildenbrand
2021-10-27 12:45 ` [PATCH v1 12/12] virtio-mem: Expose device memory via multiple memslots David Hildenbrand
2021-11-01 22:15 ` [PATCH v1 00/12] " Michael S. Tsirkin
2021-11-02 8:33 ` David Hildenbrand
2021-11-02 11:35 ` Michael S. Tsirkin
2021-11-02 11:55 ` David Hildenbrand
2021-11-02 17:06 ` Michael S. Tsirkin
2021-11-02 17:10 ` David Hildenbrand
2021-11-07 8:14 ` Michael S. Tsirkin
2021-11-07 9:21 ` David Hildenbrand
2021-11-07 10:21 ` Michael S. Tsirkin
2021-11-07 10:53 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211027113245-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=ani@anisinha.ca \
--cc=david@redhat.com \
--cc=dgilbert@redhat.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=sebastien.boeuf@intel.com \
--cc=stefanha@redhat.com \
--cc=teawater@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).