[PATCH v2] vhost-vdpa: Set discarding of RAM broken when initializing the backend

[PATCH v2] vhost-vdpa: Set discarding of RAM broken when initializing the backend

[David Hildenbrand]

Similar to VFIO, vDPA will go ahead an map+pin all guest memory. Memory
that used to be discarded will get re-populated and if we
discard+re-access memory after mapping+pinning, the pages mapped into the
vDPA IOMMU will go out of sync with the actual pages mapped into the user
space page tables.

Set discarding of RAM broken such that:
- virtio-mem and vhost-vdpa run mutually exclusive
- virtio-balloon is inhibited and no memory discards will get issued

In the future, we might be able to support coordinated discarding of RAM
as used by virtio-mem and already supported by vfio via the
RamDiscardManager.

Acked-by: Jason Wang <jasowang@redhat.com>
Cc: Jason Wang <jasowang@redhat.com>
Cc: Michael S. Tsirkin <mst@redhat.com>
Cc: Cindy Lu <lulu@redhat.com>
Signed-off-by: David Hildenbrand <david@redhat.com>
---

Unfortuantely, v1 never got picked up no matter how "hard" I tried to
ping :)

v1 -> v2:
- Add ack from Jason
- Extend patch description now that RamDiscardManager is upstream.

---
 hw/virtio/vhost-vdpa.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c
index 12661fd5b1..0d8051426c 100644
--- a/hw/virtio/vhost-vdpa.c
+++ b/hw/virtio/vhost-vdpa.c
@@ -331,6 +331,17 @@ static int vhost_vdpa_init(struct vhost_dev *dev, void *opaque, Error **errp)
     struct vhost_vdpa *v;
     assert(dev->vhost_ops->backend_type == VHOST_BACKEND_TYPE_VDPA);
     trace_vhost_vdpa_init(dev, opaque);
+    int ret;
+
+    /*
+     * Similar to VFIO, we end up pinning all guest memory and have to
+     * disable discarding of RAM.
+     */
+    ret = ram_block_discard_disable(true);
+    if (ret) {
+        error_report("Cannot set discarding of RAM broken");
+        return ret;
+    }
 
     v = opaque;
     v->dev = dev;
@@ -442,6 +453,8 @@ static int vhost_vdpa_cleanup(struct vhost_dev *dev)
     memory_listener_unregister(&v->listener);
 
     dev->opaque = NULL;
+    ram_block_discard_disable(false);
+
     return 0;
 }
 
-- 
2.31.1

Re: [PATCH v2] vhost-vdpa: Set discarding of RAM broken when initializing the backend

[Stefano Garzarella]

On Wed, Oct 27, 2021 at 03:03:24PM +0200, David Hildenbrand wrote:
>Similar to VFIO, vDPA will go ahead an map+pin all guest memory. Memory
>that used to be discarded will get re-populated and if we
>discard+re-access memory after mapping+pinning, the pages mapped into the
>vDPA IOMMU will go out of sync with the actual pages mapped into the user
>space page tables.
>
>Set discarding of RAM broken such that:
>- virtio-mem and vhost-vdpa run mutually exclusive
>- virtio-balloon is inhibited and no memory discards will get issued
>
>In the future, we might be able to support coordinated discarding of RAM
>as used by virtio-mem and already supported by vfio via the
>RamDiscardManager.
>
>Acked-by: Jason Wang <jasowang@redhat.com>
>Cc: Jason Wang <jasowang@redhat.com>
>Cc: Michael S. Tsirkin <mst@redhat.com>
>Cc: Cindy Lu <lulu@redhat.com>
>Signed-off-by: David Hildenbrand <david@redhat.com>
>---
>
>Unfortuantely, v1 never got picked up no matter how "hard" I tried to
>ping :)
>
>v1 -> v2:
>- Add ack from Jason
>- Extend patch description now that RamDiscardManager is upstream.
>
>---
> hw/virtio/vhost-vdpa.c | 13 +++++++++++++
> 1 file changed, 13 insertions(+)

Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>