From: Peter Xu <peterx@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Daniel P . Berrange" <berrange@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"David Hildenbrand" <david@redhat.com>,
"Jason Wang" <jasowang@redhat.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
peterx@redhat.com, "Eric Auger" <eric.auger@redhat.com>,
"Alex Williamson" <alex.williamson@redhat.com>,
"Igor Mammedov" <imammedo@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"David Gibson" <david@gibson.dropbear.id.au>
Subject: [PATCH v2 0/5] pci/iommu: Fail early if vfio-pci detected before vIOMMU
Date: Thu, 28 Oct 2021 12:31:24 +0800 [thread overview]
Message-ID: <20211028043129.38871-1-peterx@redhat.com> (raw)
Note that patch 1-4 are cleanups for pci subsystem, and patch 5 is a fix to
fail early for mis-ordered qemu cmdline on vfio and vIOMMU. Logically they
should be posted separately and they're not directly related, however to make
it still correlated to v1 I kept them in the same patchset.
In this version I used pre_plug() hook for q35 to detect the ordering issue as
Igor suggested, meanwhile it's done via object_resolve_path_type() rather than
scanning the pci bus as Michael suggested.
Please review, thanks.
v2 changelog:
- Picked up r-b where I can
- Merged patch 1 & 4, 2 & 3, 5 & 6
- s/pci_root_bus_args/PCIRootBusArgs/ [David, Michael]
- Replace "void* " with "void *" in pci.h [Phil]
- Dropped "pci: Add pci_for_each_device_all()"
- Dropped "x86-iommu: Fail early if vIOMMU specified after vfio-pci"
- Added "qom: object_child_foreach_recursive_type()"
- Added "pc/q35: Add pre-plug hook for x86-iommu"
v1: https://lore.kernel.org/qemu-devel/20211021104259.57754-1-peterx@redhat.com/
Peter Xu (5):
pci: Define pci_bus_dev_fn/pci_bus_fn/pci_bus_ret_fn
pci: Export pci_for_each_device_under_bus*()
qom: object_child_foreach_recursive_type()
pci: Add pci_for_each_root_bus()
pc/q35: Add pre-plug hook for x86-iommu
hw/arm/virt-acpi-build.c | 31 ++++++++--------------
hw/i386/acpi-build.c | 39 +++++++---------------------
hw/i386/pc.c | 4 +++
hw/i386/x86-iommu.c | 14 ++++++++++
hw/pci/pci.c | 52 +++++++++++++++++++++++++------------
hw/pci/pcie.c | 4 +--
hw/ppc/spapr_pci.c | 12 ++++-----
hw/ppc/spapr_pci_nvlink2.c | 7 +++--
hw/ppc/spapr_pci_vfio.c | 4 +--
hw/s390x/s390-pci-bus.c | 5 ++--
hw/xen/xen_pt.c | 4 +--
include/hw/i386/x86-iommu.h | 8 ++++++
include/hw/pci/pci.h | 26 ++++++++++++-------
include/qom/object.h | 20 ++++++++++++++
qom/object.c | 27 +++++++++++++++++++
15 files changed, 160 insertions(+), 97 deletions(-)
--
2.32.0
next reply other threads:[~2021-10-28 4:35 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-28 4:31 Peter Xu [this message]
2021-10-28 4:31 ` [PATCH v2 1/5] pci: Define pci_bus_dev_fn/pci_bus_fn/pci_bus_ret_fn Peter Xu
2021-10-28 4:31 ` [PATCH v2 2/5] pci: Export pci_for_each_device_under_bus*() Peter Xu
2021-10-29 0:06 ` David Gibson
2021-10-28 4:31 ` [PATCH v2 3/5] qom: object_child_foreach_recursive_type() Peter Xu
2021-10-28 7:06 ` David Hildenbrand
2021-10-28 4:31 ` [PATCH v2 4/5] pci: Add pci_for_each_root_bus() Peter Xu
2021-10-28 7:09 ` David Hildenbrand
2021-10-28 4:31 ` [PATCH v2 5/5] pc/q35: Add pre-plug hook for x86-iommu Peter Xu
2021-10-28 7:17 ` David Hildenbrand
2021-10-28 8:16 ` Peter Xu
2021-10-28 14:52 ` Alex Williamson
2021-10-28 15:36 ` Peter Xu
2021-10-28 16:11 ` Alex Williamson
2021-10-29 2:53 ` Peter Xu
2021-10-29 15:31 ` Alex Williamson
2021-11-02 1:15 ` [PATCH v2 0/5] pci/iommu: Fail early if vfio-pci detected before vIOMMU Peter Xu
2021-11-02 6:40 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211028043129.38871-1-peterx@redhat.com \
--to=peterx@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=david@redhat.com \
--cc=ehabkost@redhat.com \
--cc=eric.auger@redhat.com \
--cc=imammedo@redhat.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).