qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Subject: [PATCH 0/2] Replace custom test harness with "meson test"
Date: Thu, 28 Oct 2021 16:28:24 +0200	[thread overview]
Message-ID: <20211028142826.57327-1-pbonzini@redhat.com> (raw)

Hi all,

Starting with Meson 0.57, "meson test" has all features of QEMU's
makefile-based harness and more.  In particular, some features that
were added to reach feature parity are:

* print reproducer command line for each failed test right below the test

* keep the output of multiple (non-TAP) tests together in verbose mode,
  similar to "make --output-sync target"

* report on TAP subtests as they are encountered

It also includes nicer handling of test interruption, logging of the run
in the meson-logs/ subdirectory, and a progress report/spinner.  For
these reasons it would be nice to adopt it and remove the Perl scripts
that we have to present TAP output nicely.  It is also possible to
change qemu-iotests to TAP and describe it in tests/qemu-iotests/meson.build,
but this is left for later.

For people using "make check" there should be little or no change.
Otherwise:

* if you want to try "meson test", note that there could be timeouts on
  slower systems (and in particular OpenBSD is insanely slow on some
  tests).  Also if you use "meson test", note that CTRL+C will only
  interrupt the longest running test.  Pressing CTRL+C repeatedly three
  times (which you would likely do anyway, that's how humans work)
  interrupts the whole run.  This behavior does not apply to "make check".

* If you were using make check-report.tap and similar, they are replaced
  by targets like make check-report.junit.xml.  This is because Gitlab
  is able to parse the resulting XML and include on the website a report
  of which tests failed.

An example of non-verbose "make check" output is available at
https://gitlab.com/bonzini/qemu/-/jobs/1680980620.  A verbose run
instead is like https://asciinema.org/a/e5irnEszSnAheOHM30exbo3F6
(does not include check-block).

Paolo

RFC->v1:
- include submodule bump to 0.59.3
- do not include check-block part

Paolo Bonzini (2):
  meson: bump submodule to 0.59.3
  build: use "meson test" as the test harness

 Makefile                      |   3 +-
 configure                     |   2 +-
 meson                         |   2 +-
 meson.build                   |   5 +-
 scripts/meson-buildoptions.py |  16 --
 scripts/mtest2make.py         | 104 ++++--------
 scripts/tap-driver.pl         | 379 ------------------------------------------
 scripts/tap-merge.pl          | 111 -------------
 tests/fp/meson.build          |   2 +-
 9 files changed, 43 insertions(+), 581 deletions(-)
-- 
2.31.1



             reply	other threads:[~2021-10-28 14:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-28 14:28 Paolo Bonzini [this message]
2021-10-28 14:28 ` [PATCH 1/2] meson: bump submodule to 0.59.3 Paolo Bonzini
2021-10-28 16:05   ` Thomas Huth
2021-10-28 14:28 ` [PATCH 2/2] build: use "meson test" as the test harness Paolo Bonzini
2021-10-28 18:03   ` Thomas Huth
2021-10-31 21:04     ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211028142826.57327-1-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).