* [PATCH] tests/qtest/virtio-net: fix hotplug test case
@ 2021-10-28 17:30 Laurent Vivier
2021-10-29 2:35 ` Jason Wang
2021-11-08 17:12 ` Thomas Huth
0 siblings, 2 replies; 4+ messages in thread
From: Laurent Vivier @ 2021-10-28 17:30 UTC (permalink / raw)
To: qemu-devel; +Cc: Laurent Vivier, Paolo Bonzini, Thomas Huth, Jason Wang
virtio-net-test has an hotplug testcase that is never executed.
This is because the testcase is attached to virtio-pci interface
rather than to virtio-net-pci.
$ QTEST_QEMU_BINARY=./qemu-system-x86_64 tests/qtest/qos-test -l | grep hotplug
/x86_64/.../pci-ohci-tests/ohci_pci-test-hotplug
/x86_64/.../e1000e/e1000e-tests/hotplug
/x86_64/.../virtio-blk-pci/virtio-blk-pci-tests/hotplug
/x86_64/.../vhost-user-blk-pci/vhost-user-blk-pci-tests/hotplug
/x86_64/.../virtio-rng-pci/virtio-rng-pci-tests/hotplug
/x86_64/.../virtio-scsi/virtio-scsi-tests/hotplug
/x86_64/.../virtio-serial/virtio-serial-tests/hotplug
With this fix:
$ QTEST_QEMU_BINARY=./qemu-system-x86_64 tests/qtest/qos-test -l | grep hotplug
...
/x86_64/.../vhost-user-blk-pci/vhost-user-blk-pci-tests/hotplug
/x86_64/.../virtio-net-pci/virtio-net-pci-tests/hotplug
/x86_64/.../virtio-rng-pci/virtio-rng-pci-tests/hotplug
...
$ QTEST_QEMU_BINARY=./qemu-system-x86_64 tests/qtest/qos-test -p /x86_64/.../virtio-net-pci-tests/hotplug
/x86_64/pc/i440FX-pcihost/pci-bus-pc/pci-bus/virtio-net-pci/virtio-net-pci-tests/hotplug: OK
Fixes: 6ae333f91b99 ("qos-test: virtio-net test node")
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
---
tests/qtest/virtio-net-test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qtest/virtio-net-test.c b/tests/qtest/virtio-net-test.c
index a08e2ffe123f..8bf74e516cce 100644
--- a/tests/qtest/virtio-net-test.c
+++ b/tests/qtest/virtio-net-test.c
@@ -319,7 +319,7 @@ static void register_virtio_net_test(void)
.before = virtio_net_test_setup,
};
- qos_add_test("hotplug", "virtio-pci", hotplug, &opts);
+ qos_add_test("hotplug", "virtio-net-pci", hotplug, &opts);
#ifndef _WIN32
qos_add_test("basic", "virtio-net", send_recv_test, &opts);
qos_add_test("rx_stop_cont", "virtio-net", stop_cont_test, &opts);
--
2.31.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] tests/qtest/virtio-net: fix hotplug test case
2021-10-28 17:30 [PATCH] tests/qtest/virtio-net: fix hotplug test case Laurent Vivier
@ 2021-10-29 2:35 ` Jason Wang
2021-11-08 17:12 ` Thomas Huth
1 sibling, 0 replies; 4+ messages in thread
From: Jason Wang @ 2021-10-29 2:35 UTC (permalink / raw)
To: Laurent Vivier; +Cc: Paolo Bonzini, Thomas Huth, qemu-devel
On Fri, Oct 29, 2021 at 1:30 AM Laurent Vivier <lvivier@redhat.com> wrote:
>
> virtio-net-test has an hotplug testcase that is never executed.
>
> This is because the testcase is attached to virtio-pci interface
> rather than to virtio-net-pci.
>
> $ QTEST_QEMU_BINARY=./qemu-system-x86_64 tests/qtest/qos-test -l | grep hotplug
> /x86_64/.../pci-ohci-tests/ohci_pci-test-hotplug
> /x86_64/.../e1000e/e1000e-tests/hotplug
> /x86_64/.../virtio-blk-pci/virtio-blk-pci-tests/hotplug
> /x86_64/.../vhost-user-blk-pci/vhost-user-blk-pci-tests/hotplug
> /x86_64/.../virtio-rng-pci/virtio-rng-pci-tests/hotplug
> /x86_64/.../virtio-scsi/virtio-scsi-tests/hotplug
> /x86_64/.../virtio-serial/virtio-serial-tests/hotplug
>
> With this fix:
>
> $ QTEST_QEMU_BINARY=./qemu-system-x86_64 tests/qtest/qos-test -l | grep hotplug
> ...
> /x86_64/.../vhost-user-blk-pci/vhost-user-blk-pci-tests/hotplug
> /x86_64/.../virtio-net-pci/virtio-net-pci-tests/hotplug
> /x86_64/.../virtio-rng-pci/virtio-rng-pci-tests/hotplug
> ...
> $ QTEST_QEMU_BINARY=./qemu-system-x86_64 tests/qtest/qos-test -p /x86_64/.../virtio-net-pci-tests/hotplug
> /x86_64/pc/i440FX-pcihost/pci-bus-pc/pci-bus/virtio-net-pci/virtio-net-pci-tests/hotplug: OK
>
> Fixes: 6ae333f91b99 ("qos-test: virtio-net test node")
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Applied.
Thanks
> ---
> tests/qtest/virtio-net-test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/qtest/virtio-net-test.c b/tests/qtest/virtio-net-test.c
> index a08e2ffe123f..8bf74e516cce 100644
> --- a/tests/qtest/virtio-net-test.c
> +++ b/tests/qtest/virtio-net-test.c
> @@ -319,7 +319,7 @@ static void register_virtio_net_test(void)
> .before = virtio_net_test_setup,
> };
>
> - qos_add_test("hotplug", "virtio-pci", hotplug, &opts);
> + qos_add_test("hotplug", "virtio-net-pci", hotplug, &opts);
> #ifndef _WIN32
> qos_add_test("basic", "virtio-net", send_recv_test, &opts);
> qos_add_test("rx_stop_cont", "virtio-net", stop_cont_test, &opts);
> --
> 2.31.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] tests/qtest/virtio-net: fix hotplug test case
2021-10-28 17:30 [PATCH] tests/qtest/virtio-net: fix hotplug test case Laurent Vivier
2021-10-29 2:35 ` Jason Wang
@ 2021-11-08 17:12 ` Thomas Huth
2021-11-09 7:11 ` Laurent Vivier
1 sibling, 1 reply; 4+ messages in thread
From: Thomas Huth @ 2021-11-08 17:12 UTC (permalink / raw)
To: Laurent Vivier, qemu-devel; +Cc: QEMU Trivial, Paolo Bonzini, Jason Wang
On 28/10/2021 19.30, Laurent Vivier wrote:
> virtio-net-test has an hotplug testcase that is never executed.
>
> This is because the testcase is attached to virtio-pci interface
> rather than to virtio-net-pci.
>
> $ QTEST_QEMU_BINARY=./qemu-system-x86_64 tests/qtest/qos-test -l | grep hotplug
> /x86_64/.../pci-ohci-tests/ohci_pci-test-hotplug
> /x86_64/.../e1000e/e1000e-tests/hotplug
> /x86_64/.../virtio-blk-pci/virtio-blk-pci-tests/hotplug
> /x86_64/.../vhost-user-blk-pci/vhost-user-blk-pci-tests/hotplug
> /x86_64/.../virtio-rng-pci/virtio-rng-pci-tests/hotplug
> /x86_64/.../virtio-scsi/virtio-scsi-tests/hotplug
> /x86_64/.../virtio-serial/virtio-serial-tests/hotplug
>
> With this fix:
>
> $ QTEST_QEMU_BINARY=./qemu-system-x86_64 tests/qtest/qos-test -l | grep hotplug
> ...
> /x86_64/.../vhost-user-blk-pci/vhost-user-blk-pci-tests/hotplug
> /x86_64/.../virtio-net-pci/virtio-net-pci-tests/hotplug
> /x86_64/.../virtio-rng-pci/virtio-rng-pci-tests/hotplug
> ...
> $ QTEST_QEMU_BINARY=./qemu-system-x86_64 tests/qtest/qos-test -p /x86_64/.../virtio-net-pci-tests/hotplug
> /x86_64/pc/i440FX-pcihost/pci-bus-pc/pci-bus/virtio-net-pci/virtio-net-pci-tests/hotplug: OK
>
> Fixes: 6ae333f91b99 ("qos-test: virtio-net test node")
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> ---
> tests/qtest/virtio-net-test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/qtest/virtio-net-test.c b/tests/qtest/virtio-net-test.c
> index a08e2ffe123f..8bf74e516cce 100644
> --- a/tests/qtest/virtio-net-test.c
> +++ b/tests/qtest/virtio-net-test.c
> @@ -319,7 +319,7 @@ static void register_virtio_net_test(void)
> .before = virtio_net_test_setup,
> };
>
> - qos_add_test("hotplug", "virtio-pci", hotplug, &opts);
> + qos_add_test("hotplug", "virtio-net-pci", hotplug, &opts);
> #ifndef _WIN32
> qos_add_test("basic", "virtio-net", send_recv_test, &opts);
> qos_add_test("rx_stop_cont", "virtio-net", stop_cont_test, &opts);
>
Acked-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] tests/qtest/virtio-net: fix hotplug test case
2021-11-08 17:12 ` Thomas Huth
@ 2021-11-09 7:11 ` Laurent Vivier
0 siblings, 0 replies; 4+ messages in thread
From: Laurent Vivier @ 2021-11-09 7:11 UTC (permalink / raw)
To: Thomas Huth, Laurent Vivier, qemu-devel
Cc: QEMU Trivial, Paolo Bonzini, Jason Wang
Le 08/11/2021 à 18:12, Thomas Huth a écrit :
> On 28/10/2021 19.30, Laurent Vivier wrote:
>> virtio-net-test has an hotplug testcase that is never executed.
>>
>> This is because the testcase is attached to virtio-pci interface
>> rather than to virtio-net-pci.
>>
>> $ QTEST_QEMU_BINARY=./qemu-system-x86_64 tests/qtest/qos-test -l | grep hotplug
>> /x86_64/.../pci-ohci-tests/ohci_pci-test-hotplug
>> /x86_64/.../e1000e/e1000e-tests/hotplug
>> /x86_64/.../virtio-blk-pci/virtio-blk-pci-tests/hotplug
>> /x86_64/.../vhost-user-blk-pci/vhost-user-blk-pci-tests/hotplug
>> /x86_64/.../virtio-rng-pci/virtio-rng-pci-tests/hotplug
>> /x86_64/.../virtio-scsi/virtio-scsi-tests/hotplug
>> /x86_64/.../virtio-serial/virtio-serial-tests/hotplug
>>
>> With this fix:
>>
>> $ QTEST_QEMU_BINARY=./qemu-system-x86_64 tests/qtest/qos-test -l | grep hotplug
>> ...
>> /x86_64/.../vhost-user-blk-pci/vhost-user-blk-pci-tests/hotplug
>> /x86_64/.../virtio-net-pci/virtio-net-pci-tests/hotplug
>> /x86_64/.../virtio-rng-pci/virtio-rng-pci-tests/hotplug
>> ...
>> $ QTEST_QEMU_BINARY=./qemu-system-x86_64 tests/qtest/qos-test -p
>> /x86_64/.../virtio-net-pci-tests/hotplug
>> /x86_64/pc/i440FX-pcihost/pci-bus-pc/pci-bus/virtio-net-pci/virtio-net-pci-tests/hotplug: OK
>>
>> Fixes: 6ae333f91b99 ("qos-test: virtio-net test node")
>> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
>> ---
>> tests/qtest/virtio-net-test.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tests/qtest/virtio-net-test.c b/tests/qtest/virtio-net-test.c
>> index a08e2ffe123f..8bf74e516cce 100644
>> --- a/tests/qtest/virtio-net-test.c
>> +++ b/tests/qtest/virtio-net-test.c
>> @@ -319,7 +319,7 @@ static void register_virtio_net_test(void)
>> .before = virtio_net_test_setup,
>> };
>> - qos_add_test("hotplug", "virtio-pci", hotplug, &opts);
>> + qos_add_test("hotplug", "virtio-net-pci", hotplug, &opts);
>> #ifndef _WIN32
>> qos_add_test("basic", "virtio-net", send_recv_test, &opts);
>> qos_add_test("rx_stop_cont", "virtio-net", stop_cont_test, &opts);
>>
>
> Acked-by: Thomas Huth <thuth@redhat.com>
>
>
Applied to my trivial-patches branch.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-11-09 7:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-28 17:30 [PATCH] tests/qtest/virtio-net: fix hotplug test case Laurent Vivier
2021-10-29 2:35 ` Jason Wang
2021-11-08 17:12 ` Thomas Huth
2021-11-09 7:11 ` Laurent Vivier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).