From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: luis.pires@eldorado.org.br, alex.bennee@linaro.org, f4bug@amsat.org
Subject: [PATCH] tcg: Extend call args using the correct opcodes
Date: Thu, 28 Oct 2021 11:44:40 -0700 [thread overview]
Message-ID: <20211028184440.1508585-1-richard.henderson@linaro.org> (raw)
Pretending that the source is i64 when it is in fact i32 is
incorrect; we have type-changing opcodes that must be used.
This bug trips up the subsequent change to the optimizer.
Fixes: 4f2331e5b67a
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
This fixes a problem found in s390x host testing, and should
be considered patch 41.5/51 in
[PATCH v4 00/51] tcg: optimize redundant sign extensions
just before
tcg/optimize: Stop forcing z_mask to "garbage" for 32-bit values
r~
---
tcg/tcg.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tcg/tcg.c b/tcg/tcg.c
index 024a22cf39..6332cdceca 100644
--- a/tcg/tcg.c
+++ b/tcg/tcg.c
@@ -1508,11 +1508,11 @@ void tcg_gen_callN(void *func, TCGTemp *ret, int nargs, TCGTemp **args)
if (is_32bit) {
TCGv_i64 temp = tcg_temp_new_i64();
- TCGv_i64 orig = temp_tcgv_i64(args[i]);
+ TCGv_i32 orig = temp_tcgv_i32(args[i]);
if (is_signed) {
- tcg_gen_ext32s_i64(temp, orig);
+ tcg_gen_ext_i32_i64(temp, orig);
} else {
- tcg_gen_ext32u_i64(temp, orig);
+ tcg_gen_extu_i32_i64(temp, orig);
}
args[i] = tcgv_i64_temp(temp);
}
--
2.25.1
next reply other threads:[~2021-10-28 18:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-28 18:44 Richard Henderson [this message]
2021-10-28 18:59 ` [PATCH] tcg: Extend call args using the correct opcodes Philippe Mathieu-Daudé
2021-10-28 19:55 ` Luis Fernando Fujita Pires
2021-11-01 10:14 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211028184440.1508585-1-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=f4bug@amsat.org \
--cc=luis.pires@eldorado.org.br \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).