From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
Pavel Dovgalyuk <pavel.dovgalyuk@ispras.ru>,
Eduardo Habkost <ehabkost@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: [PULL 9/9] hw/i386: fix vmmouse registration
Date: Mon, 1 Nov 2021 19:44:50 -0400 [thread overview]
Message-ID: <20211101234358.582487-10-mst@redhat.com> (raw)
In-Reply-To: <20211101234358.582487-1-mst@redhat.com>
From: Pavel Dovgalyuk <pavel.dovgalyuk@ispras.ru>
According to the logic of vmmouse_update_handler function,
vmmouse should be registered as an event handler when
it's status is zero.
vmmouse_read_id resets the status but does not register
the handler.
This patch adds vmmouse registration and activation when
status is reset.
Signed-off-by: Pavel Dovgalyuk <Pavel.Dovgalyuk@ispras.ru>
Message-Id: <163524204515.1914131.16465061981774791228.stgit@pasha-ThinkPad-X280>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
hw/i386/vmmouse.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/i386/vmmouse.c b/hw/i386/vmmouse.c
index df4798f502..3d66368286 100644
--- a/hw/i386/vmmouse.c
+++ b/hw/i386/vmmouse.c
@@ -158,6 +158,7 @@ static void vmmouse_read_id(VMMouseState *s)
s->queue[s->nb_queue++] = VMMOUSE_VERSION;
s->status = 0;
+ vmmouse_update_handler(s, s->absolute);
}
static void vmmouse_request_relative(VMMouseState *s)
--
MST
next prev parent reply other threads:[~2021-11-02 0:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-01 23:44 [PULL 0/9] pc,pci,virtio: features, fixes Michael S. Tsirkin
2021-11-01 23:44 ` [PULL 1/9] qtest: fix 'expression is always false' build failure in qtest_has_accel() Michael S. Tsirkin
2021-11-01 23:44 ` [PULL 2/9] vhost-vdpa: Set discarding of RAM broken when initializing the backend Michael S. Tsirkin
2021-11-01 23:44 ` [PULL 3/9] hw/acpi: Add VIOT table Michael S. Tsirkin
2021-11-01 23:44 ` [PULL 4/9] hw/i386/pc: Remove x86_iommu_get_type() Michael S. Tsirkin
2021-11-01 23:44 ` [PULL 5/9] hw/i386/pc: Move IOMMU singleton into PCMachineState Michael S. Tsirkin
2021-11-01 23:44 ` [PULL 6/9] hw/i386/pc: Allow instantiating a virtio-iommu device Michael S. Tsirkin
2021-11-01 23:44 ` [PULL 7/9] pci: Define pci_bus_dev_fn/pci_bus_fn/pci_bus_ret_fn Michael S. Tsirkin
2021-11-01 23:44 ` [PULL 8/9] pci: Export pci_for_each_device_under_bus*() Michael S. Tsirkin
2021-11-02 13:54 ` Matthew Rosato
2021-11-01 23:44 ` Michael S. Tsirkin [this message]
2021-11-03 1:04 ` [PULL 0/9] pc,pci,virtio: features, fixes Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211101234358.582487-10-mst@redhat.com \
--to=mst@redhat.com \
--cc=ehabkost@redhat.com \
--cc=pavel.dovgalyuk@ispras.ru \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).