From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Jean-Philippe Brucker" <jean-philippe@linaro.org>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Eric Auger" <eric.auger@redhat.com>
Subject: [PULL 12/12] hw/arm/virt: Rename default_bus_bypass_iommu
Date: Tue, 2 Nov 2021 06:59:34 -0400 [thread overview]
Message-ID: <20211102105934.214596-13-richard.henderson@linaro.org> (raw)
In-Reply-To: <20211102105934.214596-1-richard.henderson@linaro.org>
From: Jean-Philippe Brucker <jean-philippe@linaro.org>
Since commit d8fb7d0969d5 ("vl: switch -M parsing to keyval"), machine
parameter definitions cannot use underscores, because keyval_dashify()
transforms them to dashes and the parser doesn't find the parameter.
This affects option default_bus_bypass_iommu which was introduced in the
same release:
$ qemu-system-aarch64 -M virt,default_bus_bypass_iommu=on
qemu-system-aarch64: Property 'virt-6.1-machine.default-bus-bypass-iommu' not found
Rename the parameter to "default-bus-bypass-iommu". Passing
"default_bus_bypass_iommu" is still valid since the underscore are
transformed automatically.
Fixes: 6d7a85483a06 ("hw/arm/virt: Add default_bus_bypass_iommu machine option")
Signed-off-by: Jean-Philippe Brucker <jean-philippe@linaro.org>
Tested-by: Eric Auger <eric.auger@redhat.com>
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20211026093733.2144161-1-jean-philippe@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
hw/arm/virt.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/arm/virt.c b/hw/arm/virt.c
index ca433adb5b..369552ad45 100644
--- a/hw/arm/virt.c
+++ b/hw/arm/virt.c
@@ -2737,10 +2737,10 @@ static void virt_machine_class_init(ObjectClass *oc, void *data)
"Set the IOMMU type. "
"Valid values are none and smmuv3");
- object_class_property_add_bool(oc, "default_bus_bypass_iommu",
+ object_class_property_add_bool(oc, "default-bus-bypass-iommu",
virt_get_default_bus_bypass_iommu,
virt_set_default_bus_bypass_iommu);
- object_class_property_set_description(oc, "default_bus_bypass_iommu",
+ object_class_property_set_description(oc, "default-bus-bypass-iommu",
"Set on/off to enable/disable "
"bypass_iommu for default root bus");
--
2.25.1
prev parent reply other threads:[~2021-11-02 11:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-02 10:59 [PULL 00/12] target/arm patch queue Richard Henderson
2021-11-02 10:59 ` [PULL 01/12] hw/sd: add nuvoton MMC Richard Henderson
2021-11-02 10:59 ` [PULL 02/12] hw/arm: Add Nuvoton SD module to board Richard Henderson
2021-11-02 10:59 ` [PULL 03/12] hw/arm: Attach MMC to quanta-gbs-bmc Richard Henderson
2021-11-02 10:59 ` [PULL 04/12] tests/qtest/libqos: add SDHCI commands Richard Henderson
2021-11-02 10:59 ` [PULL 05/12] tests/qtest: add qtests for npcm7xx sdhci Richard Henderson
2021-11-02 17:48 ` Philippe Mathieu-Daudé
2021-11-02 10:59 ` [PULL 06/12] target/arm: Advertise MVE to gdb when present Richard Henderson
2021-11-02 10:59 ` [PULL 07/12] target/arm: Use tcg_constant_i32() in op_smlad() Richard Henderson
2021-11-02 10:59 ` [PULL 08/12] target/arm: Introduce store_cpu_field_constant() helper Richard Henderson
2021-11-02 10:59 ` [PULL 09/12] target/arm: Use the constant variant of store_cpu_field() when possible Richard Henderson
2021-11-02 10:59 ` [PULL 10/12] target/arm: Use tcg_constant_i64() in do_sat_addsub_64() Richard Henderson
2021-11-02 10:59 ` [PULL 11/12] target/arm: Use tcg_constant_i32() in gen_rev16() Richard Henderson
2021-11-02 10:59 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211102105934.214596-13-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=eric.auger@redhat.com \
--cc=jean-philippe@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).