From: David Hildenbrand <david@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Eduardo Habkost" <ehabkost@redhat.com>,
"David Hildenbrand" <david@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Peter Xu" <peterx@redhat.com>,
"Igor Mammedov" <imammedo@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: [PATCH v3 0/3] memory: memory_region_is_mapped() cleanups
Date: Tue, 2 Nov 2021 17:43:14 +0100 [thread overview]
Message-ID: <20211102164317.45658-1-david@redhat.com> (raw)
Playing with memory_region_is_mapped(), I realized that memory regions
mapped via an alias behave a little bit "differently", as they don't have
their ->container set.
* memory_region_is_mapped() will never succeed for memory regions mapped
via an alias
* memory_region_to_address_space(), memory_region_find(),
memory_region_find_rcu(), memory_region_present() won't work, which seems
okay, because we don't expect such memory regions getting passed to these
functions.
* memory_region_to_absolute_addr() will result in a wrong address. As
the result is only used for tracing, that is tolerable.
Let's cleanup/fix the code and documentation of memory_region_is_mapped()
and change one user that really should be checking something else.
v1 -> v2:
- "memory: Make memory_region_is_mapped() succeed when mapped via an
alias"
-- Add an assertion
- Add RBs
Cc: Eduardo Habkost <ehabkost@redhat.com>
Cc: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Peter Xu <peterx@redhat.com>
Cc: Igor Mammedov <imammedo@redhat.com>
Cc: Richard Henderson <richard.henderson@linaro.org>
Cc: "Philippe Mathieu-Daudé" <philmd@redhat.com>
David Hildenbrand (3):
machine: Use host_memory_backend_is_mapped() in
machine_consume_memdev()
memory: Make memory_region_is_mapped() succeed when mapped via an
alias
memory: Update description of memory_region_is_mapped()
hw/core/machine.c | 2 +-
include/exec/memory.h | 4 +++-
softmmu/memory.c | 13 ++++++++++++-
3 files changed, 16 insertions(+), 3 deletions(-)
--
2.31.1
next reply other threads:[~2021-11-02 17:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-02 16:43 David Hildenbrand [this message]
2021-11-02 16:43 ` [PATCH v3 1/3] machine: Use host_memory_backend_is_mapped() in machine_consume_memdev() David Hildenbrand
2021-11-02 16:43 ` [PATCH v3 2/3] memory: Make memory_region_is_mapped() succeed when mapped via an alias David Hildenbrand
2022-01-30 22:50 ` Niek Linnenbank
2022-01-30 23:29 ` Philippe Mathieu-Daudé via
2022-01-31 19:20 ` Niek Linnenbank
2022-01-31 23:47 ` Philippe Mathieu-Daudé via
2022-01-31 8:11 ` David Hildenbrand
2022-01-31 18:58 ` Niek Linnenbank
2021-11-02 16:43 ` [PATCH v3 3/3] memory: Update description of memory_region_is_mapped() David Hildenbrand
2022-01-18 8:40 ` [PATCH v3 0/3] memory: memory_region_is_mapped() cleanups David Hildenbrand
2022-01-18 9:16 ` Philippe Mathieu-Daudé via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211102164317.45658-1-david@redhat.com \
--to=david@redhat.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).