qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Juan Quintela <quintela@redhat.com>
To: qemu-devel@nongnu.org
Cc: Lukas Straub <lukasstraub2@web.de>,
	Hailiang Zhang <zhang.zhanghailiang@huawei.com>,
	Li Zhijian <lizhijian@cn.fujitsu.com>,
	Juan Quintela <quintela@redhat.com>,
	Jason Wang <jasowang@redhat.com>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	Zhang Chen <chen.zhang@intel.com>
Subject: [PULL 10/11] colo: Don't dump colo cache if dump-guest-core=off
Date: Wed,  3 Nov 2021 09:46:04 +0100	[thread overview]
Message-ID: <20211103084605.20027-11-quintela@redhat.com> (raw)
In-Reply-To: <20211103084605.20027-1-quintela@redhat.com>

From: Lukas Straub <lukasstraub2@web.de>

One might set dump-guest-core=off to make coredumps smaller and
still allow to debug many qemu bugs. Extend this option to the colo
cache.

Signed-off-by: Lukas Straub <lukasstraub2@web.de>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
---
 migration/ram.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/migration/ram.c b/migration/ram.c
index f5d39db4e4..847af461f2 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -56,6 +56,8 @@
 #include "multifd.h"
 #include "sysemu/runstate.h"
 
+#include "hw/boards.h" /* for machine_dump_guest_core() */
+
 #if defined(__linux__)
 #include "qemu/userfaultfd.h"
 #endif /* defined(__linux__) */
@@ -3542,6 +3544,10 @@ int colo_init_ram_cache(void)
                 }
                 return -errno;
             }
+            if (!machine_dump_guest_core(current_machine)) {
+                qemu_madvise(block->colo_cache, block->used_length,
+                             QEMU_MADV_DONTDUMP);
+            }
         }
     }
 
-- 
2.33.1



  parent reply	other threads:[~2021-11-03  8:48 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-03  8:45 [PULL 00/11] Migration 20211102 patches Juan Quintela
2021-11-03  8:45 ` [PULL 01/11] migration: provide an error message to migration_cancel() Juan Quintela
2021-11-03  8:45 ` [PULL 02/11] migration: initialise compression_counters for a new migration Juan Quintela
2021-11-03  8:45 ` [PULL 03/11] migration: Zero migration compression counters Juan Quintela
2021-11-03  8:45 ` [PULL 04/11] Some minor optimizations for COLO Juan Quintela
2021-11-03  8:45 ` [PULL 05/11] Fixed qemu crash when guest power off in COLO mode Juan Quintela
2021-11-03  8:46 ` [PULL 06/11] Fixed SVM hang when do failover before PVM crash Juan Quintela
2021-11-03  8:46 ` [PULL 07/11] colo: fixed 'Segmentation fault' when the simplex mode PVM poweroff Juan Quintela
2021-11-03  8:46 ` [PULL 08/11] Removed the qemu_fclose() in colo_process_incoming_thread Juan Quintela
2021-11-03  8:46 ` [PULL 09/11] Changed the last-mode to none of first start COLO Juan Quintela
2021-11-03  8:46 ` Juan Quintela [this message]
2021-11-03  8:46 ` [PULL 11/11] Optimized the function of fill_connection_key Juan Quintela
2021-11-03 15:06   ` Juan Quintela
2021-11-04 10:32 ` [PULL 00/11] Migration 20211102 patches Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211103084605.20027-11-quintela@redhat.com \
    --to=quintela@redhat.com \
    --cc=chen.zhang@intel.com \
    --cc=dgilbert@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=lizhijian@cn.fujitsu.com \
    --cc=lukasstraub2@web.de \
    --cc=qemu-devel@nongnu.org \
    --cc=zhang.zhanghailiang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).