From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, armbru@redhat.com, jsnow@redhat.com,
vsementsov@virtuozzo.com, eblake@redhat.com,
xiechanglong.d@gmail.com, wencongyang2@huawei.com,
libvir-list@redhat.com, kchamart@redhat.com
Subject: [PATCH v3 1/3] docs/block-replication: use blockdev-backup
Date: Wed, 3 Nov 2021 14:29:10 +0100 [thread overview]
Message-ID: <20211103132912.1977438-2-vsementsov@virtuozzo.com> (raw)
In-Reply-To: <20211103132912.1977438-1-vsementsov@virtuozzo.com>
We are going to deprecate drive-backup, so don't mention it here.
Moreover, blockdev-backup seems more correct in the context.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: John Snow <jsnow@redhat.com>
---
docs/block-replication.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/docs/block-replication.txt b/docs/block-replication.txt
index 108e9166a8..59eb2b33b3 100644
--- a/docs/block-replication.txt
+++ b/docs/block-replication.txt
@@ -79,7 +79,7 @@ Primary | || Secondary disk <--------- hidden-disk 5 <---------
|| | |
|| | |
|| '-------------------------'
- || drive-backup sync=none 6
+ || blockdev-backup sync=none 6
1) The disk on the primary is represented by a block device with two
children, providing replication between a primary disk and the host that
@@ -101,7 +101,7 @@ should support bdrv_make_empty() and backing file.
that is modified by the primary VM. It should also start as an empty disk,
and the driver supports bdrv_make_empty() and backing file.
-6) The drive-backup job (sync=none) is run to allow hidden-disk to buffer
+6) The blockdev-backup job (sync=none) is run to allow hidden-disk to buffer
any state that would otherwise be lost by the speculative write-through
of the NBD server into the secondary disk. So before block replication,
the primary disk and secondary disk should contain the same data.
--
2.31.1
next prev parent reply other threads:[~2021-11-03 13:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-03 13:29 [PATCH v3 0/3] qapi & doc: deprecate drive-backup Vladimir Sementsov-Ogievskiy
2021-11-03 13:29 ` Vladimir Sementsov-Ogievskiy [this message]
2021-11-03 13:29 ` [PATCH v3 2/3] docs/interop/bitmaps: use blockdev-backup Vladimir Sementsov-Ogievskiy
2021-11-03 13:29 ` [PATCH v3 3/3] qapi: deprecate drive-backup Vladimir Sementsov-Ogievskiy
2021-11-04 19:38 ` Eric Blake
2021-11-04 5:54 ` [PATCH v3 0/3] qapi & doc: " Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211103132912.1977438-2-vsementsov@virtuozzo.com \
--to=vsementsov@virtuozzo.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=jsnow@redhat.com \
--cc=kchamart@redhat.com \
--cc=libvir-list@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=wencongyang2@huawei.com \
--cc=xiechanglong.d@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).