From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D41DFC433EF for ; Thu, 4 Nov 2021 20:52:48 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8B12961106 for ; Thu, 4 Nov 2021 20:52:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8B12961106 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:47982 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mijj5-0006xG-MP for qemu-devel@archiver.kernel.org; Thu, 04 Nov 2021 16:52:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45566) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mijhc-0005s4-0s for qemu-devel@nongnu.org; Thu, 04 Nov 2021 16:51:16 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:53104) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mijhX-00023t-CD for qemu-devel@nongnu.org; Thu, 04 Nov 2021 16:51:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1636059069; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=shpWT+bi4lD+/I8YO5upbyQ/jGvb1GXJU+K4nXDSV2I=; b=ZAxMedo+WqrTqEugZKv0FAV5GahB7NWHuM6Gfw5Y/qPsEh/KTXC94vxES1LCIiPZ2+I6gw zA/eFraQ/2XfJyvFhzvJ/nFotzf/YqduRAGbMMasOxuJdeO256J485BMa1pKIACEmrMsj7 BJLKxiOtv/l7N81IhF5Zl/xZliUdfFo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-317-9tY-m5WfP8yhY6PNypr85Q-1; Thu, 04 Nov 2021 16:51:04 -0400 X-MC-Unique: 9tY-m5WfP8yhY6PNypr85Q-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1EAE68799EC; Thu, 4 Nov 2021 20:51:03 +0000 (UTC) Received: from redhat.com (ovpn-112-104.phx2.redhat.com [10.3.112.104]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 748383A08; Thu, 4 Nov 2021 20:50:48 +0000 (UTC) Date: Thu, 4 Nov 2021 15:50:46 -0500 From: Eric Blake To: huangy81@chinatelecom.cn Subject: Re: [PATCH v7 2/2] migration/dirtyrate: implement dirty-bitmap dirtyrate calculation Message-ID: <20211104205046.sen2xsk3zyfv4bdw@redhat.com> References: <7397a1b19b8b520aaa9612bb410bf2d20daf5147.1626794163.git.huangy81@chinatelecom.cn> MIME-Version: 1.0 In-Reply-To: <7397a1b19b8b520aaa9612bb410bf2d20daf5147.1626794163.git.huangy81@chinatelecom.cn> User-Agent: NeoMutt/20211029-10-fe244a X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=eblake@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=eblake@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -33 X-Spam_score: -3.4 X-Spam_bar: --- X-Spam_report: (-3.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.648, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eduardo Habkost , Juan Quintela , qemu-devel@nongnu.org, Peter Xu , "Dr. David Alan Gilbert" , Chuan Zheng , Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, Jul 20, 2021 at 11:19:17PM +0800, huangy81@chinatelecom.cn wrote: > From: Hyman Huang(黄勇) > > introduce dirty-bitmap mode as the third method of calc-dirty-rate. > implement dirty-bitmap dirtyrate calculation, which can be used > to measuring dirtyrate in the absence of dirty-ring. > > introduce "dirty_bitmap:-b" option in hmp calc_dirty_rate to > indicate dirty bitmap method should be used for calculation. > > Signed-off-by: Hyman Huang(黄勇) > --- > +++ b/qapi/migration.json > @@ -1747,13 +1747,15 @@ > # > # @page-sampling: calculate dirtyrate by sampling pages. > # > -# @dirty-ring: calculate dirtyrate by via dirty ring. > +# @dirty-ring: calculate dirtyrate by dirty ring. > +# > +# @dirty-bitmap: calculate dirtyrate by dirty bitmap. Missing a '(since 6.2)' tag. > # > # Since: 6.1 > # > ## > { 'enum': 'DirtyRateMeasureMode', > - 'data': ['page-sampling', 'dirty-ring'] } > + 'data': ['page-sampling', 'dirty-ring', 'dirty-bitmap'] } > -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org