qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: f4bug@amsat.org, laurent@vivier.eu
Subject: [PATCH 3/4] linux-user: Fix member types of target_dirent64
Date: Sun,  7 Nov 2021 07:48:44 -0500	[thread overview]
Message-ID: <20211107124845.1174791-4-richard.henderson@linaro.org> (raw)
In-Reply-To: <20211107124845.1174791-1-richard.henderson@linaro.org>

The host uint64_t (etc) does not have the correct
alignment constraint as the guest: use abi_* types.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 linux-user/syscall_defs.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/linux-user/syscall_defs.h b/linux-user/syscall_defs.h
index 98b09ee6d6..41aaafbac1 100644
--- a/linux-user/syscall_defs.h
+++ b/linux-user/syscall_defs.h
@@ -437,9 +437,9 @@ struct target_dirent {
 };
 
 struct target_dirent64 {
-	uint64_t	d_ino;
-	int64_t		d_off;
-	unsigned short	d_reclen;
+	abi_ullong      d_ino;
+	abi_llong       d_off;
+	abi_ushort      d_reclen;
 	unsigned char	d_type;
 	char		d_name[];
 };
-- 
2.25.1



  parent reply	other threads:[~2021-11-07 12:53 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-07 12:48 [PATCH 0/4] linux-user: Fix getdents alignment issues (#704) Richard Henderson
2021-11-07 12:48 ` [PATCH 1/4] linux-user: Split out do_getdents, do_getdents64 Richard Henderson
2021-11-08  7:42   ` Philippe Mathieu-Daudé
2021-11-09 16:45   ` Warner Losh
2021-11-07 12:48 ` [PATCH 2/4] linux-user: Always use flexible arrays for dirent d_name Richard Henderson
2021-11-08  7:40   ` Philippe Mathieu-Daudé
2021-11-09 16:43   ` Warner Losh
2021-11-07 12:48 ` Richard Henderson [this message]
2021-11-08  7:40   ` [PATCH 3/4] linux-user: Fix member types of target_dirent64 Philippe Mathieu-Daudé
2021-11-09 16:44   ` Warner Losh
2021-11-07 12:48 ` [PATCH 4/4] linux-user: Rewrite do_getdents, do_getdents64 Richard Henderson
2021-11-09 16:46 ` [PATCH 0/4] linux-user: Fix getdents alignment issues (#704) Warner Losh
2021-11-10  9:27   ` Richard Henderson
2021-11-10 10:24 ` Laurent Vivier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211107124845.1174791-4-richard.henderson@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=f4bug@amsat.org \
    --cc=laurent@vivier.eu \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).