From: Laurent Vivier <laurent@vivier.eu>
To: qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Laurent Vivier <lvivier@redhat.com>,
Thomas Huth <thuth@redhat.com>,
Laurent Vivier <laurent@vivier.eu>
Subject: [PULL 5/6] tests/qtest/virtio-net: fix hotplug test case
Date: Tue, 9 Nov 2021 10:12:37 +0100 [thread overview]
Message-ID: <20211109091238.817997-6-laurent@vivier.eu> (raw)
In-Reply-To: <20211109091238.817997-1-laurent@vivier.eu>
From: Laurent Vivier <lvivier@redhat.com>
virtio-net-test has an hotplug testcase that is never executed.
This is because the testcase is attached to virtio-pci interface
rather than to virtio-net-pci.
$ QTEST_QEMU_BINARY=./qemu-system-x86_64 tests/qtest/qos-test -l | grep hotplug
/x86_64/.../pci-ohci-tests/ohci_pci-test-hotplug
/x86_64/.../e1000e/e1000e-tests/hotplug
/x86_64/.../virtio-blk-pci/virtio-blk-pci-tests/hotplug
/x86_64/.../vhost-user-blk-pci/vhost-user-blk-pci-tests/hotplug
/x86_64/.../virtio-rng-pci/virtio-rng-pci-tests/hotplug
/x86_64/.../virtio-scsi/virtio-scsi-tests/hotplug
/x86_64/.../virtio-serial/virtio-serial-tests/hotplug
With this fix:
$ QTEST_QEMU_BINARY=./qemu-system-x86_64 tests/qtest/qos-test -l | grep hotplug
...
/x86_64/.../vhost-user-blk-pci/vhost-user-blk-pci-tests/hotplug
/x86_64/.../virtio-net-pci/virtio-net-pci-tests/hotplug
/x86_64/.../virtio-rng-pci/virtio-rng-pci-tests/hotplug
...
$ QTEST_QEMU_BINARY=./qemu-system-x86_64 tests/qtest/qos-test -p /x86_64/.../virtio-net-pci-tests/hotplug
/x86_64/pc/i440FX-pcihost/pci-bus-pc/pci-bus/virtio-net-pci/virtio-net-pci-tests/hotplug: OK
Fixes: 6ae333f91b99 ("qos-test: virtio-net test node")
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Acked-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20211028173014.139692-1-lvivier@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
tests/qtest/virtio-net-test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qtest/virtio-net-test.c b/tests/qtest/virtio-net-test.c
index a08e2ffe123f..8bf74e516cce 100644
--- a/tests/qtest/virtio-net-test.c
+++ b/tests/qtest/virtio-net-test.c
@@ -319,7 +319,7 @@ static void register_virtio_net_test(void)
.before = virtio_net_test_setup,
};
- qos_add_test("hotplug", "virtio-pci", hotplug, &opts);
+ qos_add_test("hotplug", "virtio-net-pci", hotplug, &opts);
#ifndef _WIN32
qos_add_test("basic", "virtio-net", send_recv_test, &opts);
qos_add_test("rx_stop_cont", "virtio-net", stop_cont_test, &opts);
--
2.31.1
next prev parent reply other threads:[~2021-11-09 9:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-09 9:12 [PULL 0/6] Trivial branch for 6.2 patches Laurent Vivier
2021-11-09 9:12 ` [PULL 1/6] hmp: Add shortcut to stop command to match cont Laurent Vivier
2021-11-09 9:12 ` [PULL 2/6] hw/m68k: Fix typo in SPDX tag Laurent Vivier
2021-11-09 9:12 ` [PULL 3/6] .mailmap: Fix more contributor entries Laurent Vivier
2021-11-09 9:12 ` [PULL 4/6] meson: Fix 'interpretor' typo Laurent Vivier
2021-11-09 9:12 ` Laurent Vivier [this message]
2021-11-09 9:12 ` [PULL 6/6] docs/about/deprecated: Remove empty 'related binaries' section Laurent Vivier
2021-11-09 12:14 ` [PULL 0/6] Trivial branch for 6.2 patches Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211109091238.817997-6-laurent@vivier.eu \
--to=laurent@vivier.eu \
--cc=lvivier@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).