* [PULL 1/6] hmp: Add shortcut to stop command to match cont
2021-11-09 9:12 [PULL 0/6] Trivial branch for 6.2 patches Laurent Vivier
@ 2021-11-09 9:12 ` Laurent Vivier
2021-11-09 9:12 ` [PULL 2/6] hw/m68k: Fix typo in SPDX tag Laurent Vivier
` (5 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Laurent Vivier @ 2021-11-09 9:12 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Daniel P . Berrangé, Laurent Vivier
From: BALATON Zoltan <balaton@eik.bme.hu>
Some commands such as quit or cont have one letter alternatives but
stop is missing that. Add stop|s to match cont|c for consistency and
convenience.
Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20211030095225.513D4748F48@zero.eik.bme.hu>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
hmp-commands.hx | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hmp-commands.hx b/hmp-commands.hx
index 3a5aeba3fe8a..70a9136ac293 100644
--- a/hmp-commands.hx
+++ b/hmp-commands.hx
@@ -382,7 +382,7 @@ SRST
ERST
{
- .name = "stop",
+ .name = "stop|s",
.args_type = "",
.params = "",
.help = "stop emulation",
@@ -390,7 +390,7 @@ ERST
},
SRST
-``stop``
+``stop`` or ``s``
Stop emulation.
ERST
--
2.31.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PULL 2/6] hw/m68k: Fix typo in SPDX tag
2021-11-09 9:12 [PULL 0/6] Trivial branch for 6.2 patches Laurent Vivier
2021-11-09 9:12 ` [PULL 1/6] hmp: Add shortcut to stop command to match cont Laurent Vivier
@ 2021-11-09 9:12 ` Laurent Vivier
2021-11-09 9:12 ` [PULL 3/6] .mailmap: Fix more contributor entries Laurent Vivier
` (4 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Laurent Vivier @ 2021-11-09 9:12 UTC (permalink / raw)
To: qemu-devel
Cc: qemu-trivial, Richard Henderson, Philippe Mathieu-Daudé,
Laurent Vivier
From: Philippe Mathieu-Daudé <f4bug@amsat.org>
Fix 'Identifer' -> 'Identifier' typo.
Cc: Laurent Vivier <laurent@vivier.eu>
Fixes: 8c6df16ff60 ("hw/char: add goldfish-tty")
Fixes: 87855593903 ("hw/intc: add goldfish-pic")
Fixes: 2fde99ee312 ("m68k: add an interrupt controller")
Fixes: 0791bc02b8f ("m68k: add a system controller")
Fixes: e1cecdca559 ("m68k: add Virtual M68k Machine")
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Message-Id: <20211103105311.3399293-1-f4bug@amsat.org>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
hw/char/goldfish_tty.c | 2 +-
hw/intc/goldfish_pic.c | 2 +-
hw/intc/m68k_irqc.c | 2 +-
hw/m68k/virt.c | 2 +-
hw/misc/virt_ctrl.c | 2 +-
include/hw/char/goldfish_tty.h | 2 +-
include/hw/intc/goldfish_pic.h | 2 +-
include/hw/intc/m68k_irqc.h | 2 +-
include/hw/misc/virt_ctrl.h | 2 +-
9 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/hw/char/goldfish_tty.c b/hw/char/goldfish_tty.c
index 8365a1876145..20b77885c180 100644
--- a/hw/char/goldfish_tty.c
+++ b/hw/char/goldfish_tty.c
@@ -1,5 +1,5 @@
/*
- * SPDX-License-Identifer: GPL-2.0-or-later
+ * SPDX-License-Identifier: GPL-2.0-or-later
*
* Goldfish TTY
*
diff --git a/hw/intc/goldfish_pic.c b/hw/intc/goldfish_pic.c
index e3b43a69f163..dfd53275f692 100644
--- a/hw/intc/goldfish_pic.c
+++ b/hw/intc/goldfish_pic.c
@@ -1,5 +1,5 @@
/*
- * SPDX-License-Identifer: GPL-2.0-or-later
+ * SPDX-License-Identifier: GPL-2.0-or-later
*
* Goldfish PIC
*
diff --git a/hw/intc/m68k_irqc.c b/hw/intc/m68k_irqc.c
index 2133d2a698ab..0c515e4ecb79 100644
--- a/hw/intc/m68k_irqc.c
+++ b/hw/intc/m68k_irqc.c
@@ -1,5 +1,5 @@
/*
- * SPDX-License-Identifer: GPL-2.0-or-later
+ * SPDX-License-Identifier: GPL-2.0-or-later
*
* QEMU Motorola 680x0 IRQ Controller
*
diff --git a/hw/m68k/virt.c b/hw/m68k/virt.c
index 4e8bce5aa6f7..edc58fbddae4 100644
--- a/hw/m68k/virt.c
+++ b/hw/m68k/virt.c
@@ -1,5 +1,5 @@
/*
- * SPDX-License-Identifer: GPL-2.0-or-later
+ * SPDX-License-Identifier: GPL-2.0-or-later
*
* QEMU Vitual M68K Machine
*
diff --git a/hw/misc/virt_ctrl.c b/hw/misc/virt_ctrl.c
index 3552d7a09abd..e75d1e7e17b3 100644
--- a/hw/misc/virt_ctrl.c
+++ b/hw/misc/virt_ctrl.c
@@ -1,5 +1,5 @@
/*
- * SPDX-License-Identifer: GPL-2.0-or-later
+ * SPDX-License-Identifier: GPL-2.0-or-later
*
* Virt system Controller
*/
diff --git a/include/hw/char/goldfish_tty.h b/include/hw/char/goldfish_tty.h
index b9dd67362a68..7503d2fa1e15 100644
--- a/include/hw/char/goldfish_tty.h
+++ b/include/hw/char/goldfish_tty.h
@@ -1,5 +1,5 @@
/*
- * SPDX-License-Identifer: GPL-2.0-or-later
+ * SPDX-License-Identifier: GPL-2.0-or-later
*
* Goldfish TTY
*
diff --git a/include/hw/intc/goldfish_pic.h b/include/hw/intc/goldfish_pic.h
index ad13ab37fc3e..e9d552f79682 100644
--- a/include/hw/intc/goldfish_pic.h
+++ b/include/hw/intc/goldfish_pic.h
@@ -1,5 +1,5 @@
/*
- * SPDX-License-Identifer: GPL-2.0-or-later
+ * SPDX-License-Identifier: GPL-2.0-or-later
*
* Goldfish PIC
*
diff --git a/include/hw/intc/m68k_irqc.h b/include/hw/intc/m68k_irqc.h
index dbcfcfc2e000..ef91f218122e 100644
--- a/include/hw/intc/m68k_irqc.h
+++ b/include/hw/intc/m68k_irqc.h
@@ -1,5 +1,5 @@
/*
- * SPDX-License-Identifer: GPL-2.0-or-later
+ * SPDX-License-Identifier: GPL-2.0-or-later
*
* QEMU Motorola 680x0 IRQ Controller
*
diff --git a/include/hw/misc/virt_ctrl.h b/include/hw/misc/virt_ctrl.h
index edfadc469505..25a237e51874 100644
--- a/include/hw/misc/virt_ctrl.h
+++ b/include/hw/misc/virt_ctrl.h
@@ -1,5 +1,5 @@
/*
- * SPDX-License-Identifer: GPL-2.0-or-later
+ * SPDX-License-Identifier: GPL-2.0-or-later
*
* Virt system Controller
*/
--
2.31.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PULL 3/6] .mailmap: Fix more contributor entries
2021-11-09 9:12 [PULL 0/6] Trivial branch for 6.2 patches Laurent Vivier
2021-11-09 9:12 ` [PULL 1/6] hmp: Add shortcut to stop command to match cont Laurent Vivier
2021-11-09 9:12 ` [PULL 2/6] hw/m68k: Fix typo in SPDX tag Laurent Vivier
@ 2021-11-09 9:12 ` Laurent Vivier
2021-11-09 9:12 ` [PULL 4/6] meson: Fix 'interpretor' typo Laurent Vivier
` (3 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Laurent Vivier @ 2021-11-09 9:12 UTC (permalink / raw)
To: qemu-devel
Cc: qemu-trivial, Hyman Huang, Pan Nengyuan,
Philippe Mathieu-Daudé, Laurent Vivier, Alex Chen,
Haibin Zhang
From: Philippe Mathieu-Daudé <f4bug@amsat.org>
These authors have some incorrect author email field.
Acked-by: Pan Nengyuan <pannengyuan@huawei.com>
Reviewed-by: Alex Chen <alex.chen@huawei.com>
Reviewed-by: Hyman Huang <huangy81@chinatelecom.cn>
Reviewed-by: Haibin Zhang <haibinzhang@tencent.com>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20211027043254.1248097-1-f4bug@amsat.org>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
.mailmap | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/.mailmap b/.mailmap
index f029d1c21fe8..8beb2f95ae28 100644
--- a/.mailmap
+++ b/.mailmap
@@ -69,6 +69,7 @@ Yongbok Kim <yongbok.kim@mips.com> <yongbok.kim@imgtec.com>
# git author config, or had utf8/latin1 encoding issues.
Aaron Lindsay <aaron@os.amperecomputing.com>
Alexey Gerasimenko <x1917x@gmail.com>
+Alex Chen <alex.chen@huawei.com>
Alex Ivanov <void@aleksoft.net>
Andreas Färber <afaerber@suse.de>
Bandan Das <bsd@redhat.com>
@@ -99,9 +100,11 @@ Gautham R. Shenoy <ego@in.ibm.com>
Gautham R. Shenoy <ego@linux.vnet.ibm.com>
Gonglei (Arei) <arei.gonglei@huawei.com>
Guang Wang <wang.guang55@zte.com.cn>
+Haibin Zhang <haibinzhang@tencent.com>
Hailiang Zhang <zhang.zhanghailiang@huawei.com>
Hanna Reitz <hreitz@redhat.com> <mreitz@redhat.com>
Hervé Poussineau <hpoussin@reactos.org>
+Hyman Huang <huangy81@chinatelecom.cn>
Jakub Jermář <jakub@jermar.eu>
Jakub Jermář <jakub.jermar@kernkonzept.com>
Jean-Christophe Dubois <jcd@tribudubois.net>
@@ -135,6 +138,7 @@ Nicholas Thomas <nick@bytemark.co.uk>
Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>
Orit Wasserman <owasserm@redhat.com>
Paolo Bonzini <pbonzini@redhat.com>
+Pan Nengyuan <pannengyuan@huawei.com>
Pavel Dovgaluk <dovgaluk@ispras.ru>
Pavel Dovgaluk <pavel.dovgaluk@gmail.com>
Pavel Dovgaluk <Pavel.Dovgaluk@ispras.ru>
--
2.31.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PULL 4/6] meson: Fix 'interpretor' typo
2021-11-09 9:12 [PULL 0/6] Trivial branch for 6.2 patches Laurent Vivier
` (2 preceding siblings ...)
2021-11-09 9:12 ` [PULL 3/6] .mailmap: Fix more contributor entries Laurent Vivier
@ 2021-11-09 9:12 ` Laurent Vivier
2021-11-09 9:12 ` [PULL 5/6] tests/qtest/virtio-net: fix hotplug test case Laurent Vivier
` (2 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Laurent Vivier @ 2021-11-09 9:12 UTC (permalink / raw)
To: qemu-devel
Cc: qemu-trivial, Peter Maydell, Philippe Mathieu-Daudé,
Laurent Vivier
From: Philippe Mathieu-Daudé <philmd@redhat.com>
Fix a typo from commit fa2f7b0b9b7 ("meson: Warn when TCI is
selected but TCG backend is available").
Reported-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Message-Id: <20210521103423.2780345-1-philmd@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meson.build b/meson.build
index 6bfed294d07b..9702fdce6d03 100644
--- a/meson.build
+++ b/meson.build
@@ -340,7 +340,7 @@ if not get_option('tcg').disabled()
error('Unsupported CPU @0@, try --enable-tcg-interpreter'.format(cpu))
endif
elif get_option('tcg_interpreter')
- warning('Use of the TCG interpretor is not recommended on this host')
+ warning('Use of the TCG interpreter is not recommended on this host')
warning('architecture. There is a native TCG execution backend available')
warning('which provides substantially better performance and reliability.')
warning('It is strongly recommended to remove the --enable-tcg-interpreter')
--
2.31.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PULL 5/6] tests/qtest/virtio-net: fix hotplug test case
2021-11-09 9:12 [PULL 0/6] Trivial branch for 6.2 patches Laurent Vivier
` (3 preceding siblings ...)
2021-11-09 9:12 ` [PULL 4/6] meson: Fix 'interpretor' typo Laurent Vivier
@ 2021-11-09 9:12 ` Laurent Vivier
2021-11-09 9:12 ` [PULL 6/6] docs/about/deprecated: Remove empty 'related binaries' section Laurent Vivier
2021-11-09 12:14 ` [PULL 0/6] Trivial branch for 6.2 patches Richard Henderson
6 siblings, 0 replies; 8+ messages in thread
From: Laurent Vivier @ 2021-11-09 9:12 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Laurent Vivier, Thomas Huth, Laurent Vivier
From: Laurent Vivier <lvivier@redhat.com>
virtio-net-test has an hotplug testcase that is never executed.
This is because the testcase is attached to virtio-pci interface
rather than to virtio-net-pci.
$ QTEST_QEMU_BINARY=./qemu-system-x86_64 tests/qtest/qos-test -l | grep hotplug
/x86_64/.../pci-ohci-tests/ohci_pci-test-hotplug
/x86_64/.../e1000e/e1000e-tests/hotplug
/x86_64/.../virtio-blk-pci/virtio-blk-pci-tests/hotplug
/x86_64/.../vhost-user-blk-pci/vhost-user-blk-pci-tests/hotplug
/x86_64/.../virtio-rng-pci/virtio-rng-pci-tests/hotplug
/x86_64/.../virtio-scsi/virtio-scsi-tests/hotplug
/x86_64/.../virtio-serial/virtio-serial-tests/hotplug
With this fix:
$ QTEST_QEMU_BINARY=./qemu-system-x86_64 tests/qtest/qos-test -l | grep hotplug
...
/x86_64/.../vhost-user-blk-pci/vhost-user-blk-pci-tests/hotplug
/x86_64/.../virtio-net-pci/virtio-net-pci-tests/hotplug
/x86_64/.../virtio-rng-pci/virtio-rng-pci-tests/hotplug
...
$ QTEST_QEMU_BINARY=./qemu-system-x86_64 tests/qtest/qos-test -p /x86_64/.../virtio-net-pci-tests/hotplug
/x86_64/pc/i440FX-pcihost/pci-bus-pc/pci-bus/virtio-net-pci/virtio-net-pci-tests/hotplug: OK
Fixes: 6ae333f91b99 ("qos-test: virtio-net test node")
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Acked-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20211028173014.139692-1-lvivier@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
tests/qtest/virtio-net-test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qtest/virtio-net-test.c b/tests/qtest/virtio-net-test.c
index a08e2ffe123f..8bf74e516cce 100644
--- a/tests/qtest/virtio-net-test.c
+++ b/tests/qtest/virtio-net-test.c
@@ -319,7 +319,7 @@ static void register_virtio_net_test(void)
.before = virtio_net_test_setup,
};
- qos_add_test("hotplug", "virtio-pci", hotplug, &opts);
+ qos_add_test("hotplug", "virtio-net-pci", hotplug, &opts);
#ifndef _WIN32
qos_add_test("basic", "virtio-net", send_recv_test, &opts);
qos_add_test("rx_stop_cont", "virtio-net", stop_cont_test, &opts);
--
2.31.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PULL 6/6] docs/about/deprecated: Remove empty 'related binaries' section
2021-11-09 9:12 [PULL 0/6] Trivial branch for 6.2 patches Laurent Vivier
` (4 preceding siblings ...)
2021-11-09 9:12 ` [PULL 5/6] tests/qtest/virtio-net: fix hotplug test case Laurent Vivier
@ 2021-11-09 9:12 ` Laurent Vivier
2021-11-09 12:14 ` [PULL 0/6] Trivial branch for 6.2 patches Richard Henderson
6 siblings, 0 replies; 8+ messages in thread
From: Laurent Vivier @ 2021-11-09 9:12 UTC (permalink / raw)
To: qemu-devel
Cc: Yanan Wang, qemu-trivial, Joaquin de Andres, Laurent Vivier,
Willian Rampazzo, Philippe Mathieu-Daudé
From: Philippe Mathieu-Daudé <philmd@redhat.com>
Commit 497a30dbb06 ("qemu-img: Require -F with -b backing image")
removed the content of the "Related binaries" section but forgot
to remove the section title. Since it is now empty, remove it too.
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Willian Rampazzo <willianr@redhat.com>
Reviewed-by: Yanan Wang <wangyanan55@huawei.com>
Reviewed-by: Joaquin de Andres <me@xcancerberox.com.ar>
Message-Id: <20211105142656.145791-1-philmd@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
docs/about/deprecated.rst | 3 ---
1 file changed, 3 deletions(-)
diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst
index 56f9ad15ab54..5e514fb443da 100644
--- a/docs/about/deprecated.rst
+++ b/docs/about/deprecated.rst
@@ -370,9 +370,6 @@ The ``I7200`` guest CPU relies on the nanoMIPS ISA, which is deprecated
(the ISA has never been upstreamed to a compiler toolchain). Therefore
this CPU is also deprecated.
-Related binaries
-----------------
-
Backwards compatibility
-----------------------
--
2.31.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PULL 0/6] Trivial branch for 6.2 patches
2021-11-09 9:12 [PULL 0/6] Trivial branch for 6.2 patches Laurent Vivier
` (5 preceding siblings ...)
2021-11-09 9:12 ` [PULL 6/6] docs/about/deprecated: Remove empty 'related binaries' section Laurent Vivier
@ 2021-11-09 12:14 ` Richard Henderson
6 siblings, 0 replies; 8+ messages in thread
From: Richard Henderson @ 2021-11-09 12:14 UTC (permalink / raw)
To: Laurent Vivier, qemu-devel; +Cc: qemu-trivial
On 11/9/21 10:12 AM, Laurent Vivier wrote:
> The following changes since commit f10e7b9f6fc18be390b3bc189e04b5147eb8dbf8:
>
> Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-6.2-20211109' into staging (2021-11-09 07:18:33 +0100)
>
> are available in the Git repository at:
>
> git://github.com/vivier/qemu.git tags/trivial-branch-for-6.2-pull-request
>
> for you to fetch changes up to 66d96a1901b7d9cfdbc454d407710ca8bfb90947:
>
> docs/about/deprecated: Remove empty 'related binaries' section (2021-11-09 10:11:27 +0100)
>
> ----------------------------------------------------------------
> Trivial branch patches pull request 20211109
>
> ----------------------------------------------------------------
>
> BALATON Zoltan (1):
> hmp: Add shortcut to stop command to match cont
>
> Laurent Vivier (1):
> tests/qtest/virtio-net: fix hotplug test case
>
> Philippe Mathieu-Daudé (4):
> hw/m68k: Fix typo in SPDX tag
> .mailmap: Fix more contributor entries
> meson: Fix 'interpretor' typo
> docs/about/deprecated: Remove empty 'related binaries' section
>
> .mailmap | 4 ++++
> docs/about/deprecated.rst | 3 ---
> hmp-commands.hx | 4 ++--
> hw/char/goldfish_tty.c | 2 +-
> hw/intc/goldfish_pic.c | 2 +-
> hw/intc/m68k_irqc.c | 2 +-
> hw/m68k/virt.c | 2 +-
> hw/misc/virt_ctrl.c | 2 +-
> include/hw/char/goldfish_tty.h | 2 +-
> include/hw/intc/goldfish_pic.h | 2 +-
> include/hw/intc/m68k_irqc.h | 2 +-
> include/hw/misc/virt_ctrl.h | 2 +-
> meson.build | 2 +-
> tests/qtest/virtio-net-test.c | 2 +-
> 14 files changed, 17 insertions(+), 16 deletions(-)
Applied, thanks.
r~
^ permalink raw reply [flat|nested] 8+ messages in thread