* [PATCH] target/i386: sgx: mark device not user creatable
@ 2021-11-09 17:50 Paolo Bonzini
2021-11-09 17:57 ` Thomas Huth
2021-11-11 14:02 ` Philippe Mathieu-Daudé
0 siblings, 2 replies; 3+ messages in thread
From: Paolo Bonzini @ 2021-11-09 17:50 UTC (permalink / raw)
To: qemu-devel; +Cc: Thomas Huth
The device is created by the machine based on the sgx-epc property.
It should not be created by users.
Reported-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
hw/i386/sgx-epc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/i386/sgx-epc.c b/hw/i386/sgx-epc.c
index 55e2217eae..e508827e78 100644
--- a/hw/i386/sgx-epc.c
+++ b/hw/i386/sgx-epc.c
@@ -154,6 +154,7 @@ static void sgx_epc_class_init(ObjectClass *oc, void *data)
dc->realize = sgx_epc_realize;
dc->unrealize = sgx_epc_unrealize;
dc->desc = "SGX EPC section";
+ dc->user_creatable = false;
device_class_set_props(dc, sgx_epc_properties);
mdc->get_addr = sgx_epc_md_get_addr;
--
2.33.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] target/i386: sgx: mark device not user creatable
2021-11-09 17:50 [PATCH] target/i386: sgx: mark device not user creatable Paolo Bonzini
@ 2021-11-09 17:57 ` Thomas Huth
2021-11-11 14:02 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Huth @ 2021-11-09 17:57 UTC (permalink / raw)
To: Paolo Bonzini, qemu-devel
On 09/11/2021 18.50, Paolo Bonzini wrote:
> The device is created by the machine based on the sgx-epc property.
> It should not be created by users.
>
> Reported-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> hw/i386/sgx-epc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/i386/sgx-epc.c b/hw/i386/sgx-epc.c
> index 55e2217eae..e508827e78 100644
> --- a/hw/i386/sgx-epc.c
> +++ b/hw/i386/sgx-epc.c
> @@ -154,6 +154,7 @@ static void sgx_epc_class_init(ObjectClass *oc, void *data)
> dc->realize = sgx_epc_realize;
> dc->unrealize = sgx_epc_unrealize;
> dc->desc = "SGX EPC section";
> + dc->user_creatable = false;
> device_class_set_props(dc, sgx_epc_properties);
>
> mdc->get_addr = sgx_epc_md_get_addr;
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] target/i386: sgx: mark device not user creatable
2021-11-09 17:50 [PATCH] target/i386: sgx: mark device not user creatable Paolo Bonzini
2021-11-09 17:57 ` Thomas Huth
@ 2021-11-11 14:02 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-11-11 14:02 UTC (permalink / raw)
To: Paolo Bonzini, qemu-devel; +Cc: Thomas Huth
On 11/9/21 18:50, Paolo Bonzini wrote:
> The device is created by the machine based on the sgx-epc property.
> It should not be created by users.
>
> Reported-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> hw/i386/sgx-epc.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-11-11 14:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-11-09 17:50 [PATCH] target/i386: sgx: mark device not user creatable Paolo Bonzini
2021-11-09 17:57 ` Thomas Huth
2021-11-11 14:02 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).