qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Igor Mammedov <imammedo@redhat.com>
To: qemu-devel@nongnu.org
Cc: mapfelba@redhat.com, mst@redhat.com, jusual@redhat.com,
	qemu-stable@nongnu.org, kraxel@redhat.com, ani@anisinha.ca
Subject: [PATCH for 6.2 v2 1/5] pcie: rename 'native-hotplug' to 'x-native-hotplug'
Date: Wed, 10 Nov 2021 16:11:36 -0500	[thread overview]
Message-ID: <20211110211140.3057199-2-imammedo@redhat.com> (raw)
In-Reply-To: <20211110211140.3057199-1-imammedo@redhat.com>

Mark property as experimental/internal adding 'x-' prefix.

Property was introduced in 6.1 and it should have provided
ability to turn on native PCIE hotplug on port even when
ACPI PCI hotplug is in use is user explicitly sets property
on CLI. However that never worked since slot is wired to
ACPI hotplug controller.
Another non-intended usecase: disable native hotplug on slot
when APCI based hotplug is disabled, which works but slot has
'hotplug' property for this taks.

It should be relatively safe to rename it to experimental
as no users should exist for it and given that the property
is broken we don't really want to leave it around for much
longer lest users start using it.

Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
CC: qemu-stable@nongnu.org
---
 hw/i386/pc_q35.c   | 2 +-
 hw/pci/pcie_port.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c
index 797e09500b..fc34b905ee 100644
--- a/hw/i386/pc_q35.c
+++ b/hw/i386/pc_q35.c
@@ -243,7 +243,7 @@ static void pc_q35_init(MachineState *machine)
                                           NULL);
 
     if (acpi_pcihp) {
-        object_register_sugar_prop(TYPE_PCIE_SLOT, "native-hotplug",
+        object_register_sugar_prop(TYPE_PCIE_SLOT, "x-native-hotplug",
                                    "false", true);
     }
 
diff --git a/hw/pci/pcie_port.c b/hw/pci/pcie_port.c
index da850e8dde..e95c1e5519 100644
--- a/hw/pci/pcie_port.c
+++ b/hw/pci/pcie_port.c
@@ -148,7 +148,7 @@ static Property pcie_slot_props[] = {
     DEFINE_PROP_UINT8("chassis", PCIESlot, chassis, 0),
     DEFINE_PROP_UINT16("slot", PCIESlot, slot, 0),
     DEFINE_PROP_BOOL("hotplug", PCIESlot, hotplug, true),
-    DEFINE_PROP_BOOL("native-hotplug", PCIESlot, native_hotplug, true),
+    DEFINE_PROP_BOOL("x-native-hotplug", PCIESlot, native_hotplug, true),
     DEFINE_PROP_END_OF_LIST()
 };
 
-- 
2.27.0



  reply	other threads:[~2021-11-10 21:14 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-10 21:11 [PATCH for 6.2 v2 0/5] Fix Q35 ACPI PCI Hot-plug I/O issues Igor Mammedov
2021-11-10 21:11 ` Igor Mammedov [this message]
2021-11-11  3:25   ` [PATCH for 6.2 v2 1/5] pcie: rename 'native-hotplug' to 'x-native-hotplug' Ani Sinha
2021-11-12 10:47     ` Igor Mammedov
2021-11-15 10:01       ` Ani Sinha
2021-11-10 21:11 ` [PATCH for 6.2 v2 2/5] hw/acpi/ich9: Add compat prop to keep HPC bit set for 6.1 machine type Igor Mammedov
2021-11-15 10:05   ` Ani Sinha
2021-11-16  8:02     ` Ani Sinha
2021-11-10 21:11 ` [PATCH for 6.2 v2 3/5] bios-tables-test: Allow changes in DSDT ACPI tables Igor Mammedov
2021-11-11  5:55   ` Ani Sinha
2021-11-10 21:11 ` [PATCH for 6.2 v2 4/5] hw/i386/acpi-build: Deny control on PCIe Native Hot-plug in _OSC Igor Mammedov
2021-11-11  5:49   ` Ani Sinha
2021-11-12 10:51     ` Igor Mammedov
2021-11-10 21:11 ` [PATCH for 6.2 v2 5/5] bios-tables-test: Update golden binaries Igor Mammedov
2021-11-11  5:51   ` Ani Sinha
2021-11-11  8:34   ` Michael S. Tsirkin
2021-11-11  9:27     ` Ani Sinha
2021-11-11  9:44       ` Ani Sinha
2021-11-12  8:56         ` Ani Sinha
2021-11-11 11:32     ` Igor Mammedov
2021-11-11 13:47       ` Thomas Lamprecht
2021-11-11 15:31       ` Michael S. Tsirkin
2021-11-12  9:47 ` [PATCH for 6.2 v2 0/5] Fix Q35 ACPI PCI Hot-plug I/O issues Michael S. Tsirkin
2021-11-12 10:17   ` Igor Mammedov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211110211140.3057199-2-imammedo@redhat.com \
    --to=imammedo@redhat.com \
    --cc=ani@anisinha.ca \
    --cc=jusual@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=mapfelba@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).