From: Andrew Jones <drjones@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: Thomas Huth <thuth@redhat.com>,
Eduardo Habkost <ehabkost@redhat.com>,
qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>,
Yanan Wang <wangyanan55@huawei.com>
Subject: Re: [PATCH-for-6.2 v3 3/6] tests/unit/test-smp-parse: Explicit MachineClass name
Date: Thu, 11 Nov 2021 13:56:22 +0100 [thread overview]
Message-ID: <20211111125622.32ehb747dzfppmwh@gator.home> (raw)
In-Reply-To: <20211111100351.2153662-4-philmd@redhat.com>
On Thu, Nov 11, 2021 at 11:03:48AM +0100, Philippe Mathieu-Daudé wrote:
> If the MachineClass::name pointer is not explicitly set, it is NULL.
> Per the C standard, passing a NULL pointer to printf "%s" format is
> undefined. Some implementations display it as 'NULL', other as 'null'.
> Since we are comparing the formatted output, we need a stable value.
> The easiest is to explicit a machine name string.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Fixes: 9e8e393bb7 ("tests/unit: Add an unit test for smp parsing")
Reported-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Suggested-by: Yanan Wang <wangyanan55@huawei.com>
Reviewed-by: Andrew Jones <drjones@redhat.com>
next prev parent reply other threads:[~2021-11-11 12:58 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-11 10:03 [PATCH-for-6.2 v3 0/6] tests/unit: Fix test-smp-parse Philippe Mathieu-Daudé
2021-11-11 10:03 ` [PATCH-for-6.2 v3 1/6] tests/unit/test-smp-parse: Restore MachineClass fields after modifying Philippe Mathieu-Daudé
2021-11-11 14:16 ` Richard Henderson
2021-11-12 2:04 ` wangyanan (Y)
2021-11-15 10:24 ` Philippe Mathieu-Daudé
2021-11-16 11:06 ` wangyanan (Y)
2021-11-11 10:03 ` [PATCH-for-6.2 v3 2/6] tests/unit/test-smp-parse: QOM'ify smp_machine_class_init() Philippe Mathieu-Daudé
2021-11-11 14:18 ` Richard Henderson
2021-11-12 2:05 ` wangyanan (Y)
2021-11-11 10:03 ` [PATCH-for-6.2 v3 3/6] tests/unit/test-smp-parse: Explicit MachineClass name Philippe Mathieu-Daudé
2021-11-11 12:56 ` Andrew Jones [this message]
2021-11-11 14:18 ` Richard Henderson
2021-11-12 2:28 ` wangyanan (Y)
2021-11-15 10:16 ` Philippe Mathieu-Daudé
2021-11-16 11:15 ` wangyanan (Y)
2021-11-11 10:03 ` [PATCH-for-6.2 v3 4/6] tests/unit/test-smp-parse: Simplify pointer to compound literal use Philippe Mathieu-Daudé
2021-11-11 14:19 ` Richard Henderson
2021-11-12 2:46 ` wangyanan (Y)
2021-11-11 10:03 ` [PATCH-for-6.2 v3 5/6] tests/unit/test-smp-parse: Constify some pointer/struct Philippe Mathieu-Daudé
2021-11-11 14:20 ` Richard Henderson
2021-11-12 3:12 ` wangyanan (Y)
2021-11-11 10:03 ` [PATCH-for-6.2 v3 6/6] hw/core: Rename smp_parse() -> machine_parse_smp_config() Philippe Mathieu-Daudé
2021-11-11 14:20 ` Richard Henderson
2021-11-12 3:22 ` wangyanan (Y)
2021-11-11 12:57 ` [PATCH-for-6.2 v3 0/6] tests/unit: Fix test-smp-parse Andrew Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211111125622.32ehb747dzfppmwh@gator.home \
--to=drjones@redhat.com \
--cc=armbru@redhat.com \
--cc=ehabkost@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=wangyanan55@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).