From: John Snow <jsnow@redhat.com>
To: qemu-devel@nongnu.org
Cc: Thomas Huth <thuth@redhat.com>, John Snow <jsnow@redhat.com>,
Eduardo Habkost <ehabkost@redhat.com>,
Cleber Rosa <crosa@redhat.com>
Subject: [PATCH 4/5] scripts/device-crash-test: don't emit AQMP connection errors to stdout
Date: Thu, 11 Nov 2021 09:37:18 -0500 [thread overview]
Message-ID: <20211111143719.2162525-5-jsnow@redhat.com> (raw)
In-Reply-To: <20211111143719.2162525-1-jsnow@redhat.com>
These errors are expected, so they shouldn't clog up terminal output. In
the event that they're *not* expected, we'll be seeing an awful lot more
output concerning the nature of the failure.
Reported-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: John Snow <jsnow@redhat.com>
---
scripts/device-crash-test | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/scripts/device-crash-test b/scripts/device-crash-test
index d91e8616ef..49bcd61b4f 100755
--- a/scripts/device-crash-test
+++ b/scripts/device-crash-test
@@ -499,6 +499,12 @@ def main():
lvl = logging.WARN
logging.basicConfig(stream=sys.stdout, level=lvl, format='%(levelname)s: %(message)s')
+ if not args.debug:
+ # Async QMP, when in use, is chatty about connection failures.
+ # This script knowingly generates a ton of connection errors.
+ # Silence this logger.
+ logging.getLogger('qemu.aqmp.qmp_client').setLevel(logging.CRITICAL)
+
fatal_failures = []
wl_stats = {}
skipped = 0
--
2.31.1
next prev parent reply other threads:[~2021-11-11 14:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-11 14:37 [PATCH 0/5] python/aqmp: improve support for device-crash-test John Snow
2021-11-11 14:37 ` [PATCH 1/5] python/aqmp: Fix disconnect during capabilities negotiation John Snow
2021-11-11 14:37 ` [PATCH 2/5] python/aqmp: fix ConnectError string method John Snow
2021-11-11 14:37 ` [PATCH 3/5] scripts/device-crash-test: simplify Exception handling John Snow
2021-11-11 14:37 ` John Snow [this message]
2021-11-11 14:37 ` [PATCH 5/5] scripts/device-crash-test: hide tracebacks for QMP connect errors John Snow
2021-11-12 7:20 ` [PATCH 0/5] python/aqmp: improve support for device-crash-test Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211111143719.2162525-5-jsnow@redhat.com \
--to=jsnow@redhat.com \
--cc=crosa@redhat.com \
--cc=ehabkost@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).