From: "Eugenio Pérez" <eperezma@redhat.com>
To: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Cc: Laurent Vivier <lvivier@redhat.com>,
Jason Wang <jasowang@redhat.com>, Cindy Lu <lulu@redhat.com>,
"Michael S . Tsirkin" <mst@redhat.com>
Subject: [PATCH 1/2] vdpa: Replace qemu_open_old by qemu_open at
Date: Fri, 12 Nov 2021 20:34:30 +0100 [thread overview]
Message-ID: <20211112193431.2379298-2-eperezma@redhat.com> (raw)
In-Reply-To: <20211112193431.2379298-1-eperezma@redhat.com>
There is no reason to keep using the old one, since we neither use the
variadics arguments nor open it with O_DIRECT.
Also, net_client_init1, the caller of net_init_vhost_vdpa, wants all
net_client_init_fun to use Error API, so it's a good step in that
direction.
Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
---
net/vhost-vdpa.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c
index 49ab322511..6ffb29f4da 100644
--- a/net/vhost-vdpa.c
+++ b/net/vhost-vdpa.c
@@ -261,7 +261,7 @@ int net_init_vhost_vdpa(const Netdev *netdev, const char *name,
assert(netdev->type == NET_CLIENT_DRIVER_VHOST_VDPA);
opts = &netdev->u.vhost_vdpa;
- vdpa_device_fd = qemu_open_old(opts->vhostdev, O_RDWR);
+ vdpa_device_fd = qemu_open(opts->vhostdev, O_RDWR, errp);
if (vdpa_device_fd == -1) {
return -errno;
}
--
2.27.0
next prev parent reply other threads:[~2021-11-12 19:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-12 19:34 [PATCH 0/2] vdpa: Check for existence of opts.vhostdev Eugenio Pérez
2021-11-12 19:34 ` Eugenio Pérez [this message]
2021-11-15 4:22 ` [PATCH 1/2] vdpa: Replace qemu_open_old by qemu_open at Jason Wang
2021-11-12 19:34 ` [PATCH 2/2] vdpa: Check for existence of opts.vhostdev Eugenio Pérez
2021-11-15 4:24 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211112193431.2379298-2-eperezma@redhat.com \
--to=eperezma@redhat.com \
--cc=jasowang@redhat.com \
--cc=lulu@redhat.com \
--cc=lvivier@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).