From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58FA5C433EF for ; Mon, 15 Nov 2021 16:45:59 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 15FB561BB3 for ; Mon, 15 Nov 2021 16:45:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 15FB561BB3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:54308 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mmf7G-0007PH-4l for qemu-devel@archiver.kernel.org; Mon, 15 Nov 2021 11:45:58 -0500 Received: from eggs.gnu.org ([209.51.188.92]:54512) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mmf0I-0003Ds-Hf for qemu-devel@nongnu.org; Mon, 15 Nov 2021 11:38:46 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:45849) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mmf0H-0005G5-3L for qemu-devel@nongnu.org; Mon, 15 Nov 2021 11:38:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1636994324; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Y05iFeqDcZmIQw96oojBdfWCBMxpMBgO3kDemc5FvLM=; b=ZTVvZNW54qv+rTwloBsPW6bhOPknL8qZYO82anCJZql6CFkbfDFcgneIU3CIKMKAyqrGTC RnsSSUSfidM41cVZD9U77us7SkCqVviKfHO9GPssU5CTE2eLl3cK0CIHHfCzIt6VPFQywC G+LDnNKxp5O2RCCPseUuzRGohPnkweA= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-485-5zph96HSN8il0DtEFA8cdA-1; Mon, 15 Nov 2021 11:38:43 -0500 X-MC-Unique: 5zph96HSN8il0DtEFA8cdA-1 Received: by mail-ed1-f71.google.com with SMTP id c1-20020aa7c741000000b003e7bf1da4bcso3256526eds.21 for ; Mon, 15 Nov 2021 08:38:43 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=Y05iFeqDcZmIQw96oojBdfWCBMxpMBgO3kDemc5FvLM=; b=DABcHp+NWDJqod6e9v48yoOSyQ4C8uqUg/76Nod7P0qE2IP04C2IyxF7RwZV58ebpr QoWD5Mocvni4GIq4Fg/ey8u/O5OPYjnL3HSANXj89yRbRkyBpm/c3Q7r6l+okL26s0tT CSzP5rir0hcnXt237GsLgTJjizDfLL2gRpcwWfkFvK24FHi5b4DxPAvKMQeCvPtZKVzT WGQKH5FToLmeovJEwYOQVPPpgXdVkO/7MvLlUagjGO7Cl8OfDsjhSfXmjXWK/KkMUE9B oTw3HM7Gi4qwKqlr4BsH+MXc+kUhFtbXpKMHoNDqlnn3oAjFqholL2BZShXqZJkmOs/q yd2A== X-Gm-Message-State: AOAM532Fdbh8HgDtvXUcbiYt0Pcjs+c0WhIlBtS//Uf32Bcjh5Lvi+uR P/5oqd00U+7WATyBAn3onMj5irEJi6NcYGDseGeCY787dTX8Lm580Y4oRGFOaVosGXBXW/losbd UunkQMLLlpglHzIAMv5YOtHanrnhicPcIQx2QgHrBOAZrTyi/k4DAdduqTwMS X-Received: by 2002:aa7:cd5c:: with SMTP id v28mr106897edw.6.1636994322072; Mon, 15 Nov 2021 08:38:42 -0800 (PST) X-Google-Smtp-Source: ABdhPJwEt4CYrSiztWCX/tzsaTrSvt+SQ3Grz7dYf5kGA/6jU+Gqgh3UqTjV6/7+NSOMLtI2chX6IA== X-Received: by 2002:aa7:cd5c:: with SMTP id v28mr106857edw.6.1636994321865; Mon, 15 Nov 2021 08:38:41 -0800 (PST) Received: from redhat.com ([2a03:c5c0:207e:9a71:d0b:1947:b534:3230]) by smtp.gmail.com with ESMTPSA id m22sm5349428eda.97.2021.11.15.08.38.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Nov 2021 08:38:41 -0800 (PST) Date: Mon, 15 Nov 2021 11:38:38 -0500 From: "Michael S. Tsirkin" To: qemu-devel@nongnu.org Subject: [PULL 13/20] vdpa: Replace qemu_open_old by qemu_open at Message-ID: <20211115163607.177432-14-mst@redhat.com> References: <20211115163607.177432-1-mst@redhat.com> MIME-Version: 1.0 In-Reply-To: <20211115163607.177432-1-mst@redhat.com> X-Mailer: git-send-email 2.27.0.106.g8ac3dc51b1 X-Mutt-Fcc: =sent Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mst@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=mst@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.7, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Jason Wang , Eugenio =?utf-8?B?UMOpcmV6?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" From: Eugenio Pérez There is no reason to keep using the old one, since we neither use the variadics arguments nor open it with O_DIRECT. Also, net_client_init1, the caller of net_init_vhost_vdpa, wants all net_client_init_fun to use Error API, so it's a good step in that direction. Signed-off-by: Eugenio Pérez Message-Id: <20211112193431.2379298-2-eperezma@redhat.com> Acked-by: Jason Wang Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- net/vhost-vdpa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c index 373b706b90..1a7250b980 100644 --- a/net/vhost-vdpa.c +++ b/net/vhost-vdpa.c @@ -261,7 +261,7 @@ int net_init_vhost_vdpa(const Netdev *netdev, const char *name, assert(netdev->type == NET_CLIENT_DRIVER_VHOST_VDPA); opts = &netdev->u.vhost_vdpa; - vdpa_device_fd = qemu_open_old(opts->vhostdev, O_RDWR); + vdpa_device_fd = qemu_open(opts->vhostdev, O_RDWR, errp); if (vdpa_device_fd == -1) { return -errno; } -- MST