From: "Eugenio Pérez" <eperezma@redhat.com>
To: qemu-devel@nongnu.org
Cc: Laurent Vivier <lvivier@redhat.com>,
Jason Wang <jasowang@redhat.com>, Cindy Lu <lulu@redhat.com>,
"Michael S . Tsirkin" <mst@redhat.com>
Subject: [PATCH 0/3] virtio-net: Only enable userland vq if using tap backend
Date: Wed, 17 Nov 2021 20:28:48 +0100 [thread overview]
Message-ID: <20211117192851.65529-1-eperezma@redhat.com> (raw)
Qemu falls back on userland handlers even if vhost-user and vhost-vdpa
cases. These assumes a tap device can handle the packets.
If a vdpa device fail to start, it can trigger a sigsegv because of
that. Do not resort on them unless actually possible.
Tested with tap backend vhost=on and vhost=off, and with vp_vdpa
modified to fail negotiation.
Eugenio Pérez (3):
virtio-net: Fix indentation
virtio-net: Only enable userland vq if using tap backend
virtio-net: Fix log message
include/hw/virtio/virtio.h | 2 ++
hw/net/virtio-net.c | 17 +++++++++++------
hw/virtio/virtio.c | 21 +++++++++++++--------
3 files changed, 26 insertions(+), 14 deletions(-)
--
2.27.0
next reply other threads:[~2021-11-17 19:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-17 19:28 Eugenio Pérez [this message]
2021-11-17 19:28 ` [PATCH 1/3] virtio-net: Fix indentation Eugenio Pérez
2021-11-17 19:28 ` [PATCH 2/3] virtio-net: Only enable userland vq if using tap backend Eugenio Pérez
2021-11-18 5:06 ` Jason Wang
2021-11-18 7:56 ` Eugenio Perez Martin
2021-11-19 2:44 ` Jason Wang
2021-11-19 7:49 ` Eugenio Perez Martin
2021-11-22 2:39 ` Jason Wang
2021-11-22 6:23 ` Eugenio Perez Martin
2021-11-22 6:30 ` Jason Wang
2021-11-17 19:28 ` [PATCH 3/3] virtio-net: Fix log message Eugenio Pérez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211117192851.65529-1-eperezma@redhat.com \
--to=eperezma@redhat.com \
--cc=jasowang@redhat.com \
--cc=lulu@redhat.com \
--cc=lvivier@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).