From: Laurent Vivier <lvivier@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Laurent Vivier" <lvivier@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
"Daniel P . Berrangé" <berrange@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Michael Roth" <michael.roth@amd.com>,
"Juan Quintela" <quintela@redhat.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Ani Sinha" <ani@anisinha.ca>,
"Igor Mammedov" <imammedo@redhat.com>,
"Jens Freimann" <jfreimann@redhat.com>
Subject: [PATCH v3 0/5] tests/qtest: add some tests for virtio-net failover
Date: Thu, 18 Nov 2021 14:32:20 +0100 [thread overview]
Message-ID: <20211118133225.324937-1-lvivier@redhat.com> (raw)
This series adds a qtest entry to test virtio-net failover feature.
We check following error cases:
- check missing id on device with failover_pair_id triggers an error
- check a primary device plugged on a bus that doesn't support hotplug
triggers an error
We check the status of the machine before and after hotplugging cards and
feature negotiation:
- check we don't see the primary device at boot if failover is on
- check we see the primary device at boot if failover is off
- check we don't see the primary device if failover is on
but failover_pair_id is not the one with on (I think this should be changed)
- check the primary device is plugged after the feature negotiation
- check the result if the primary device is plugged before standby device and
vice-versa
- check the if the primary device is coldplugged and the standy device
hotplugged and vice-versa
- check the migration triggers the unplug and the hotplug
There is one preliminary patch in the series:
- PATCH 1 introduces a function to enable PCI bridge.
Failover needs to be plugged on a pcie-root-port and while
the root port is not configured the cards behind it are not
available
v3:
- fix a bug with ACPI unplug and add the related test
v2:
- remove PATCH 1 that introduced a function that can be replaced by
qobject_to_json_pretty() (Markus)
- Add migration to a file and from the file to check the card is
correctly unplugged on the source, and hotplugged on the dest
- Add an ACPI call to eject the card as the kernel would do
Laurent Vivier (5):
qtest/libqos: add a function to initialize secondary PCI buses
tests/qtest: add some tests for virtio-net failover
failover: fix unplug pending detection
libqtest: add a function to use a timeout when waiting for an event
tests/libqtest: update virtio-net failover test
hw/acpi/pcihp.c | 30 +-
include/hw/pci/pci_bridge.h | 8 +
tests/qtest/libqos/libqtest.h | 26 +-
tests/qtest/libqos/pci.c | 118 ++++++
tests/qtest/libqos/pci.h | 1 +
tests/qtest/libqtest.c | 37 +-
tests/qtest/meson.build | 3 +
tests/qtest/virtio-net-failover.c | 644 ++++++++++++++++++++++++++++++
tests/unit/test-qga.c | 2 +-
9 files changed, 859 insertions(+), 10 deletions(-)
create mode 100644 tests/qtest/virtio-net-failover.c
--
2.33.1
next reply other threads:[~2021-11-18 13:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-18 13:32 Laurent Vivier [this message]
2021-11-18 13:32 ` [PATCH v3 1/5] qtest/libqos: add a function to initialize secondary PCI buses Laurent Vivier
2021-11-18 13:32 ` [PATCH v3 2/5] tests/qtest: add some tests for virtio-net failover Laurent Vivier
2021-11-18 13:32 ` [PATCH v3 3/5] failover: fix unplug pending detection Laurent Vivier
2021-11-18 13:32 ` [PATCH v3 4/5] libqtest: add a function to use a timeout when waiting for an event Laurent Vivier
2021-11-18 13:32 ` [PATCH v3 5/5] tests/libqtest: update virtio-net failover test Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211118133225.324937-1-lvivier@redhat.com \
--to=lvivier@redhat.com \
--cc=ani@anisinha.ca \
--cc=berrange@redhat.com \
--cc=imammedo@redhat.com \
--cc=jfreimann@redhat.com \
--cc=kraxel@redhat.com \
--cc=michael.roth@amd.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).