From: "Daniel P. Berrangé" <berrange@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
"Hanna Reitz" <hreitz@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Richard W.M. Jones" <rjones@redhat.com>,
qemu-block@nongnu.org
Subject: [PATCH 0/3] block: misc fixes & improvements for SSH block driver key fingerprints
Date: Thu, 18 Nov 2021 14:35:44 +0000 [thread overview]
Message-ID: <20211118143547.2045554-1-berrange@redhat.com> (raw)
* The docs were pointing people towards the obsolete and insecure
MD5 fingerprint config instead of preferred sha256
* The sha256 fingerprint handling wasn't wired up into the legacy
CLI parsing code
* Finger print check failures were hard to diagnose due to limited
info reported on error.
Daniel P. Berrangé (3):
block: better document SSH host key fingerprint checking
block: support sha256 fingerprint with pre-blockdev options
block: print the server key type and fingerprint on failure
block/ssh.c | 42 +++++++++++++++++++++-----
docs/system/qemu-block-drivers.rst.inc | 30 +++++++++++++++---
2 files changed, 61 insertions(+), 11 deletions(-)
--
2.31.1
next reply other threads:[~2021-11-18 14:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-18 14:35 Daniel P. Berrangé [this message]
2021-11-18 14:35 ` [PATCH 1/3] block: better document SSH host key fingerprint checking Daniel P. Berrangé
2021-12-23 9:37 ` Hanna Reitz
2021-11-18 14:35 ` [PATCH 2/3] block: support sha256 fingerprint with pre-blockdev options Daniel P. Berrangé
2021-12-23 9:45 ` Hanna Reitz
2021-11-18 14:35 ` [PATCH 3/3] block: print the server key type and fingerprint on failure Daniel P. Berrangé
2021-12-23 10:11 ` Hanna Reitz
2021-12-23 10:18 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211118143547.2045554-1-berrange@redhat.com \
--to=berrange@redhat.com \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rjones@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).